From: JeffyChen <jeffy.chen@rock-chips.com>
To: Robin Murphy <robin.murphy@arm.com>,
linux-kernel@vger.kernel.org, tfiga@chromium.org
Cc: jcliang@chromium.org, xxm@rock-chips.com,
devicetree@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU
Date: Thu, 18 Jan 2018 22:25:05 +0800 [thread overview]
Message-ID: <5A60AE41.2050101@rock-chips.com> (raw)
In-Reply-To: <c188e6a9-744c-d984-545c-408607f35cc9@arm.com>
Hi Robin,
On 01/18/2018 08:27 PM, Robin Murphy wrote:
>>
>
> Is it worth using the clk_bulk_*() APIs for this? At a glance, most of
> the code being added here appears to duplicate what those functions
> already do (but I'm no clk API expert, for sure).
right, i think it's doable, the clk_bulk APIs are very helpful. i think
we didn't use that is because this patch were wrote for the chromeos 4.4
kernel, which doesn't have clk_bulk yet:)
will do it in the next version, thanks.
>
> Robin.
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (JeffyChen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU
Date: Thu, 18 Jan 2018 22:25:05 +0800 [thread overview]
Message-ID: <5A60AE41.2050101@rock-chips.com> (raw)
In-Reply-To: <c188e6a9-744c-d984-545c-408607f35cc9@arm.com>
Hi Robin,
On 01/18/2018 08:27 PM, Robin Murphy wrote:
>>
>
> Is it worth using the clk_bulk_*() APIs for this? At a glance, most of
> the code being added here appears to duplicate what those functions
> already do (but I'm no clk API expert, for sure).
right, i think it's doable, the clk_bulk APIs are very helpful. i think
we didn't use that is because this patch were wrote for the chromeos 4.4
kernel, which doesn't have clk_bulk yet:)
will do it in the next version, thanks.
>
> Robin.
next prev parent reply other threads:[~2018-01-18 14:25 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 11:52 [PATCH v4 00/13] iommu/rockchip: Use OF_IOMMU Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
[not found] ` <20180118115251.5542-1-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-18 11:52 ` [PATCH v4 01/13] iommu/rockchip: Prohibit unbind and remove Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` [PATCH v4 02/13] iommu/rockchip: Fix error handling in probe Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` [PATCH v4 04/13] iommu/rockchip: Fix error handling in attach Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
[not found] ` <20180118115251.5542-5-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-18 13:23 ` Robin Murphy
2018-01-18 13:23 ` Robin Murphy
2018-01-18 13:23 ` Robin Murphy
2018-01-18 14:22 ` JeffyChen
2018-01-18 14:22 ` JeffyChen
2018-01-18 11:52 ` [PATCH v4 06/13] iommu/rockchip: Fix TLB flush of secondary IOMMUs Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
[not found] ` <20180118115251.5542-9-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-18 12:27 ` Robin Murphy
2018-01-18 12:27 ` Robin Murphy
2018-01-18 12:27 ` Robin Murphy
2018-01-18 14:25 ` JeffyChen [this message]
2018-01-18 14:25 ` JeffyChen
[not found] ` <5A60AE41.2050101-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-22 1:18 ` Randy Li
2018-01-22 1:18 ` Randy Li
2018-01-22 1:18 ` Randy Li
[not found] ` <1f4b3c0d-1414-0012-a072-f4a11f432c21-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-22 2:15 ` JeffyChen
2018-01-22 2:15 ` JeffyChen
2018-01-22 2:15 ` JeffyChen
[not found] ` <5A654925.9020203-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-22 4:09 ` JeffyChen
2018-01-22 4:09 ` JeffyChen
2018-01-22 4:09 ` JeffyChen
[not found] ` <5A6563FA.8080602-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-24 9:51 ` Tomasz Figa
2018-01-24 9:51 ` Tomasz Figa
2018-01-24 9:51 ` Tomasz Figa
2018-01-25 9:42 ` Randy Li
2018-01-25 9:42 ` Randy Li
2018-01-25 9:42 ` Randy Li
[not found] ` <c05d4794-b76d-cfaa-d7ed-c44108117ee2-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-25 10:24 ` JeffyChen
2018-01-25 10:24 ` JeffyChen
2018-01-25 10:24 ` JeffyChen
[not found] ` <5A69B065.30501-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-02-23 10:36 ` JeffyChen
2018-02-23 10:36 ` JeffyChen
2018-02-23 10:36 ` JeffyChen
2018-01-18 11:52 ` [PATCH v4 09/13] iommu/rockchip: Use IOMMU device for dma mapping operations Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
[not found] ` <20180118115251.5542-10-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-18 12:35 ` Robin Murphy
2018-01-18 12:35 ` Robin Murphy
2018-01-18 12:35 ` Robin Murphy
2018-01-18 11:52 ` [PATCH v4 10/13] iommu/rockchip: Use OF_IOMMU to attach devices automatically Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
[not found] ` <20180118115251.5542-11-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-18 12:46 ` Robin Murphy
2018-01-18 12:46 ` Robin Murphy
2018-01-18 12:46 ` Robin Murphy
2018-01-18 11:52 ` [PATCH v4 12/13] iommu/rockchip: Add runtime PM support Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
[not found] ` <20180118115251.5542-13-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-19 4:01 ` Tomasz Figa
2018-01-19 4:01 ` Tomasz Figa
2018-01-19 4:01 ` Tomasz Figa
2018-01-18 11:52 ` [PATCH v4 03/13] iommu/rockchip: Request irqs in rk_iommu_probe() Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 11:52 ` [PATCH v4 05/13] iommu/rockchip: Use iopoll helpers to wait for hardware Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
[not found] ` <20180118115251.5542-6-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-18 13:09 ` Robin Murphy
2018-01-18 13:09 ` Robin Murphy
2018-01-18 13:09 ` Robin Murphy
[not found] ` <064794b9-98ae-221e-76bd-e11130514826-5wv7dgnIgG8@public.gmane.org>
2018-01-18 14:11 ` JeffyChen
2018-01-18 14:11 ` JeffyChen
2018-01-18 14:11 ` JeffyChen
2018-01-18 11:52 ` [PATCH v4 07/13] ARM: dts: rockchip: add clocks in vop iommu nodes Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
[not found] ` <20180118115251.5542-8-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-19 3:23 ` Tomasz Figa
2018-01-19 3:23 ` Tomasz Figa
2018-01-19 3:23 ` Tomasz Figa
[not found] ` <CAAFQd5ACbV6Q2Jwze=hoG=13jSJKkYyDDs2HzvvdSK-RGK+w2g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-19 4:55 ` JeffyChen
2018-01-19 4:55 ` JeffyChen
2018-01-19 4:55 ` JeffyChen
[not found] ` <5A617A5E.6070606-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-19 5:12 ` Tomasz Figa
2018-01-19 5:12 ` Tomasz Figa
2018-01-19 5:12 ` Tomasz Figa
2018-01-18 11:52 ` [PATCH v4 11/13] iommu/rockchip: Fix error handling in init Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
2018-01-18 12:47 ` Robin Murphy
2018-01-18 12:47 ` Robin Murphy
2018-01-18 11:52 ` [PATCH v4 13/13] iommu/rockchip: Support sharing IOMMU between masters Jeffy Chen
2018-01-18 11:52 ` Jeffy Chen
[not found] ` <20180118115251.5542-14-jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-18 12:49 ` Robin Murphy
2018-01-18 12:49 ` Robin Murphy
2018-01-18 12:49 ` Robin Murphy
2018-01-18 12:44 ` [PATCH v4 00/13] iommu/rockchip: Use OF_IOMMU Joerg Roedel
2018-01-18 12:44 ` Joerg Roedel
2018-01-18 14:07 ` JeffyChen
2018-01-18 14:07 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A60AE41.2050101@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jcliang@chromium.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tfiga@chromium.org \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.