From: JeffyChen <jeffy.chen@rock-chips.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: linux-kernel@vger.kernel.org, broonie@kernel.org,
linux-rtc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/4] rtc: at91sam9: Pass pdev->dev to regmap_init_mmio()
Date: Fri, 09 Mar 2018 09:51:27 +0800 [thread overview]
Message-ID: <5AA1E89F.2020500@rock-chips.com> (raw)
In-Reply-To: <20180308204941.GK20370@piout.net>
Hi Alexandre,
On 03/09/2018 04:49 AM, Alexandre Belloni wrote:
> On 08/03/2018 at 18:21:52 +0800, Jeffy Chen wrote:
>> Otherwise it would use "dummy*" to create regmap debugfs dir.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>> Changes in v3: None
>>
>> drivers/rtc/rtc-at91sam9.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
>> index 7418a763ce52..0d6a17a77841 100644
>> --- a/drivers/rtc/rtc-at91sam9.c
>> +++ b/drivers/rtc/rtc-at91sam9.c
>> @@ -402,7 +402,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
>> if (IS_ERR(gpbr))
>> return PTR_ERR(gpbr);
>>
>> - rtc->gpbr = regmap_init_mmio(NULL, gpbr,
>> + rtc->gpbr = regmap_init_mmio(&pdev->dev, gpbr,
>> &gpbr_regmap_config);
>
> This would be misleading as the gpbr is not directly related to the rtc.
ok, will fix that, thanks.
>
WARNING: multiple messages have this Message-ID (diff)
From: jeffy.chen@rock-chips.com (JeffyChen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] rtc: at91sam9: Pass pdev->dev to regmap_init_mmio()
Date: Fri, 09 Mar 2018 09:51:27 +0800 [thread overview]
Message-ID: <5AA1E89F.2020500@rock-chips.com> (raw)
In-Reply-To: <20180308204941.GK20370@piout.net>
Hi Alexandre,
On 03/09/2018 04:49 AM, Alexandre Belloni wrote:
> On 08/03/2018 at 18:21:52 +0800, Jeffy Chen wrote:
>> Otherwise it would use "dummy*" to create regmap debugfs dir.
>>
>> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
>> ---
>>
>> Changes in v3: None
>>
>> drivers/rtc/rtc-at91sam9.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c
>> index 7418a763ce52..0d6a17a77841 100644
>> --- a/drivers/rtc/rtc-at91sam9.c
>> +++ b/drivers/rtc/rtc-at91sam9.c
>> @@ -402,7 +402,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
>> if (IS_ERR(gpbr))
>> return PTR_ERR(gpbr);
>>
>> - rtc->gpbr = regmap_init_mmio(NULL, gpbr,
>> + rtc->gpbr = regmap_init_mmio(&pdev->dev, gpbr,
>> &gpbr_regmap_config);
>
> This would be misleading as the gpbr is not directly related to the rtc.
ok, will fix that, thanks.
>
next prev parent reply other threads:[~2018-03-09 1:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 10:21 [PATCH v3 0/4] Set name of regmap_config Jeffy Chen
2018-03-08 10:21 ` Jeffy Chen
2018-03-08 10:21 ` Jeffy Chen
2018-03-08 10:21 ` [PATCH v3 1/4] mfd: syscon: " Jeffy Chen
2018-03-08 10:21 ` [PATCH v3 2/4] rtc: at91sam9: Pass pdev->dev to regmap_init_mmio() Jeffy Chen
2018-03-08 10:21 ` Jeffy Chen
2018-03-08 20:49 ` Alexandre Belloni
2018-03-08 20:49 ` Alexandre Belloni
2018-03-09 1:51 ` JeffyChen [this message]
2018-03-09 1:51 ` JeffyChen
2018-03-08 10:21 ` [PATCH v3 3/4] clk: lpc32xx: Set name of regmap_config Jeffy Chen
2018-03-08 10:21 ` Jeffy Chen
2018-03-08 10:21 ` [PATCH v3 4/4] ARM: rockchip: " Jeffy Chen
2018-03-08 10:21 ` Jeffy Chen
2018-03-08 10:21 ` Jeffy Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5AA1E89F.2020500@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.