All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Pawel Laszczak <pawell@cadence.com>, devicetree@vger.kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	balbi@kernel.org, linux-kernel@vger.kernel.org,
	adouglas@cadence.com, jbergsagel@ti.com, nsekhar@ti.com,
	nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com,
	pjez@cadence.com, kurahul@cadence.com
Subject: [v1,1/2] dt-bindings: add binding for USBSS-DRD controller.
Date: Tue, 11 Dec 2018 12:16:27 +0200	[thread overview]
Message-ID: <5C0F8E7B.3030601@ti.com> (raw)

Pawel,

On 10/12/18 14:39, Pawel Laszczak wrote:
> This patch aim at documenting USB related dt-bindings for the
> Cadence USBSS-DRD controller.
> 
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
>  .../devicetree/bindings/usb/cdns3-usb.txt     | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> new file mode 100644
> index 000000000000..ae4a255f0b10
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> @@ -0,0 +1,31 @@
> +Binding for the Cadence USBSS-DRD controller
> +
> +Required properties:
> +  - reg: Physical base address and size of the controller's register areas.
> +	 Controller has 3 different regions:
> +	 region 1 - HOST registers area
> +	 region 2 - DEVICE registers area
> +	 region 3 - OTG/DRD registers area
> +  - compatible: Should contain: "cdns,usb3"
> +  - interrupts: Interrupt specifier. Refer to interrupt bindings.
> +		Driver supports only single interrupt line.
> +                This single interrupt is shared between Device,
> +		host and OTG/DRD part of driver.
> +
> +Optional propertiesi:

s/propertiesi/properties

> + - maximum-speed : valid arguments are "super-speed", "high-speed" and
> +                   "full-speed"; refer to usb/generic.txt
> + - dr_mode: Should be one of "host", "peripheral" or "otg".
> + - phys: reference to the USB PHY
> + - phy-names: name of the USB PHY, should be "cdns3,usbphy"
> +
> +
> +Example:
> +	usb@f3000000 {
> +		compatible = "cdns,usb3";
> +		interrupts = <USB_IRQ  7 IRQ_TYPE_LEVEL_HIGH>;
> +		reg = <0xf3000000 0x10000	//memory area for HOST registers
> +			0xf3010000 0x10000	//memory area for DEVICE registers
> +			0xf3020000 0x10000>;	//memory area for OTG/DRD registers

Use "/* <comment> */" instead.

> +	};
> +
> 

cheers,
-roger

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Pawel Laszczak <pawell@cadence.com>, devicetree@vger.kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	balbi@kernel.org, linux-kernel@vger.kernel.org,
	adouglas@cadence.com, jbergsagel@ti.com, nsekhar@ti.com,
	nm@ti.com, sureshp@cadence.com, peter.chen@nxp.com,
	pjez@cadence.com, kurahul@cadence.com
Subject: Re: [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller.
Date: Tue, 11 Dec 2018 12:16:27 +0200	[thread overview]
Message-ID: <5C0F8E7B.3030601@ti.com> (raw)
In-Reply-To: <1544445555-17325-2-git-send-email-pawell@cadence.com>

Pawel,

On 10/12/18 14:39, Pawel Laszczak wrote:
> This patch aim at documenting USB related dt-bindings for the
> Cadence USBSS-DRD controller.
> 
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
>  .../devicetree/bindings/usb/cdns3-usb.txt     | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> new file mode 100644
> index 000000000000..ae4a255f0b10
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> @@ -0,0 +1,31 @@
> +Binding for the Cadence USBSS-DRD controller
> +
> +Required properties:
> +  - reg: Physical base address and size of the controller's register areas.
> +	 Controller has 3 different regions:
> +	 region 1 - HOST registers area
> +	 region 2 - DEVICE registers area
> +	 region 3 - OTG/DRD registers area
> +  - compatible: Should contain: "cdns,usb3"
> +  - interrupts: Interrupt specifier. Refer to interrupt bindings.
> +		Driver supports only single interrupt line.
> +                This single interrupt is shared between Device,
> +		host and OTG/DRD part of driver.
> +
> +Optional propertiesi:

s/propertiesi/properties

> + - maximum-speed : valid arguments are "super-speed", "high-speed" and
> +                   "full-speed"; refer to usb/generic.txt
> + - dr_mode: Should be one of "host", "peripheral" or "otg".
> + - phys: reference to the USB PHY
> + - phy-names: name of the USB PHY, should be "cdns3,usbphy"
> +
> +
> +Example:
> +	usb@f3000000 {
> +		compatible = "cdns,usb3";
> +		interrupts = <USB_IRQ  7 IRQ_TYPE_LEVEL_HIGH>;
> +		reg = <0xf3000000 0x10000	//memory area for HOST registers
> +			0xf3010000 0x10000	//memory area for DEVICE registers
> +			0xf3020000 0x10000>;	//memory area for OTG/DRD registers

Use "/* <comment> */" instead.

> +	};
> +
> 

cheers,
-roger
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Pawel Laszczak <pawell@cadence.com>, <devicetree@vger.kernel.org>
Cc: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
	<balbi@kernel.org>, <linux-kernel@vger.kernel.org>,
	<adouglas@cadence.com>, <jbergsagel@ti.com>, <nsekhar@ti.com>,
	<nm@ti.com>, <sureshp@cadence.com>, <peter.chen@nxp.com>,
	<pjez@cadence.com>, <kurahul@cadence.com>
Subject: Re: [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller.
Date: Tue, 11 Dec 2018 12:16:27 +0200	[thread overview]
Message-ID: <5C0F8E7B.3030601@ti.com> (raw)
In-Reply-To: <1544445555-17325-2-git-send-email-pawell@cadence.com>

Pawel,

On 10/12/18 14:39, Pawel Laszczak wrote:
> This patch aim at documenting USB related dt-bindings for the
> Cadence USBSS-DRD controller.
> 
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
>  .../devicetree/bindings/usb/cdns3-usb.txt     | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/cdns3-usb.txt
> 
> diff --git a/Documentation/devicetree/bindings/usb/cdns3-usb.txt b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> new file mode 100644
> index 000000000000..ae4a255f0b10
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/cdns3-usb.txt
> @@ -0,0 +1,31 @@
> +Binding for the Cadence USBSS-DRD controller
> +
> +Required properties:
> +  - reg: Physical base address and size of the controller's register areas.
> +	 Controller has 3 different regions:
> +	 region 1 - HOST registers area
> +	 region 2 - DEVICE registers area
> +	 region 3 - OTG/DRD registers area
> +  - compatible: Should contain: "cdns,usb3"
> +  - interrupts: Interrupt specifier. Refer to interrupt bindings.
> +		Driver supports only single interrupt line.
> +                This single interrupt is shared between Device,
> +		host and OTG/DRD part of driver.
> +
> +Optional propertiesi:

s/propertiesi/properties

> + - maximum-speed : valid arguments are "super-speed", "high-speed" and
> +                   "full-speed"; refer to usb/generic.txt
> + - dr_mode: Should be one of "host", "peripheral" or "otg".
> + - phys: reference to the USB PHY
> + - phy-names: name of the USB PHY, should be "cdns3,usbphy"
> +
> +
> +Example:
> +	usb@f3000000 {
> +		compatible = "cdns,usb3";
> +		interrupts = <USB_IRQ  7 IRQ_TYPE_LEVEL_HIGH>;
> +		reg = <0xf3000000 0x10000	//memory area for HOST registers
> +			0xf3010000 0x10000	//memory area for DEVICE registers
> +			0xf3020000 0x10000>;	//memory area for OTG/DRD registers

Use "/* <comment> */" instead.

> +	};
> +
> 

cheers,
-roger
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

             reply	other threads:[~2018-12-11 10:16 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 10:16 Roger Quadros [this message]
2018-12-11 10:16 ` [PATCH v1 1/2] dt-bindings: add binding for USBSS-DRD controller Roger Quadros
2018-12-11 10:16 ` Roger Quadros
  -- strict thread matches above, loose matches on Subject: below --
2018-12-31  5:35 [v1,1/2] " Pawel Laszczak
2018-12-31  5:35 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-27 21:01 [v1,1/2] " Rob Herring
2018-12-27 21:01 ` [PATCH v1 1/2] " Rob Herring
2018-12-22 22:24 [v1,1/2] " Pawel Laszczak
2018-12-22 22:24 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-20 20:01 [v1,1/2] " Rob Herring
2018-12-20 20:01 ` [PATCH v1 1/2] " Rob Herring
2018-12-17 11:56 [v1,2/2] usb:cdns3 Add Cadence USB3 DRD Driver Felipe Balbi
2018-12-17 11:56 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-17 11:56 ` Felipe Balbi
2018-12-17 11:51 [v1,2/2] " Pawel Laszczak
2018-12-17 11:51 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-17 11:34 [v1,2/2] " Felipe Balbi
2018-12-17 11:34 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-17 11:34 ` Felipe Balbi
2018-12-17 11:25 [v1,2/2] " Pawel Laszczak
2018-12-17 11:25 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-17  5:46 [v1,2/2] " Pawel Laszczak
2018-12-17  5:46 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-16 13:01 [v1,2/2] " Pawel Laszczak
2018-12-16 13:01 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-14 22:56 [v1,2/2] " kbuild test robot
2018-12-14 22:56 ` [PATCH v1 2/2] " kbuild test robot
2018-12-14 22:56 ` kbuild test robot
2018-12-14  3:46 [v1,2/2] " Kishon Vijay Abraham I
2018-12-14  3:46 ` [PATCH v1 2/2] " Kishon Vijay Abraham I
2018-12-13  9:35 [v1,2/2] " Peter Chen
2018-12-13  9:35 ` [PATCH v1 2/2] " Peter Chen
2018-12-13  9:25 [v1,1/2] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-13  9:25 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-13  9:20 [v1,1/2] " Peter Chen
2018-12-13  9:20 ` [PATCH v1 1/2] " Peter Chen
2018-12-13  1:21 [v1,2/2] usb:cdns3 Add Cadence USB3 DRD Driver Peter Chen
2018-12-13  1:21 ` [PATCH v1 2/2] " Peter Chen
2018-12-12 15:53 [v1,2/2] " Bin Liu
2018-12-12 15:53 ` [PATCH v1 2/2] " Bin Liu
2018-12-12 15:53 ` Bin Liu
2018-12-12  9:24 [v1,2/2] " Peter Chen
2018-12-12  9:24 ` [PATCH v1 2/2] " Peter Chen
2018-12-12  8:34 [v1,2/2] " Felipe Balbi
2018-12-12  8:34 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12  8:34 ` Felipe Balbi
2018-12-12  7:38 [v1,2/2] " Peter Chen
2018-12-12  7:38 ` [PATCH v1 2/2] " Peter Chen
2018-12-12  6:55 [v1,2/2] " Felipe Balbi
2018-12-12  6:55 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12  6:52 [v1,2/2] " Felipe Balbi
2018-12-12  6:52 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12  6:52 ` Felipe Balbi
2018-12-12  2:04 [v1,2/2] " Peter Chen
2018-12-12  2:04 ` [PATCH v1 2/2] " Peter Chen
2018-12-11 19:04 [v1,2/2] " Pawel Laszczak
2018-12-11 19:04 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-11 19:04 ` Pawel Laszczak
2018-12-11 12:15 [v1,2/2] " Felipe Balbi
2018-12-11 12:15 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 12:15 ` Felipe Balbi
2018-12-11 12:14 [v1,2/2] " Felipe Balbi
2018-12-11 12:14 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 12:14 ` Felipe Balbi
2018-12-11 11:46 [v1,2/2] " Felipe Balbi
2018-12-11 11:46 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 10:01 [v1,2/2] " Pawel Laszczak
2018-12-11 10:01 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-11  9:39 [v1,2/2] " Roger Quadros
2018-12-11  9:39 ` [PATCH v1 2/2] " Roger Quadros
2018-12-11  9:39 ` Roger Quadros
2018-12-10 12:39 [v1,2/2] " Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-10 12:39 ` Pawel Laszczak
2018-12-10 12:39 [v1,1/2] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-10 12:39 ` Pawel Laszczak
2018-12-10 12:39 [PATCH v1 0/2] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2018-12-10 12:39 ` Pawel Laszczak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5C0F8E7B.3030601@ti.com \
    --to=rogerq@ti.com \
    --cc=adouglas@cadence.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jbergsagel@ti.com \
    --cc=kurahul@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    --cc=pawell@cadence.com \
    --cc=peter.chen@nxp.com \
    --cc=pjez@cadence.com \
    --cc=sureshp@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.