From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>,
Pawel Laszczak <pawell@cadence.com>,
devicetree@vger.kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, adouglas@cadence.com,
jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com,
sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com,
kurahul@cadence.com
Subject: [v1,2/2] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Tue, 11 Dec 2018 13:46:51 +0200 [thread overview]
Message-ID: <87k1kgmgk4.fsf@linux.intel.com> (raw)
Hi,
Roger Quadros <rogerq@ti.com> writes:
>> This patch introduce new Cadence USBSS DRD driver
>> to linux kernel.
>>
>> The Cadence USBSS DRD Driver is a highly
>> configurable IP Core which can be
>> instantiated as Dual-Role Device (DRD),
>> Peripheral Only and Host Only (XHCI)
>> configurations.
>>
>> The current driver has been validated with
>> FPGA burned. We have support for PCIe
>> bus, which is used on FPGA prototyping.
>>
>> The host side of USBSS-DRD controller is compliance
>> with XHCI specification, so it works with
>> standard XHCI linux driver.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>> drivers/usb/Kconfig | 2 +
>> drivers/usb/Makefile | 2 +
>> drivers/usb/cdns3/Kconfig | 44 +
>> drivers/usb/cdns3/Makefile | 16 +
>> drivers/usb/cdns3/cdns3-pci-wrap.c | 157 +++
>> drivers/usb/cdns3/core.c | 451 +++++++
>> drivers/usb/cdns3/core.h | 108 ++
>> drivers/usb/cdns3/debug.h | 346 ++++++
>> drivers/usb/cdns3/debugfs.c | 168 +++
>> drivers/usb/cdns3/drd.c | 315 +++++
>> drivers/usb/cdns3/drd.h | 129 ++
>> drivers/usb/cdns3/ep0.c | 864 +++++++++++++
>> drivers/usb/cdns3/gadget-export.h | 28 +
>> drivers/usb/cdns3/gadget.c | 1802 ++++++++++++++++++++++++++++
>> drivers/usb/cdns3/gadget.h | 1177 ++++++++++++++++++
>> drivers/usb/cdns3/host-export.h | 28 +
>> drivers/usb/cdns3/host.c | 74 ++
>> drivers/usb/cdns3/trace.c | 11 +
>> drivers/usb/cdns3/trace.h | 343 ++++++
>
> You went to the other extreme of combining everything (host/gadget/drd) together
> which again makes this very hard to review.
>
> I think what Felipe meant was to only combine the gadget driver code
> into one patch.
>
> The series could be split into 6 patches like so.
> -dt binding
> -pci glue
> -core driver
> -host driver
> -gadget driver
> -drd driver
no, no. This is fine. We _could_ split out PCI glue to its own patch,
but it's rather pointless seing as it's so small.
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>,
Pawel Laszczak <pawell@cadence.com>,
devicetree@vger.kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, adouglas@cadence.com,
jbergsagel@ti.com, nsekhar@ti.com, nm@ti.com,
sureshp@cadence.com, peter.chen@nxp.com, pjez@cadence.com,
kurahul@cadence.com
Subject: Re: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver
Date: Tue, 11 Dec 2018 13:46:51 +0200 [thread overview]
Message-ID: <87k1kgmgk4.fsf@linux.intel.com> (raw)
In-Reply-To: <5C0F85E4.10609@ti.com>
[-- Attachment #1: Type: text/plain, Size: 2190 bytes --]
Hi,
Roger Quadros <rogerq@ti.com> writes:
>> This patch introduce new Cadence USBSS DRD driver
>> to linux kernel.
>>
>> The Cadence USBSS DRD Driver is a highly
>> configurable IP Core which can be
>> instantiated as Dual-Role Device (DRD),
>> Peripheral Only and Host Only (XHCI)
>> configurations.
>>
>> The current driver has been validated with
>> FPGA burned. We have support for PCIe
>> bus, which is used on FPGA prototyping.
>>
>> The host side of USBSS-DRD controller is compliance
>> with XHCI specification, so it works with
>> standard XHCI linux driver.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>> drivers/usb/Kconfig | 2 +
>> drivers/usb/Makefile | 2 +
>> drivers/usb/cdns3/Kconfig | 44 +
>> drivers/usb/cdns3/Makefile | 16 +
>> drivers/usb/cdns3/cdns3-pci-wrap.c | 157 +++
>> drivers/usb/cdns3/core.c | 451 +++++++
>> drivers/usb/cdns3/core.h | 108 ++
>> drivers/usb/cdns3/debug.h | 346 ++++++
>> drivers/usb/cdns3/debugfs.c | 168 +++
>> drivers/usb/cdns3/drd.c | 315 +++++
>> drivers/usb/cdns3/drd.h | 129 ++
>> drivers/usb/cdns3/ep0.c | 864 +++++++++++++
>> drivers/usb/cdns3/gadget-export.h | 28 +
>> drivers/usb/cdns3/gadget.c | 1802 ++++++++++++++++++++++++++++
>> drivers/usb/cdns3/gadget.h | 1177 ++++++++++++++++++
>> drivers/usb/cdns3/host-export.h | 28 +
>> drivers/usb/cdns3/host.c | 74 ++
>> drivers/usb/cdns3/trace.c | 11 +
>> drivers/usb/cdns3/trace.h | 343 ++++++
>
> You went to the other extreme of combining everything (host/gadget/drd) together
> which again makes this very hard to review.
>
> I think what Felipe meant was to only combine the gadget driver code
> into one patch.
>
> The series could be split into 6 patches like so.
> -dt binding
> -pci glue
> -core driver
> -host driver
> -gadget driver
> -drd driver
no, no. This is fine. We _could_ split out PCI glue to its own patch,
but it's rather pointless seing as it's so small.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next reply other threads:[~2018-12-11 11:46 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 11:46 Felipe Balbi [this message]
2018-12-11 11:46 ` [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2018-12-31 5:35 [v1,1/2] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-31 5:35 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-27 21:01 [v1,1/2] " Rob Herring
2018-12-27 21:01 ` [PATCH v1 1/2] " Rob Herring
2018-12-22 22:24 [v1,1/2] " Pawel Laszczak
2018-12-22 22:24 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-20 20:01 [v1,1/2] " Rob Herring
2018-12-20 20:01 ` [PATCH v1 1/2] " Rob Herring
2018-12-17 11:56 [v1,2/2] usb:cdns3 Add Cadence USB3 DRD Driver Felipe Balbi
2018-12-17 11:56 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-17 11:56 ` Felipe Balbi
2018-12-17 11:51 [v1,2/2] " Pawel Laszczak
2018-12-17 11:51 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-17 11:34 [v1,2/2] " Felipe Balbi
2018-12-17 11:34 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-17 11:34 ` Felipe Balbi
2018-12-17 11:25 [v1,2/2] " Pawel Laszczak
2018-12-17 11:25 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-17 5:46 [v1,2/2] " Pawel Laszczak
2018-12-17 5:46 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-16 13:01 [v1,2/2] " Pawel Laszczak
2018-12-16 13:01 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-14 22:56 [v1,2/2] " kbuild test robot
2018-12-14 22:56 ` [PATCH v1 2/2] " kbuild test robot
2018-12-14 22:56 ` kbuild test robot
2018-12-14 3:46 [v1,2/2] " Kishon Vijay Abraham I
2018-12-14 3:46 ` [PATCH v1 2/2] " Kishon Vijay Abraham I
2018-12-13 9:35 [v1,2/2] " Peter Chen
2018-12-13 9:35 ` [PATCH v1 2/2] " Peter Chen
2018-12-13 9:25 [v1,1/2] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-13 9:25 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-13 9:20 [v1,1/2] " Peter Chen
2018-12-13 9:20 ` [PATCH v1 1/2] " Peter Chen
2018-12-13 1:21 [v1,2/2] usb:cdns3 Add Cadence USB3 DRD Driver Peter Chen
2018-12-13 1:21 ` [PATCH v1 2/2] " Peter Chen
2018-12-12 15:53 [v1,2/2] " Bin Liu
2018-12-12 15:53 ` [PATCH v1 2/2] " Bin Liu
2018-12-12 15:53 ` Bin Liu
2018-12-12 9:24 [v1,2/2] " Peter Chen
2018-12-12 9:24 ` [PATCH v1 2/2] " Peter Chen
2018-12-12 8:34 [v1,2/2] " Felipe Balbi
2018-12-12 8:34 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12 8:34 ` Felipe Balbi
2018-12-12 7:38 [v1,2/2] " Peter Chen
2018-12-12 7:38 ` [PATCH v1 2/2] " Peter Chen
2018-12-12 6:55 [v1,2/2] " Felipe Balbi
2018-12-12 6:55 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12 6:52 [v1,2/2] " Felipe Balbi
2018-12-12 6:52 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-12 6:52 ` Felipe Balbi
2018-12-12 2:04 [v1,2/2] " Peter Chen
2018-12-12 2:04 ` [PATCH v1 2/2] " Peter Chen
2018-12-11 19:04 [v1,2/2] " Pawel Laszczak
2018-12-11 19:04 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-11 19:04 ` Pawel Laszczak
2018-12-11 12:15 [v1,2/2] " Felipe Balbi
2018-12-11 12:15 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 12:15 ` Felipe Balbi
2018-12-11 12:14 [v1,2/2] " Felipe Balbi
2018-12-11 12:14 ` [PATCH v1 2/2] " Felipe Balbi
2018-12-11 12:14 ` Felipe Balbi
2018-12-11 10:16 [v1,1/2] dt-bindings: add binding for USBSS-DRD controller Roger Quadros
2018-12-11 10:16 ` [PATCH v1 1/2] " Roger Quadros
2018-12-11 10:16 ` Roger Quadros
2018-12-11 10:01 [v1,2/2] usb:cdns3 Add Cadence USB3 DRD Driver Pawel Laszczak
2018-12-11 10:01 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-11 9:39 [v1,2/2] " Roger Quadros
2018-12-11 9:39 ` [PATCH v1 2/2] " Roger Quadros
2018-12-11 9:39 ` Roger Quadros
2018-12-10 12:39 [v1,2/2] " Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 2/2] " Pawel Laszczak
2018-12-10 12:39 ` Pawel Laszczak
2018-12-10 12:39 [v1,1/2] dt-bindings: add binding for USBSS-DRD controller Pawel Laszczak
2018-12-10 12:39 ` [PATCH v1 1/2] " Pawel Laszczak
2018-12-10 12:39 ` Pawel Laszczak
2018-12-10 12:39 [PATCH v1 0/2] Introduced new Cadence USBSS DRD Driver Pawel Laszczak
2018-12-10 12:39 ` Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1kgmgk4.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=adouglas@cadence.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jbergsagel@ti.com \
--cc=kurahul@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=pawell@cadence.com \
--cc=peter.chen@nxp.com \
--cc=pjez@cadence.com \
--cc=rogerq@ti.com \
--cc=sureshp@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.