All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Stijn Tintel <stijn@linux-ipv6.be>, khilman@baylibre.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: meson-gxbb-odroidc2: enable I2C bus B
Date: Sun, 10 Feb 2019 11:56:14 +0100	[thread overview]
Message-ID: <5C60034E.5030706@baylibre.com> (raw)
In-Reply-To: <20190209155005.18458-1-stijn@linux-ipv6.be>

Hi,

Le 09/02/2019 16:50, Stijn Tintel a écrit :
> The ODROID C2 has 2 I2C buses, so enable both of them.

Thanks for the change, but this I2C bus is on the 40-pin header,
until we have a way to add support for HATs/CAPEs/<whatever hooks on the header>
upstream, we prefer not enabling any functions on these pins by default.

You can, if you want add support for most functions, but "disabled" with a
proper description of pins used by these functions.

You can also maintain a set of overlay files like it's done for the
libretech-cc boards https://github.com/libre-computer-project/libretech-overlays/tree/for-4.13.y/overlays
and use them with the Armbian mainline based latest image for example.

Neil

> 
> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 1cc9dc68ef00..ee666471a580 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -180,6 +180,12 @@
>  	pinctrl-names = "default";
>  };
>  
> +&i2c_B {
> +	status = "okay";
> +	pinctrl-0 = <&i2c_b_pins>;
> +	pinctrl-names = "default";
> +};
> +
>  &ir {
>  	status = "okay";
>  	pinctrl-0 = <&remote_input_ao_pins>;
> 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Stijn Tintel <stijn@linux-ipv6.be>, khilman@baylibre.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: meson-gxbb-odroidc2: enable I2C bus B
Date: Sun, 10 Feb 2019 11:56:14 +0100	[thread overview]
Message-ID: <5C60034E.5030706@baylibre.com> (raw)
In-Reply-To: <20190209155005.18458-1-stijn@linux-ipv6.be>

Hi,

Le 09/02/2019 16:50, Stijn Tintel a écrit :
> The ODROID C2 has 2 I2C buses, so enable both of them.

Thanks for the change, but this I2C bus is on the 40-pin header,
until we have a way to add support for HATs/CAPEs/<whatever hooks on the header>
upstream, we prefer not enabling any functions on these pins by default.

You can, if you want add support for most functions, but "disabled" with a
proper description of pins used by these functions.

You can also maintain a set of overlay files like it's done for the
libretech-cc boards https://github.com/libre-computer-project/libretech-overlays/tree/for-4.13.y/overlays
and use them with the Armbian mainline based latest image for example.

Neil

> 
> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 1cc9dc68ef00..ee666471a580 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -180,6 +180,12 @@
>  	pinctrl-names = "default";
>  };
>  
> +&i2c_B {
> +	status = "okay";
> +	pinctrl-0 = <&i2c_b_pins>;
> +	pinctrl-names = "default";
> +};
> +
>  &ir {
>  	status = "okay";
>  	pinctrl-0 = <&remote_input_ao_pins>;
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Stijn Tintel <stijn@linux-ipv6.be>, khilman@baylibre.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: meson-gxbb-odroidc2: enable I2C bus B
Date: Sun, 10 Feb 2019 11:56:14 +0100	[thread overview]
Message-ID: <5C60034E.5030706@baylibre.com> (raw)
In-Reply-To: <20190209155005.18458-1-stijn@linux-ipv6.be>

Hi,

Le 09/02/2019 16:50, Stijn Tintel a écrit :
> The ODROID C2 has 2 I2C buses, so enable both of them.

Thanks for the change, but this I2C bus is on the 40-pin header,
until we have a way to add support for HATs/CAPEs/<whatever hooks on the header>
upstream, we prefer not enabling any functions on these pins by default.

You can, if you want add support for most functions, but "disabled" with a
proper description of pins used by these functions.

You can also maintain a set of overlay files like it's done for the
libretech-cc boards https://github.com/libre-computer-project/libretech-overlays/tree/for-4.13.y/overlays
and use them with the Armbian mainline based latest image for example.

Neil

> 
> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 1cc9dc68ef00..ee666471a580 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -180,6 +180,12 @@
>  	pinctrl-names = "default";
>  };
>  
> +&i2c_B {
> +	status = "okay";
> +	pinctrl-0 = <&i2c_b_pins>;
> +	pinctrl-names = "default";
> +};
> +
>  &ir {
>  	status = "okay";
>  	pinctrl-0 = <&remote_input_ao_pins>;
> 

  reply	other threads:[~2019-02-10 10:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-09 15:50 [PATCH] arm64: dts: meson-gxbb-odroidc2: enable I2C bus B Stijn Tintel
2019-02-09 15:50 ` Stijn Tintel
2019-02-09 15:50 ` Stijn Tintel
2019-02-09 15:50 ` Stijn Tintel
2019-02-10 10:56 ` Neil Armstrong [this message]
2019-02-10 10:56   ` Neil Armstrong
2019-02-10 10:56   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5C60034E.5030706@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stijn@linux-ipv6.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.