* [PATCH] arm64: dts: meson-gxbb-odroidc2: enable I2C bus B
@ 2019-02-09 15:50 ` Stijn Tintel
0 siblings, 0 replies; 7+ messages in thread
From: Stijn Tintel @ 2019-02-09 15:50 UTC (permalink / raw)
To: khilman; +Cc: devicetree, linux-arm-kernel, linux-amlogic, linux-kernel
The ODROID C2 has 2 I2C buses, so enable both of them.
Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 1cc9dc68ef00..ee666471a580 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -180,6 +180,12 @@
pinctrl-names = "default";
};
+&i2c_B {
+ status = "okay";
+ pinctrl-0 = <&i2c_b_pins>;
+ pinctrl-names = "default";
+};
+
&ir {
status = "okay";
pinctrl-0 = <&remote_input_ao_pins>;
--
2.19.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] arm64: dts: meson-gxbb-odroidc2: enable I2C bus B
@ 2019-02-09 15:50 ` Stijn Tintel
0 siblings, 0 replies; 7+ messages in thread
From: Stijn Tintel @ 2019-02-09 15:50 UTC (permalink / raw)
To: khilman; +Cc: devicetree, linux-kernel, linux-arm-kernel, linux-amlogic
The ODROID C2 has 2 I2C buses, so enable both of them.
Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 1cc9dc68ef00..ee666471a580 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -180,6 +180,12 @@
pinctrl-names = "default";
};
+&i2c_B {
+ status = "okay";
+ pinctrl-0 = <&i2c_b_pins>;
+ pinctrl-names = "default";
+};
+
&ir {
status = "okay";
pinctrl-0 = <&remote_input_ao_pins>;
--
2.19.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] arm64: dts: meson-gxbb-odroidc2: enable I2C bus B
@ 2019-02-09 15:50 ` Stijn Tintel
0 siblings, 0 replies; 7+ messages in thread
From: Stijn Tintel @ 2019-02-09 15:50 UTC (permalink / raw)
To: khilman; +Cc: devicetree, linux-kernel, linux-arm-kernel, linux-amlogic
The ODROID C2 has 2 I2C buses, so enable both of them.
Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
---
arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
index 1cc9dc68ef00..ee666471a580 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
@@ -180,6 +180,12 @@
pinctrl-names = "default";
};
+&i2c_B {
+ status = "okay";
+ pinctrl-0 = <&i2c_b_pins>;
+ pinctrl-names = "default";
+};
+
&ir {
status = "okay";
pinctrl-0 = <&remote_input_ao_pins>;
--
2.19.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: meson-gxbb-odroidc2: enable I2C bus B
2019-02-09 15:50 ` Stijn Tintel
(?)
@ 2019-02-10 10:56 ` Neil Armstrong
-1 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2019-02-10 10:56 UTC (permalink / raw)
To: Stijn Tintel, khilman
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-amlogic
Hi,
Le 09/02/2019 16:50, Stijn Tintel a écrit :
> The ODROID C2 has 2 I2C buses, so enable both of them.
Thanks for the change, but this I2C bus is on the 40-pin header,
until we have a way to add support for HATs/CAPEs/<whatever hooks on the header>
upstream, we prefer not enabling any functions on these pins by default.
You can, if you want add support for most functions, but "disabled" with a
proper description of pins used by these functions.
You can also maintain a set of overlay files like it's done for the
libretech-cc boards https://github.com/libre-computer-project/libretech-overlays/tree/for-4.13.y/overlays
and use them with the Armbian mainline based latest image for example.
Neil
>
> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 1cc9dc68ef00..ee666471a580 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -180,6 +180,12 @@
> pinctrl-names = "default";
> };
>
> +&i2c_B {
> + status = "okay";
> + pinctrl-0 = <&i2c_b_pins>;
> + pinctrl-names = "default";
> +};
> +
> &ir {
> status = "okay";
> pinctrl-0 = <&remote_input_ao_pins>;
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: meson-gxbb-odroidc2: enable I2C bus B
@ 2019-02-10 10:56 ` Neil Armstrong
0 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2019-02-10 10:56 UTC (permalink / raw)
To: Stijn Tintel, khilman
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-amlogic
Hi,
Le 09/02/2019 16:50, Stijn Tintel a écrit :
> The ODROID C2 has 2 I2C buses, so enable both of them.
Thanks for the change, but this I2C bus is on the 40-pin header,
until we have a way to add support for HATs/CAPEs/<whatever hooks on the header>
upstream, we prefer not enabling any functions on these pins by default.
You can, if you want add support for most functions, but "disabled" with a
proper description of pins used by these functions.
You can also maintain a set of overlay files like it's done for the
libretech-cc boards https://github.com/libre-computer-project/libretech-overlays/tree/for-4.13.y/overlays
and use them with the Armbian mainline based latest image for example.
Neil
>
> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 1cc9dc68ef00..ee666471a580 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -180,6 +180,12 @@
> pinctrl-names = "default";
> };
>
> +&i2c_B {
> + status = "okay";
> + pinctrl-0 = <&i2c_b_pins>;
> + pinctrl-names = "default";
> +};
> +
> &ir {
> status = "okay";
> pinctrl-0 = <&remote_input_ao_pins>;
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] arm64: dts: meson-gxbb-odroidc2: enable I2C bus B
@ 2019-02-10 10:56 ` Neil Armstrong
0 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2019-02-10 10:56 UTC (permalink / raw)
To: Stijn Tintel, khilman
Cc: devicetree, linux-kernel, linux-arm-kernel, linux-amlogic
Hi,
Le 09/02/2019 16:50, Stijn Tintel a écrit :
> The ODROID C2 has 2 I2C buses, so enable both of them.
Thanks for the change, but this I2C bus is on the 40-pin header,
until we have a way to add support for HATs/CAPEs/<whatever hooks on the header>
upstream, we prefer not enabling any functions on these pins by default.
You can, if you want add support for most functions, but "disabled" with a
proper description of pins used by these functions.
You can also maintain a set of overlay files like it's done for the
libretech-cc boards https://github.com/libre-computer-project/libretech-overlays/tree/for-4.13.y/overlays
and use them with the Armbian mainline based latest image for example.
Neil
>
> Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> index 1cc9dc68ef00..ee666471a580 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts
> @@ -180,6 +180,12 @@
> pinctrl-names = "default";
> };
>
> +&i2c_B {
> + status = "okay";
> + pinctrl-0 = <&i2c_b_pins>;
> + pinctrl-names = "default";
> +};
> +
> &ir {
> status = "okay";
> pinctrl-0 = <&remote_input_ao_pins>;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread