Re: [PATCH 04/11] arm64: dts: meson-g12a-u200: add regulators

From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, Jerome Brunet <jbrunet@baylibre.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 04/11] arm64: dts: meson-g12a-u200: add regulators
Date: Sat, 16 Mar 2019 15:40:53 +0100	[thread overview]
Message-ID: <5C8D0AF5.5040101@baylibre.com> (raw)
In-Reply-To: <CAFBinCCiV21kB38SXqVYMmQ5YkK2MxXKhiTJrVP3jOCLDtuBBg@mail.gmail.com>

HI,

Le 15/03/2019 23:01, Martin Blumenstingl a écrit :
> Hi Neil,
> 
> On Mon, Mar 11, 2019 at 10:57 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> From: Jerome Brunet <jbrunet@baylibre.com>
>>
>> Add system regulators for the S905D2 U200 reference design.
> I find the hint in the meson-g12a-sei510 regulators patch very good:
>   Still missing
>   * VDD_EE (0.8V - PWM controlled)
>   * VDD_CPU(PWM controlled)
>   * VDDQ1_5

I will add the same comment here

> 
> VDD_EE and VDD_CPU are *probably* going to be very similar across all
> boards (Meson8b uses two slightly different PWM regulators on all
> boards supported by mainline, but the basic concept is always the
> same)

Not necessarily, it can change, it used to change across GXBB boards, but
seems to be more coherent across GXL/GXM/G12A ref designs and derivative
boards, but it can still change if the HW designer decides to be creative !

> I'm not sure if VDDQ1_5 is specific to the SEI510 board though.

I think VDDQ1_5 is specific to SEI510, will check on the schematics

> 
>> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  .../boot/dts/amlogic/meson-g12a-u200.dts      | 79 +++++++++++++++++++
>>  1 file changed, 79 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
>> index f2afd0bf3e28..17696f356ff2 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts
>> @@ -14,13 +14,92 @@
>>         aliases {
>>                 serial0 = &uart_AO;
>>         };
>> +
>>         chosen {
>>                 stdout-path = "serial0:115200n8";
>>         };
>> +
>>         memory@0 {
>>                 device_type = "memory";
>>                 reg = <0x0 0x0 0x0 0x40000000>;
>>         };
> there are two unrelated whitespace changes above.
> please clean them up if you have to re-send this for whatever reason

Yep, will cleanup

> 
> 
> Regards
> Martin
> 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic