From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 07/11] arm64: dts: meson-g12a-x96-max: Enable BT Module
Date: Sat, 16 Mar 2019 15:42:29 +0100 [thread overview]
Message-ID: <5C8D0B55.90200@baylibre.com> (raw)
In-Reply-To: <CAFBinCCbu54hvATKpQ+DxZ6g-FCJ_7Gty2v3HMWJWNFDbwwKwQ@mail.gmail.com>
Le 15/03/2019 22:48, Martin Blumenstingl a écrit :
> Hi Neil,
>
> On Mon, Mar 11, 2019 at 10:57 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Enable the Bluetooth Module on the X96 Max Set-Top-Box.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> I didn't have time to test this yet but it looks sane to me, so:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> index 21e5de48613e..61606601fb4f 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> @@ -88,6 +88,18 @@
>> };
>> };
>>
>> +&uart_A {
>> + status = "okay";
>> + pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
>> + pinctrl-names = "default";
>> + uart-has-rtscts;
>> +
>> + bluetooth {
>> + compatible = "brcm,bcm43438-bt";
>> + shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
> you could add:
> host-wakeup-gpios = <&gpio GPIOX_19 GPIO_ACTIVE_HIGH>;
> (at least according to the output of /sys/kernel/debug/gpio and the
> .dtb on my X96 Max)
Will add !
>
>
> Regards
> Martin
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 07/11] arm64: dts: meson-g12a-x96-max: Enable BT Module
Date: Sat, 16 Mar 2019 15:42:29 +0100 [thread overview]
Message-ID: <5C8D0B55.90200@baylibre.com> (raw)
In-Reply-To: <CAFBinCCbu54hvATKpQ+DxZ6g-FCJ_7Gty2v3HMWJWNFDbwwKwQ@mail.gmail.com>
Le 15/03/2019 22:48, Martin Blumenstingl a écrit :
> Hi Neil,
>
> On Mon, Mar 11, 2019 at 10:57 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Enable the Bluetooth Module on the X96 Max Set-Top-Box.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> I didn't have time to test this yet but it looks sane to me, so:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> index 21e5de48613e..61606601fb4f 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> @@ -88,6 +88,18 @@
>> };
>> };
>>
>> +&uart_A {
>> + status = "okay";
>> + pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
>> + pinctrl-names = "default";
>> + uart-has-rtscts;
>> +
>> + bluetooth {
>> + compatible = "brcm,bcm43438-bt";
>> + shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
> you could add:
> host-wakeup-gpios = <&gpio GPIOX_19 GPIO_ACTIVE_HIGH>;
> (at least according to the output of /sys/kernel/debug/gpio and the
> .dtb on my X96 Max)
Will add !
>
>
> Regards
> Martin
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <narmstrong@baylibre.com>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, linux-amlogic@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/11] arm64: dts: meson-g12a-x96-max: Enable BT Module
Date: Sat, 16 Mar 2019 15:42:29 +0100 [thread overview]
Message-ID: <5C8D0B55.90200@baylibre.com> (raw)
In-Reply-To: <CAFBinCCbu54hvATKpQ+DxZ6g-FCJ_7Gty2v3HMWJWNFDbwwKwQ@mail.gmail.com>
Le 15/03/2019 22:48, Martin Blumenstingl a écrit :
> Hi Neil,
>
> On Mon, Mar 11, 2019 at 10:57 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Enable the Bluetooth Module on the X96 Max Set-Top-Box.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> I didn't have time to test this yet but it looks sane to me, so:
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> index 21e5de48613e..61606601fb4f 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-x96-max.dts
>> @@ -88,6 +88,18 @@
>> };
>> };
>>
>> +&uart_A {
>> + status = "okay";
>> + pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>;
>> + pinctrl-names = "default";
>> + uart-has-rtscts;
>> +
>> + bluetooth {
>> + compatible = "brcm,bcm43438-bt";
>> + shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
> you could add:
> host-wakeup-gpios = <&gpio GPIOX_19 GPIO_ACTIVE_HIGH>;
> (at least according to the output of /sys/kernel/debug/gpio and the
> .dtb on my X96 Max)
Will add !
>
>
> Regards
> Martin
>
next prev parent reply other threads:[~2019-03-16 14:42 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 9:56 [PATCH 00/11] arm64: dts: g12a: Add boards peripherals Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 01/11] arm64: dts: meson-g12a-u200: add uart_AO pinctrl Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 02/11] arm64: dts: meson-g12a-sei510: " Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 03/11] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-15 21:42 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 04/11] arm64: dts: meson-g12a-u200: add regulators Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-15 22:01 ` Martin Blumenstingl
2019-03-15 22:01 ` Martin Blumenstingl
2019-03-15 22:01 ` Martin Blumenstingl
2019-03-16 14:40 ` Neil Armstrong
2019-03-16 14:40 ` Neil Armstrong
2019-03-16 14:40 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 05/11] arm64: dts: meson-g12a-sei510: " Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 06/11] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-15 22:05 ` Martin Blumenstingl
2019-03-15 22:05 ` Martin Blumenstingl
2019-03-15 22:05 ` Martin Blumenstingl
2019-03-16 14:41 ` Neil Armstrong
2019-03-16 14:41 ` Neil Armstrong
2019-03-16 14:41 ` Neil Armstrong
2019-03-16 14:41 ` Neil Armstrong
2019-03-16 14:41 ` Neil Armstrong
2019-03-16 14:41 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 07/11] arm64: dts: meson-g12a-x96-max: Enable BT Module Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-15 21:48 ` Martin Blumenstingl
2019-03-15 21:48 ` Martin Blumenstingl
2019-03-15 21:48 ` Martin Blumenstingl
2019-03-16 14:42 ` Neil Armstrong [this message]
2019-03-16 14:42 ` Neil Armstrong
2019-03-16 14:42 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 08/11] arm64: dts: meson-g12a-sei510: Add ADC Key and BT support Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 09/11] arm64: dts: meson-g12a-sei510: Enable USB Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` [PATCH 10/11] arm64: dts: meson-g12a-u200: " Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-15 21:52 ` Martin Blumenstingl
2019-03-15 21:52 ` Martin Blumenstingl
2019-03-15 21:52 ` Martin Blumenstingl
2019-03-11 9:56 ` [PATCH 11/11] arm64: dts: meson-g12a-x96-max: " Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-11 9:56 ` Neil Armstrong
2019-03-15 21:50 ` Martin Blumenstingl
2019-03-15 21:50 ` Martin Blumenstingl
2019-03-15 21:50 ` Martin Blumenstingl
2019-03-16 14:46 ` Neil Armstrong
2019-03-16 14:46 ` Neil Armstrong
2019-03-16 14:46 ` Neil Armstrong
2019-03-16 22:07 ` Martin Blumenstingl
2019-03-16 22:07 ` Martin Blumenstingl
2019-03-16 22:07 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C8D0B55.90200@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.