All of lore.kernel.org
 help / color / mirror / Atom feed
From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Cc: "David Airlie" <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Colin King" <colin.king@canonical.com>,
	"Evan Quan" <evan.quan@amd.com>, "Rex Zhu" <rex.zhu@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes
Date: Thu, 01 Aug 2019 12:20:08 +0200	[thread overview]
Message-ID: <5D42BCD8.2050708@bfs.de> (raw)
In-Reply-To: <20190801083941.4230-1-colin.king@canonical.com>



Am 01.08.2019 10:39, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There are a few spelling mistakes "unknow" -> "unknown" and
> "enabeld" -> "enabled". Fix these.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index 13b2c8a60232..d029a99e600e 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -39,7 +39,7 @@ static const char* __smu_message_names[] = {
>  const char *smu_get_message_name(struct smu_context *smu, enum smu_message_type type)
>  {
>  	if (type < 0 || type > SMU_MSG_MAX_COUNT)
> -		return "unknow smu message";
> +		return "unknown smu message";
>  	return __smu_message_names[type];
>  }
>  
> @@ -52,7 +52,7 @@ static const char* __smu_feature_names[] = {
>  const char *smu_get_feature_name(struct smu_context *smu, enum smu_feature_mask feature)
>  {
>  	if (feature < 0 || feature > SMU_FEATURE_COUNT)
> -		return "unknow smu feature";
> +		return "unknown smu feature";
>  	return __smu_feature_names[feature];
>  }
>  
> @@ -79,7 +79,7 @@ size_t smu_sys_get_pp_feature_mask(struct smu_context *smu, char *buf)
>  			       count++,
>  			       smu_get_feature_name(smu, i),
>  			       feature_index,
> -			       !!smu_feature_is_enabled(smu, i) ? "enabeld" : "disabled");
> +			       !!smu_feature_is_enabled(smu, i) ? "enabled" : "disabled");

i am wondering,
is that !! really needed in front of smu_feature_is_enabled ?

re,
 wh

>  	}
>  
>  failed:
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Cc: "David Airlie" <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Colin King" <colin.king@canonical.com>,
	"Evan Quan" <evan.quan@amd.com>, "Rex Zhu" <rex.zhu@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes
Date: Thu, 01 Aug 2019 10:20:08 +0000	[thread overview]
Message-ID: <5D42BCD8.2050708@bfs.de> (raw)
In-Reply-To: <20190801083941.4230-1-colin.king@canonical.com>



Am 01.08.2019 10:39, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There are a few spelling mistakes "unknow" -> "unknown" and
> "enabeld" -> "enabled". Fix these.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index 13b2c8a60232..d029a99e600e 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -39,7 +39,7 @@ static const char* __smu_message_names[] = {
>  const char *smu_get_message_name(struct smu_context *smu, enum smu_message_type type)
>  {
>  	if (type < 0 || type > SMU_MSG_MAX_COUNT)
> -		return "unknow smu message";
> +		return "unknown smu message";
>  	return __smu_message_names[type];
>  }
>  
> @@ -52,7 +52,7 @@ static const char* __smu_feature_names[] = {
>  const char *smu_get_feature_name(struct smu_context *smu, enum smu_feature_mask feature)
>  {
>  	if (feature < 0 || feature > SMU_FEATURE_COUNT)
> -		return "unknow smu feature";
> +		return "unknown smu feature";
>  	return __smu_feature_names[feature];
>  }
>  
> @@ -79,7 +79,7 @@ size_t smu_sys_get_pp_feature_mask(struct smu_context *smu, char *buf)
>  			       count++,
>  			       smu_get_feature_name(smu, i),
>  			       feature_index,
> -			       !!smu_feature_is_enabled(smu, i) ? "enabeld" : "disabled");
> +			       !!smu_feature_is_enabled(smu, i) ? "enabled" : "disabled");

i am wondering,
is that !! really needed in front of smu_feature_is_enabled ?

re,
 wh

>  	}
>  
>  failed:

WARNING: multiple messages have this Message-ID (diff)
From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Cc: "Colin King" <colin.king@canonical.com>,
	"Rex Zhu" <rex.zhu@amd.com>, "Evan Quan" <evan.quan@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Zhou" <David1.Zhou@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes
Date: Thu, 01 Aug 2019 12:20:08 +0200	[thread overview]
Message-ID: <5D42BCD8.2050708@bfs.de> (raw)
In-Reply-To: <20190801083941.4230-1-colin.king@canonical.com>



Am 01.08.2019 10:39, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
> 
> There are a few spelling mistakes "unknow" -> "unknown" and
> "enabeld" -> "enabled". Fix these.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index 13b2c8a60232..d029a99e600e 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -39,7 +39,7 @@ static const char* __smu_message_names[] = {
>  const char *smu_get_message_name(struct smu_context *smu, enum smu_message_type type)
>  {
>  	if (type < 0 || type > SMU_MSG_MAX_COUNT)
> -		return "unknow smu message";
> +		return "unknown smu message";
>  	return __smu_message_names[type];
>  }
>  
> @@ -52,7 +52,7 @@ static const char* __smu_feature_names[] = {
>  const char *smu_get_feature_name(struct smu_context *smu, enum smu_feature_mask feature)
>  {
>  	if (feature < 0 || feature > SMU_FEATURE_COUNT)
> -		return "unknow smu feature";
> +		return "unknown smu feature";
>  	return __smu_feature_names[feature];
>  }
>  
> @@ -79,7 +79,7 @@ size_t smu_sys_get_pp_feature_mask(struct smu_context *smu, char *buf)
>  			       count++,
>  			       smu_get_feature_name(smu, i),
>  			       feature_index,
> -			       !!smu_feature_is_enabled(smu, i) ? "enabeld" : "disabled");
> +			       !!smu_feature_is_enabled(smu, i) ? "enabled" : "disabled");

i am wondering,
is that !! really needed in front of smu_feature_is_enabled ?

re,
 wh

>  	}
>  
>  failed:

  reply	other threads:[~2019-08-01 10:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-01  8:39 [PATCH][drm-next] drm/amd/powerplay: fix a few spelling mistakes Colin King
2019-08-01  8:39 ` Colin King
2019-08-01 10:20 ` walter harms [this message]
2019-08-01 10:20   ` walter harms
2019-08-01 10:20   ` walter harms
2019-08-01 19:02 ` Alex Deucher
2019-08-01 19:02   ` Alex Deucher
2019-08-01 19:16   ` Joe Perches
2019-08-01 19:16     ` Joe Perches
     [not found] ` <20190801083941.4230-1-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2019-08-02  1:44   ` Wang, Kevin(Yang)
  -- strict thread matches above, loose matches on Subject: below --
2019-08-01 11:15 [PATCH][drm-next] drm/amd/powerplay: fix off-by-one upper bounds limit checks Colin King
2019-08-01 11:15 ` Colin King
2019-08-01 18:53 ` Alex Deucher
2019-08-01 18:53   ` Alex Deucher
2019-08-02  1:45   ` Wang, Kevin(Yang)
2017-09-28 10:35 [PATCH][drm-next] drm/amd/powerplay: fix spelling mistake: "dividable" -> "divisible" Colin King
2017-09-28 10:35 ` Colin King
2017-09-28 10:35 ` Colin King
2017-09-28 19:46 ` Alex Deucher
2017-09-28 19:46   ` Alex Deucher
2017-09-28 19:46   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5D42BCD8.2050708@bfs.de \
    --to=wharms@bfs.de \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=colin.king@canonical.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=evan.quan@amd.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rex.zhu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.