All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v2 4/4] phy: phy-can-transceiver: Drop unused include
Date: Mon, 27 Apr 2026 11:05:21 +0000	[thread overview]
Message-ID: <5b40e1ab-29a5-40f2-a4e6-560f3057633c@solid-run.com> (raw)
In-Reply-To: <20260317203001.2108568-5-andriy.shevchenko@linux.intel.com>

Am 17.03.26 um 21:27 schrieb Andy Shevchenko:
> This file does not use the symbols from the legacy
> <linux/gpio.h> header, so let's drop it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/phy/phy-can-transceiver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c
> index 21b0406d1a09..8e250039c183 100644
> --- a/drivers/phy/phy-can-transceiver.c
> +++ b/drivers/phy/phy-can-transceiver.c
> @@ -5,12 +5,11 @@
>   * Copyright (C) 2021 Texas Instruments Incorporated - https://www.ti.com
>   *
>   */
> +#include <linux/gpio/consumer.h>
>  #include <linux/phy/phy.h>
>  #include <linux/platform_device.h>
>  #include <linux/property.h>
>  #include <linux/module.h>
> -#include <linux/gpio.h>
> -#include <linux/gpio/consumer.h>
>  #include <linux/mux/consumer.h>
>  
>  struct can_transceiver_data {
Reviewed-by: Josua Mayer <josua@solid-run.com>

WARNING: multiple messages have this Message-ID (diff)
From: Josua Mayer <josua@solid-run.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v2 4/4] phy: phy-can-transceiver: Drop unused include
Date: Mon, 27 Apr 2026 11:05:21 +0000	[thread overview]
Message-ID: <5b40e1ab-29a5-40f2-a4e6-560f3057633c@solid-run.com> (raw)
In-Reply-To: <20260317203001.2108568-5-andriy.shevchenko@linux.intel.com>

Am 17.03.26 um 21:27 schrieb Andy Shevchenko:
> This file does not use the symbols from the legacy
> <linux/gpio.h> header, so let's drop it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/phy/phy-can-transceiver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-can-transceiver.c b/drivers/phy/phy-can-transceiver.c
> index 21b0406d1a09..8e250039c183 100644
> --- a/drivers/phy/phy-can-transceiver.c
> +++ b/drivers/phy/phy-can-transceiver.c
> @@ -5,12 +5,11 @@
>   * Copyright (C) 2021 Texas Instruments Incorporated - https://www.ti.com
>   *
>   */
> +#include <linux/gpio/consumer.h>
>  #include <linux/phy/phy.h>
>  #include <linux/platform_device.h>
>  #include <linux/property.h>
>  #include <linux/module.h>
> -#include <linux/gpio.h>
> -#include <linux/gpio/consumer.h>
>  #include <linux/mux/consumer.h>
>  
>  struct can_transceiver_data {
Reviewed-by: Josua Mayer <josua@solid-run.com>
-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  reply	other threads:[~2026-04-27 11:05 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 20:27 [PATCH v2 0/4] phy: phy-can-transceiver: Ad-hoc cleanups and refactoring Andy Shevchenko
2026-03-17 20:27 ` Andy Shevchenko
2026-03-17 20:27 ` [PATCH v2 1/4] phy: phy-can-transceiver: Convert to use device property API Andy Shevchenko
2026-03-17 20:27   ` Andy Shevchenko
2026-04-27 11:26   ` Josua Mayer
2026-04-27 11:26     ` Josua Mayer
2026-03-17 20:27 ` [PATCH v2 2/4] phy: phy-can-transceiver: Move OF ID table closer to their user Andy Shevchenko
2026-03-17 20:27   ` Andy Shevchenko
2026-05-03 17:00   ` Vinod Koul
2026-05-03 17:00     ` Vinod Koul
2026-03-17 20:27 ` [PATCH v2 3/4] phy: phy-can-transceiver: Don't check for specific errors when parsing properties Andy Shevchenko
2026-03-17 20:27   ` Andy Shevchenko
2026-03-17 20:27 ` [PATCH v2 4/4] phy: phy-can-transceiver: Drop unused include Andy Shevchenko
2026-03-17 20:27   ` Andy Shevchenko
2026-04-27 11:05   ` Josua Mayer [this message]
2026-04-27 11:05     ` Josua Mayer
2026-04-14 18:43 ` [PATCH v2 0/4] phy: phy-can-transceiver: Ad-hoc cleanups and refactoring Andy Shevchenko
2026-04-14 18:43   ` Andy Shevchenko
2026-04-27 11:09   ` Josua Mayer
2026-04-27 11:09     ` Josua Mayer
2026-04-27 13:34     ` Andy Shevchenko
2026-04-27 13:34       ` Andy Shevchenko
2026-04-27 13:41       ` Josua Mayer
2026-04-27 13:41         ` Josua Mayer
2026-04-27 15:26         ` Andy Shevchenko
2026-04-27 15:26           ` Andy Shevchenko
2026-05-04  6:58           ` Andy Shevchenko
2026-05-04  6:58             ` Andy Shevchenko
2026-05-05  9:18             ` Josua Mayer
2026-05-05  9:18               ` Josua Mayer
2026-05-03 17:01   ` Vinod Koul
2026-05-03 17:01     ` Vinod Koul
2026-05-04  7:01     ` Andy Shevchenko
2026-05-04  7:01       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b40e1ab-29a5-40f2-a4e6-560f3057633c@solid-run.com \
    --to=josua@solid-run.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mailhol@kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=neil.armstrong@linaro.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.