From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: kbuild-all@lists.01.org, kernel test robot <lkp@intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
Date: Fri, 25 Feb 2022 13:25:28 +0000 [thread overview]
Message-ID: <5ba4356d4d526d72118664dd93d5f6f2@kernel.org> (raw)
In-Reply-To: <20220225122922.GA19390@willie-the-truck>
On 2022-02-25 12:29, Will Deacon wrote:
> On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>>
>>
>> Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to
>> the guest")
>> CC: Will Deacon <will@kernel.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> ---
>>
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> master
>> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
>> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM:
>> arm64: Expose PSCI SYSTEM_RESET2 call to the guest
>> :::::: branch date: 18 hours ago
>> :::::: commit date: 3 days ago
>>
>> arch/arm64/kvm/psci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/arm64/kvm/psci.c
>> +++ b/arch/arm64/kvm/psci.c
>> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
>> ret = 0;
>> }
>> break;
>> - };
>> + }
>
> Acked-by: Will Deacon <will@kernel.org>
>
> but I really don't think this needs a Fixes: tag
The Fixes: really isn't warranted, there is a previous patch fixing
the same thing already[1], and there is *another* '};' typo in the
same file that the robot failed to pick on...
If you don't mind, I'll add your Ack to the original fix, and squash
the fix for the fix into it.
[1]
https://lore.kernel.org/r/20220223092750.1934130-1-deng.changcheng@zte.com.cn
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>,
Catalin Marinas <catalin.marinas@arm.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
Date: Fri, 25 Feb 2022 13:25:28 +0000 [thread overview]
Message-ID: <5ba4356d4d526d72118664dd93d5f6f2@kernel.org> (raw)
In-Reply-To: <20220225122922.GA19390@willie-the-truck>
On 2022-02-25 12:29, Will Deacon wrote:
> On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>>
>>
>> Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to
>> the guest")
>> CC: Will Deacon <will@kernel.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> ---
>>
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> master
>> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
>> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM:
>> arm64: Expose PSCI SYSTEM_RESET2 call to the guest
>> :::::: branch date: 18 hours ago
>> :::::: commit date: 3 days ago
>>
>> arch/arm64/kvm/psci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/arm64/kvm/psci.c
>> +++ b/arch/arm64/kvm/psci.c
>> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
>> ret = 0;
>> }
>> break;
>> - };
>> + }
>
> Acked-by: Will Deacon <will@kernel.org>
>
> but I really don't think this needs a Fixes: tag
The Fixes: really isn't warranted, there is a previous patch fixing
the same thing already[1], and there is *another* '};' typo in the
same file that the robot failed to pick on...
If you don't mind, I'll add your Ack to the original fix, and squash
the fix for the fix into it.
[1]
https://lore.kernel.org/r/20220223092750.1934130-1-deng.changcheng@zte.com.cn
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
Date: Fri, 25 Feb 2022 13:25:28 +0000 [thread overview]
Message-ID: <5ba4356d4d526d72118664dd93d5f6f2@kernel.org> (raw)
In-Reply-To: <20220225122922.GA19390@willie-the-truck>
[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]
On 2022-02-25 12:29, Will Deacon wrote:
> On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>>
>>
>> Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to
>> the guest")
>> CC: Will Deacon <will@kernel.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> ---
>>
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> master
>> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
>> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM:
>> arm64: Expose PSCI SYSTEM_RESET2 call to the guest
>> :::::: branch date: 18 hours ago
>> :::::: commit date: 3 days ago
>>
>> arch/arm64/kvm/psci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/arm64/kvm/psci.c
>> +++ b/arch/arm64/kvm/psci.c
>> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
>> ret = 0;
>> }
>> break;
>> - };
>> + }
>
> Acked-by: Will Deacon <will@kernel.org>
>
> but I really don't think this needs a Fixes: tag
The Fixes: really isn't warranted, there is a previous patch fixing
the same thing already[1], and there is *another* '};' typo in the
same file that the robot failed to pick on...
If you don't mind, I'll add your Ack to the original fix, and squash
the fix for the fix into it.
[1]
https://lore.kernel.org/r/20220223092750.1934130-1-deng.changcheng(a)zte.com.cn
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Will Deacon <will@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Linux Memory Management List <linux-mm@kvack.org>,
Catalin Marinas <catalin.marinas@arm.com>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
Date: Fri, 25 Feb 2022 13:25:28 +0000 [thread overview]
Message-ID: <5ba4356d4d526d72118664dd93d5f6f2@kernel.org> (raw)
In-Reply-To: <20220225122922.GA19390@willie-the-truck>
On 2022-02-25 12:29, Will Deacon wrote:
> On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>>
>>
>> Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to
>> the guest")
>> CC: Will Deacon <will@kernel.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> ---
>>
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> master
>> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
>> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM:
>> arm64: Expose PSCI SYSTEM_RESET2 call to the guest
>> :::::: branch date: 18 hours ago
>> :::::: commit date: 3 days ago
>>
>> arch/arm64/kvm/psci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/arm64/kvm/psci.c
>> +++ b/arch/arm64/kvm/psci.c
>> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
>> ret = 0;
>> }
>> break;
>> - };
>> + }
>
> Acked-by: Will Deacon <will@kernel.org>
>
> but I really don't think this needs a Fixes: tag
The Fixes: really isn't warranted, there is a previous patch fixing
the same thing already[1], and there is *another* '};' typo in the
same file that the robot failed to pick on...
If you don't mind, I'll add your Ack to the original fix, and squash
the fix for the fix into it.
[1]
https://lore.kernel.org/r/20220223092750.1934130-1-deng.changcheng@zte.com.cn
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2022-02-25 13:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 20:11 [linux-next:master 7067/7915] arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon kernel test robot
2022-02-24 20:07 ` [PATCH] KVM: arm64: fix semicolon.cocci warnings kernel test robot
2022-02-24 20:07 ` kernel test robot
2022-02-24 20:07 ` kernel test robot
2022-02-25 12:29 ` Will Deacon
2022-02-25 12:29 ` Will Deacon
2022-02-25 12:29 ` Will Deacon
2022-02-25 12:29 ` Will Deacon
2022-02-25 13:25 ` Marc Zyngier [this message]
2022-02-25 13:25 ` Marc Zyngier
2022-02-25 13:25 ` Marc Zyngier
2022-02-25 13:25 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ba4356d4d526d72118664dd93d5f6f2@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=kbuild-all@lists.01.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.