* Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
@ 2022-02-25 12:29 ` Will Deacon
0 siblings, 0 replies; 12+ messages in thread
From: Will Deacon @ 2022-02-25 12:29 UTC (permalink / raw)
To: kernel test robot
Cc: kbuild-all, Linux Memory Management List, Marc Zyngier,
James Morse, Alexandru Elisei, Suzuki K Poulose, Catalin Marinas,
linux-arm-kernel, kvmarm, linux-kernel
On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to the guest")
> CC: Will Deacon <will@kernel.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM: arm64: Expose PSCI SYSTEM_RESET2 call to the guest
> :::::: branch date: 18 hours ago
> :::::: commit date: 3 days ago
>
> arch/arm64/kvm/psci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/arm64/kvm/psci.c
> +++ b/arch/arm64/kvm/psci.c
> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
> ret = 0;
> }
> break;
> - };
> + }
Acked-by: Will Deacon <will@kernel.org>
but I really don't think this needs a Fixes: tag
Will
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
@ 2022-02-25 12:29 ` Will Deacon
0 siblings, 0 replies; 12+ messages in thread
From: Will Deacon @ 2022-02-25 12:29 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]
On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to the guest")
> CC: Will Deacon <will@kernel.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM: arm64: Expose PSCI SYSTEM_RESET2 call to the guest
> :::::: branch date: 18 hours ago
> :::::: commit date: 3 days ago
>
> arch/arm64/kvm/psci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/arm64/kvm/psci.c
> +++ b/arch/arm64/kvm/psci.c
> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
> ret = 0;
> }
> break;
> - };
> + }
Acked-by: Will Deacon <will@kernel.org>
but I really don't think this needs a Fixes: tag
Will
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
@ 2022-02-25 12:29 ` Will Deacon
0 siblings, 0 replies; 12+ messages in thread
From: Will Deacon @ 2022-02-25 12:29 UTC (permalink / raw)
To: kernel test robot
Cc: kbuild-all, Linux Memory Management List, Marc Zyngier,
James Morse, Alexandru Elisei, Suzuki K Poulose, Catalin Marinas,
linux-arm-kernel, kvmarm, linux-kernel
On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to the guest")
> CC: Will Deacon <will@kernel.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM: arm64: Expose PSCI SYSTEM_RESET2 call to the guest
> :::::: branch date: 18 hours ago
> :::::: commit date: 3 days ago
>
> arch/arm64/kvm/psci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/arm64/kvm/psci.c
> +++ b/arch/arm64/kvm/psci.c
> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
> ret = 0;
> }
> break;
> - };
> + }
Acked-by: Will Deacon <will@kernel.org>
but I really don't think this needs a Fixes: tag
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
2022-02-25 12:29 ` Will Deacon
(?)
(?)
@ 2022-02-25 13:25 ` Marc Zyngier
-1 siblings, 0 replies; 12+ messages in thread
From: Marc Zyngier @ 2022-02-25 13:25 UTC (permalink / raw)
To: Will Deacon
Cc: kbuild-all, kernel test robot, Catalin Marinas, linux-kernel,
Linux Memory Management List, kvmarm, linux-arm-kernel
On 2022-02-25 12:29, Will Deacon wrote:
> On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>>
>>
>> Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to
>> the guest")
>> CC: Will Deacon <will@kernel.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> ---
>>
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> master
>> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
>> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM:
>> arm64: Expose PSCI SYSTEM_RESET2 call to the guest
>> :::::: branch date: 18 hours ago
>> :::::: commit date: 3 days ago
>>
>> arch/arm64/kvm/psci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/arm64/kvm/psci.c
>> +++ b/arch/arm64/kvm/psci.c
>> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
>> ret = 0;
>> }
>> break;
>> - };
>> + }
>
> Acked-by: Will Deacon <will@kernel.org>
>
> but I really don't think this needs a Fixes: tag
The Fixes: really isn't warranted, there is a previous patch fixing
the same thing already[1], and there is *another* '};' typo in the
same file that the robot failed to pick on...
If you don't mind, I'll add your Ack to the original fix, and squash
the fix for the fix into it.
[1]
https://lore.kernel.org/r/20220223092750.1934130-1-deng.changcheng@zte.com.cn
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
@ 2022-02-25 13:25 ` Marc Zyngier
0 siblings, 0 replies; 12+ messages in thread
From: Marc Zyngier @ 2022-02-25 13:25 UTC (permalink / raw)
To: Will Deacon
Cc: kernel test robot, kbuild-all, linux-kernel,
Linux Memory Management List, Catalin Marinas, kvmarm,
linux-arm-kernel
On 2022-02-25 12:29, Will Deacon wrote:
> On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>>
>>
>> Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to
>> the guest")
>> CC: Will Deacon <will@kernel.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> ---
>>
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> master
>> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
>> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM:
>> arm64: Expose PSCI SYSTEM_RESET2 call to the guest
>> :::::: branch date: 18 hours ago
>> :::::: commit date: 3 days ago
>>
>> arch/arm64/kvm/psci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/arm64/kvm/psci.c
>> +++ b/arch/arm64/kvm/psci.c
>> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
>> ret = 0;
>> }
>> break;
>> - };
>> + }
>
> Acked-by: Will Deacon <will@kernel.org>
>
> but I really don't think this needs a Fixes: tag
The Fixes: really isn't warranted, there is a previous patch fixing
the same thing already[1], and there is *another* '};' typo in the
same file that the robot failed to pick on...
If you don't mind, I'll add your Ack to the original fix, and squash
the fix for the fix into it.
[1]
https://lore.kernel.org/r/20220223092750.1934130-1-deng.changcheng@zte.com.cn
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
@ 2022-02-25 13:25 ` Marc Zyngier
0 siblings, 0 replies; 12+ messages in thread
From: Marc Zyngier @ 2022-02-25 13:25 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1731 bytes --]
On 2022-02-25 12:29, Will Deacon wrote:
> On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>>
>>
>> Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to
>> the guest")
>> CC: Will Deacon <will@kernel.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> ---
>>
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> master
>> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
>> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM:
>> arm64: Expose PSCI SYSTEM_RESET2 call to the guest
>> :::::: branch date: 18 hours ago
>> :::::: commit date: 3 days ago
>>
>> arch/arm64/kvm/psci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/arm64/kvm/psci.c
>> +++ b/arch/arm64/kvm/psci.c
>> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
>> ret = 0;
>> }
>> break;
>> - };
>> + }
>
> Acked-by: Will Deacon <will@kernel.org>
>
> but I really don't think this needs a Fixes: tag
The Fixes: really isn't warranted, there is a previous patch fixing
the same thing already[1], and there is *another* '};' typo in the
same file that the robot failed to pick on...
If you don't mind, I'll add your Ack to the original fix, and squash
the fix for the fix into it.
[1]
https://lore.kernel.org/r/20220223092750.1934130-1-deng.changcheng(a)zte.com.cn
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] KVM: arm64: fix semicolon.cocci warnings
@ 2022-02-25 13:25 ` Marc Zyngier
0 siblings, 0 replies; 12+ messages in thread
From: Marc Zyngier @ 2022-02-25 13:25 UTC (permalink / raw)
To: Will Deacon
Cc: kernel test robot, kbuild-all, linux-kernel,
Linux Memory Management List, Catalin Marinas, kvmarm,
linux-arm-kernel
On 2022-02-25 12:29, Will Deacon wrote:
> On Fri, Feb 25, 2022 at 04:07:24AM +0800, kernel test robot wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> arch/arm64/kvm/psci.c:372:3-4: Unneeded semicolon
>>
>>
>> Remove unneeded semicolon.
>>
>> Generated by: scripts/coccinelle/misc/semicolon.cocci
>>
>> Fixes: d43583b890e7 ("KVM: arm64: Expose PSCI SYSTEM_RESET2 call to
>> the guest")
>> CC: Will Deacon <will@kernel.org>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: kernel test robot <lkp@intel.com>
>> ---
>>
>> tree:
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
>> master
>> head: d4a0ae62a277377de396850ed4b709b6bd9b7326
>> commit: d43583b890e7cb0078d13d056753a56602b92406 [7067/7915] KVM:
>> arm64: Expose PSCI SYSTEM_RESET2 call to the guest
>> :::::: branch date: 18 hours ago
>> :::::: commit date: 3 days ago
>>
>> arch/arm64/kvm/psci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/arch/arm64/kvm/psci.c
>> +++ b/arch/arm64/kvm/psci.c
>> @@ -369,7 +369,7 @@ static int kvm_psci_1_x_call(struct kvm_
>> ret = 0;
>> }
>> break;
>> - };
>> + }
>
> Acked-by: Will Deacon <will@kernel.org>
>
> but I really don't think this needs a Fixes: tag
The Fixes: really isn't warranted, there is a previous patch fixing
the same thing already[1], and there is *another* '};' typo in the
same file that the robot failed to pick on...
If you don't mind, I'll add your Ack to the original fix, and squash
the fix for the fix into it.
[1]
https://lore.kernel.org/r/20220223092750.1934130-1-deng.changcheng@zte.com.cn
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread