All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Sean Paul <sean@poorly.run>,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org
Cc: Sean Paul <seanpaul@chromium.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs
Date: Fri, 24 May 2019 13:43:35 -0700	[thread overview]
Message-ID: <5ce85778.1c69fb81.ccfd3.bac8@mx.google.com> (raw)
In-Reply-To: <20190524173231.5040-1-sean@poorly.run>

Quoting Sean Paul (2019-05-24 10:32:18)
> From: Sean Paul <seanpaul@chromium.org>
> 
> Instead of reaching into dev->primary for debugfs_root, use the minor
> passed into debugfs_init.
> 
> This avoids creating the debug directory under /sys/kernel/debug/ and
> instead creates the directory under the correct node in
> /sys/kernel/debug/dri/<node>/

So does this make it become /sys/kernel/debug/dri/<node>/debug?

I wonder why it can't all be created under /sys/kernel/debug/dri/<node>
and then avoid the extra "debug" directory that isn't adding any value?


WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>,
	Rob Clark <robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Sean Paul <seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs
Date: Fri, 24 May 2019 13:43:35 -0700	[thread overview]
Message-ID: <5ce85778.1c69fb81.ccfd3.bac8@mx.google.com> (raw)
In-Reply-To: <20190524173231.5040-1-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>

Quoting Sean Paul (2019-05-24 10:32:18)
> From: Sean Paul <seanpaul@chromium.org>
> 
> Instead of reaching into dev->primary for debugfs_root, use the minor
> passed into debugfs_init.
> 
> This avoids creating the debug directory under /sys/kernel/debug/ and
> instead creates the directory under the correct node in
> /sys/kernel/debug/dri/<node>/

So does this make it become /sys/kernel/debug/dri/<node>/debug?

I wonder why it can't all be created under /sys/kernel/debug/dri/<node>
and then avoid the extra "debug" directory that isn't adding any value?

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

  parent reply	other threads:[~2019-05-24 20:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 17:32 [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs Sean Paul
2019-05-24 17:32 ` Sean Paul
2019-05-24 17:32 ` [PATCH 2/2] drm/msm/dpu: Remove _dpu_debugfs_init Sean Paul
2019-05-24 17:32   ` Sean Paul
2019-05-24 20:18   ` Abhinav Kumar
2019-05-24 20:18     ` Abhinav Kumar
2019-05-24 20:16 ` [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs Abhinav Kumar
2019-05-24 20:16   ` Abhinav Kumar
2019-05-24 20:43 ` Stephen Boyd [this message]
2019-05-24 20:43   ` Stephen Boyd
2019-05-24 22:32   ` Rob Clark
2019-05-24 22:32     ` Rob Clark
     [not found]   ` <5ce85778.1c69fb81.ccfd3.bac8-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
2019-05-28 15:13     ` [PATCH v2] " Sean Paul
     [not found]       ` <20190528151339.207978-1-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2019-05-28 15:28         ` Rob Clark
2019-05-28 15:41         ` Jordan Crouse
2019-05-28 18:26           ` [PATCH] drm/msm/dpu: Remove bogus comment Sean Paul
2019-05-28 18:26             ` Sean Paul
2019-05-28 20:34             ` Jordan Crouse
2019-05-28 20:34               ` Jordan Crouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ce85778.1c69fb81.ccfd3.bac8@mx.google.com \
    --to=swboyd@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.