All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhinav Kumar <abhinavk@codeaurora.org>
To: Sean Paul <sean@poorly.run>
Cc: dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	Sean Paul <seanpaul@chromium.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Rob Clark <robdclark@gmail.com>,
	linux-arm-msm@vger.kernel.org,
	linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/msm/dpu: Remove _dpu_debugfs_init
Date: Fri, 24 May 2019 13:18:16 -0700	[thread overview]
Message-ID: <8d0b87d94fd3fa4468965753e7c325c1@codeaurora.org> (raw)
In-Reply-To: <20190524173231.5040-2-sean@poorly.run>

On 2019-05-24 10:32, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> Fold it into dpu_debugfs_init.
> 
> Cc: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index d77071965431..0a8c334c3a9f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -231,8 +231,9 @@ void *dpu_debugfs_create_regset32(const char
> *name, umode_t mode,
>  			regset, &dpu_fops_regset32);
>  }
> 
> -static int _dpu_debugfs_init(struct dpu_kms *dpu_kms, struct drm_minor 
> *minor)
> +static int dpu_kms_debugfs_init(struct msm_kms *kms, struct drm_minor 
> *minor)
>  {
> +	struct dpu_kms *dpu_kms = to_dpu_kms(kms);
>  	void *p = dpu_hw_util_get_log_mask_ptr();
>  	struct dentry *entry;
> 
> @@ -578,13 +579,6 @@ static int _dpu_kms_drm_obj_init(struct dpu_kms 
> *dpu_kms)
>  	return ret;
>  }
> 
> -#ifdef CONFIG_DEBUG_FS
> -static int dpu_kms_debugfs_init(struct msm_kms *kms, struct drm_minor 
> *minor)
> -{
> -	return _dpu_debugfs_init(to_dpu_kms(kms), minor);
> -}
> -#endif
> -
>  static long dpu_kms_round_pixclk(struct msm_kms *kms, unsigned long 
> rate,
>  		struct drm_encoder *encoder)
>  {

WARNING: multiple messages have this Message-ID (diff)
From: Abhinav Kumar <abhinavk@codeaurora.org>
To: Sean Paul <sean@poorly.run>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Stephen Boyd <swboyd@chromium.org>,
	Sean Paul <seanpaul@chromium.org>,
	freedreno@lists.freedesktop.org,
	linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH 2/2] drm/msm/dpu: Remove _dpu_debugfs_init
Date: Fri, 24 May 2019 13:18:16 -0700	[thread overview]
Message-ID: <8d0b87d94fd3fa4468965753e7c325c1@codeaurora.org> (raw)
In-Reply-To: <20190524173231.5040-2-sean@poorly.run>

On 2019-05-24 10:32, Sean Paul wrote:
> From: Sean Paul <seanpaul@chromium.org>
> 
> Fold it into dpu_debugfs_init.
> 
> Cc: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index d77071965431..0a8c334c3a9f 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -231,8 +231,9 @@ void *dpu_debugfs_create_regset32(const char
> *name, umode_t mode,
>  			regset, &dpu_fops_regset32);
>  }
> 
> -static int _dpu_debugfs_init(struct dpu_kms *dpu_kms, struct drm_minor 
> *minor)
> +static int dpu_kms_debugfs_init(struct msm_kms *kms, struct drm_minor 
> *minor)
>  {
> +	struct dpu_kms *dpu_kms = to_dpu_kms(kms);
>  	void *p = dpu_hw_util_get_log_mask_ptr();
>  	struct dentry *entry;
> 
> @@ -578,13 +579,6 @@ static int _dpu_kms_drm_obj_init(struct dpu_kms 
> *dpu_kms)
>  	return ret;
>  }
> 
> -#ifdef CONFIG_DEBUG_FS
> -static int dpu_kms_debugfs_init(struct msm_kms *kms, struct drm_minor 
> *minor)
> -{
> -	return _dpu_debugfs_init(to_dpu_kms(kms), minor);
> -}
> -#endif
> -
>  static long dpu_kms_round_pixclk(struct msm_kms *kms, unsigned long 
> rate,
>  		struct drm_encoder *encoder)
>  {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-05-24 20:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-24 17:32 [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs Sean Paul
2019-05-24 17:32 ` Sean Paul
2019-05-24 17:32 ` [PATCH 2/2] drm/msm/dpu: Remove _dpu_debugfs_init Sean Paul
2019-05-24 17:32   ` Sean Paul
2019-05-24 20:18   ` Abhinav Kumar [this message]
2019-05-24 20:18     ` Abhinav Kumar
2019-05-24 20:16 ` [PATCH 1/2] drm/msm/dpu: Use provided drm_minor to initialize debugfs Abhinav Kumar
2019-05-24 20:16   ` Abhinav Kumar
2019-05-24 20:43 ` Stephen Boyd
2019-05-24 20:43   ` Stephen Boyd
2019-05-24 22:32   ` Rob Clark
2019-05-24 22:32     ` Rob Clark
     [not found]   ` <5ce85778.1c69fb81.ccfd3.bac8-ATjtLOhZ0NVl57MIdRCFDg@public.gmane.org>
2019-05-28 15:13     ` [PATCH v2] " Sean Paul
     [not found]       ` <20190528151339.207978-1-sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>
2019-05-28 15:28         ` Rob Clark
2019-05-28 15:41         ` Jordan Crouse
2019-05-28 18:26           ` [PATCH] drm/msm/dpu: Remove bogus comment Sean Paul
2019-05-28 18:26             ` Sean Paul
2019-05-28 20:34             ` Jordan Crouse
2019-05-28 20:34               ` Jordan Crouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8d0b87d94fd3fa4468965753e7c325c1@codeaurora.org \
    --to=abhinavk@codeaurora.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=seanpaul@chromium.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.