From: Mark Salyzyn via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Hugh Dickins <hughd@google.com>,
Mike Marshall <hubcap@omnibond.com>,
James Morris <jmorris@namei.org>,
devel@lists.orangefs.org, Eric Van Hensbergen <ericvh@gmail.com>,
Joel Becker <jlbec@evilplan.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Mathieu Malaterre <malat@debian.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <shaggy@kernel.org>,
linux-doc@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Mimi Zohar <zohar@linux.ibm.com>,
linux-cifs@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@sandeen.net>,
kernel-team@android.com, selinux@vger.kernel.o
Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr
Date: Wed, 28 Aug 2019 07:40:15 -0700 [thread overview]
Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> (raw)
In-Reply-To: <20190828142423.GA1955@infradead.org>
On 8/28/19 7:24 AM, Christoph Hellwig wrote:
> On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote:
>> Replace arguments for get and set xattr methods, and __vfs_getxattr
>> and __vfs_setaxtr functions with a reference to the following now
>> common argument structure:
> Yikes. That looks like a mess. Why can't we pass a kernel-only
> flag in the existing flags field for ₋>set and add a flags field
> to ->get? Passing methods by structure always tends to be a mess.
This was a response to GregKH@ criticism, an earlier patch set just
added a flag as you stated to get method, until complaints of an
excessively long argument list and fragility to add or change more
arguments.
So many ways have been tried to skin this cat ... the risk was taken to
please some, and we now have hundreds of stakeholders, when the first
patch set was less than a dozen. A recipe for failure?
-- Mark
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn <salyzyn@android.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr
Date: Wed, 28 Aug 2019 07:40:15 -0700 [thread overview]
Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> (raw)
In-Reply-To: <20190828142423.GA1955@infradead.org>
On 8/28/19 7:24 AM, Christoph Hellwig wrote:
> On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote:
>> Replace arguments for get and set xattr methods, and __vfs_getxattr
>> and __vfs_setaxtr functions with a reference to the following now
>> common argument structure:
> Yikes. That looks like a mess. Why can't we pass a kernel-only
> flag in the existing flags field for ?>set and add a flags field
> to ->get? Passing methods by structure always tends to be a mess.
This was a response to GregKH@ criticism, an earlier patch set just
added a flag as you stated to get method, until complaints of an
excessively long argument list and fragility to add or change more
arguments.
So many ways have been tried to skin this cat ... the risk was taken to
please some, and we now have hundreds of stakeholders, when the first
patch set was less than a dozen. A recipe for failure?
-- Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Hugh Dickins <hughd@google.com>,
Mike Marshall <hubcap@omnibond.com>,
James Morris <jmorris@namei.org>,
devel@lists.orangefs.org, Eric Van Hensbergen <ericvh@gmail.com>,
Joel Becker <jlbec@evilplan.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Mathieu Malaterre <malat@debian.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <shaggy@kernel.org>,
linux-doc@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Mimi Zohar <zohar@linux.ibm.com>,
linux-cifs@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@sandeen.net>,
kernel-team@android.com, selinux@vger.kernel.o
Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr
Date: Wed, 28 Aug 2019 07:40:15 -0700 [thread overview]
Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> (raw)
In-Reply-To: <20190828142423.GA1955@infradead.org>
On 8/28/19 7:24 AM, Christoph Hellwig wrote:
> On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote:
>> Replace arguments for get and set xattr methods, and __vfs_getxattr
>> and __vfs_setaxtr functions with a reference to the following now
>> common argument structure:
> Yikes. That looks like a mess. Why can't we pass a kernel-only
> flag in the existing flags field for â‚‹>set and add a flags field
> to ->get? Passing methods by structure always tends to be a mess.
This was a response to GregKH@ criticism, an earlier patch set just
added a flag as you stated to get method, until complaints of an
excessively long argument list and fragility to add or change more
arguments.
So many ways have been tried to skin this cat ... the risk was taken to
please some, and we now have hundreds of stakeholders, when the first
patch set was less than a dozen. A recipe for failure?
-- Mark
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn via Linux-erofs <linux-erofs@lists.ozlabs.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Hugh Dickins <hughd@google.com>,
Mike Marshall <hubcap@omnibond.com>,
James Morris <jmorris@namei.org>,
devel@lists.orangefs.org, Eric Van Hensbergen <ericvh@gmail.com>,
Joel Becker <jlbec@evilplan.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Mathieu Malaterre <malat@debian.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <shaggy@kernel.org>,
linux-doc@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Mimi Zohar <zohar@linux.ibm.com>,
linux-cifs@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@sandeen.net>,
kernel-team@android.com, selinux@vger.kernel.org,
Brian Foster <bfoster@redhat.com>,
reiserfs-devel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-f2fs-devel@lists.sourceforge.net,
Benjamin Coddington <bcodding@redhat.com>,
linux-integrity@vger.kernel.org,
Martin Brandenburg <martin@omnibond.com>,
Chris Mason <clm@fb.com>,
linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org,
Jonathan Corbet <corbet@lwn.net>,
Vyacheslav Dubeyko <slava@dubeyko.com>,
Allison Henderson <allison.henderson@oracle.com>,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
Serge Hallyn <serge@hallyn.com>,
Eric Paris <eparis@parisplace.org>,
ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org, samba-technical@lists.samba.org,
linux-xfs@vger.kernel.org, Bob Peterson <rpeterso@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net,
Jan Kara <jack@suse.cz>, Eric Biggers <ebiggers@google.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Adrian Hunter <adrian.hunter@intel.com>,
David Howells <dhowells@redhat.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
devel@driverdev.osuosl.org,
"J. Bruce Fields" <bfields@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>, Richard Weinberger <richard@nod.at>,
Mark Fasheh <mark@fasheh.com>,
cluster-devel@redhat.com, Steve French <sfrench@samba.org>,
v9fs-developer@lists.sourceforge.net,
Bharath Vedartham <linux.bhar@gmail.com>,
Jann Horn <jannh@google.com>,
ecryptfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
Dave Chinner <dchinner@redhat.com>,
David Sterba <dsterba@suse.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
netdev@vger.kernel.org, linux-unionfs@vger.kernel.org,
stable@vger.kernel.org, Tyler Hicks <tyhicks@canonical.com>,
linux-security-module@vger.kernel.org,
Phillip Lougher <phillip@squashfs.org.uk>,
David Woodhouse <dwmw2@infradead.org>,
linux-btrfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr
Date: Wed, 28 Aug 2019 07:40:15 -0700 [thread overview]
Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> (raw)
In-Reply-To: <20190828142423.GA1955@infradead.org>
On 8/28/19 7:24 AM, Christoph Hellwig wrote:
> On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote:
>> Replace arguments for get and set xattr methods, and __vfs_getxattr
>> and __vfs_setaxtr functions with a reference to the following now
>> common argument structure:
> Yikes. That looks like a mess. Why can't we pass a kernel-only
> flag in the existing flags field for ₋>set and add a flags field
> to ->get? Passing methods by structure always tends to be a mess.
This was a response to GregKH@ criticism, an earlier patch set just
added a flag as you stated to get method, until complaints of an
excessively long argument list and fragility to add or change more
arguments.
So many ways have been tried to skin this cat ... the risk was taken to
please some, and we now have hundreds of stakeholders, when the first
patch set was less than a dozen. A recipe for failure?
-- Mark
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Hugh Dickins <hughd@google.com>,
Mike Marshall <hubcap@omnibond.com>,
James Morris <jmorris@namei.org>,
devel@lists.orangefs.org, Eric Van Hensbergen <ericvh@gmail.com>,
Joel Becker <jlbec@evilplan.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Mathieu Malaterre <malat@debian.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <shaggy@kernel.org>,
linux-doc@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Mimi Zohar <zohar@linux.ibm.com>,
linux-cifs@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@sandeen.net>,
kernel-team@android.com, selinux@vger.kernel.org,
Brian Foster <bfoster@redhat.com>,
reiserfs-devel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-f2fs-devel@lists.sourceforge.net,
Benjamin Coddington <bcodding@redhat.com>,
linux-integrity@vger.kernel.org,
Martin Brandenburg <martin@omnibond.com>,
Chris Mason <clm@fb.com>,
linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org,
Jonathan Corbet <corbet@lwn.net>,
Vyacheslav Dubeyko <slava@dubeyko.com>,
Allison Henderson <allison.henderson@oracle.com>,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
Serge Hallyn <serge@hallyn.com>,
Eric Paris <eparis@parisplace.org>,
ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org, samba-technical@lists.samba.org,
linux-xfs@vger.kernel.org, Bob Peterson <rpeterso@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net,
Jan Kara <jack@suse.cz>, Eric Biggers <ebiggers@google.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Adrian Hunter <adrian.hunter@intel.com>,
David Howells <dhowells@redhat.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
devel@driverdev.osuosl.org,
"J. Bruce Fields" <bfields@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>, Richard Weinberger <richard@nod.at>,
Mark Fasheh <mark@fasheh.com>,
cluster-devel@redhat.com, Steve French <sfrench@samba.org>,
v9fs-developer@lists.sourceforge.net,
Bharath Vedartham <linux.bhar@gmail.com>,
Jann Horn <jannh@google.com>,
ecryptfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
Dave Chinner <dchinner@redhat.com>,
David Sterba <dsterba@suse.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
netdev@vger.kernel.org, linux-unionfs@vger.kernel.org,
stable@vger.kernel.org, Tyler Hicks <tyhicks@canonical.com>,
linux-security-module@vger.kernel.org,
Phillip Lougher <phillip@squashfs.org.uk>,
David Woodhouse <dwmw2@infradead.org>,
linux-btrfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [f2fs-dev] [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr
Date: Wed, 28 Aug 2019 07:40:15 -0700 [thread overview]
Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> (raw)
In-Reply-To: <20190828142423.GA1955@infradead.org>
On 8/28/19 7:24 AM, Christoph Hellwig wrote:
> On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote:
>> Replace arguments for get and set xattr methods, and __vfs_getxattr
>> and __vfs_setaxtr functions with a reference to the following now
>> common argument structure:
> Yikes. That looks like a mess. Why can't we pass a kernel-only
> flag in the existing flags field for ₋>set and add a flags field
> to ->get? Passing methods by structure always tends to be a mess.
This was a response to GregKH@ criticism, an earlier patch set just
added a flag as you stated to get method, until complaints of an
excessively long argument list and fragility to add or change more
arguments.
So many ways have been tried to skin this cat ... the risk was taken to
please some, and we now have hundreds of stakeholders, when the first
patch set was less than a dozen. A recipe for failure?
-- Mark
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn <salyzyn@android.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Latchesar Ionkov <lucho@ionkov.net>,
Hugh Dickins <hughd@google.com>,
Mike Marshall <hubcap@omnibond.com>,
James Morris <jmorris@namei.org>,
devel@lists.orangefs.org, Eric Van Hensbergen <ericvh@gmail.com>,
Joel Becker <jlbec@evilplan.org>,
Anna Schumaker <anna.schumaker@netapp.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Mathieu Malaterre <malat@debian.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.com>,
Casey Schaufler <casey@schaufler-ca.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <shaggy@kernel.org>,
linux-doc@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
Chao Yu <yuchao0@huawei.com>, Mimi Zohar <zohar@linux.ibm.com>,
linux-cifs@vger.kernel.org, Paul Moore <paul@paul-moore.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@sandeen.net>,
kernel-team@android.com, selinux@vger.kernel.org,
Brian Foster <bfoster@redhat.com>,
reiserfs-devel@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Jaegeuk Kim <jaegeuk@kernel.org>, Theodore Ts'o <tytso@mit.edu>,
Miklos Szeredi <miklos@szeredi.hu>,
linux-f2fs-devel@lists.sourceforge.net,
Benjamin Coddington <bcodding@redhat.com>,
linux-integrity@vger.kernel.org,
Martin Brandenburg <martin@omnibond.com>,
Chris Mason <clm@fb.com>,
linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org,
Jonathan Corbet <corbet@lwn.net>,
Vyacheslav Dubeyko <slava@dubeyko.com>,
Allison Henderson <allison.henderson@oracle.com>,
Ilya Dryomov <idryomov@gmail.com>,
linux-ext4@vger.kernel.org, Stephen Smalley <sds@tycho.nsa.gov>,
Serge Hallyn <serge@hallyn.com>,
Gao Xiang <gaoxiang25@huawei.com>,
Eric Paris <eparis@parisplace.org>,
ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-mm@kvack.org, samba-technical@lists.samba.org,
linux-xfs@vger.kernel.org, Bob Peterson <rpeterso@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>,
ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net,
Jan Kara <jack@suse.cz>, Eric Biggers <ebiggers@google.com>,
Dominique Martinet <asmadeus@codewreck.org>,
Adrian Hunter <adrian.hunter@intel.com>,
David Howells <dhowells@redhat.com>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
devel@driverdev.osuosl.org,
"J. Bruce Fields" <bfields@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
Sage Weil <sage@redhat.com>, Richard Weinberger <richard@nod.at>,
Mark Fasheh <mark@fasheh.com>,
cluster-devel@redhat.com, Steve French <sfrench@samba.org>,
v9fs-developer@lists.sourceforge.net,
Bharath Vedartham <linux.bhar@gmail.com>,
Jann Horn <jannh@google.com>,
ecryptfs@vger.kernel.org, Josef Bacik <josef@toxicpanda.com>,
Dave Chinner <dchinner@redhat.com>,
David Sterba <dsterba@suse.com>,
Artem Bityutskiy <dedekind1@gmail.com>,
netdev@vger.kernel.org, linux-unionfs@vger.kernel.org,
stable@vger.kernel.org, Tyler Hicks <tyhicks@canonical.com>,
linux-security-module@vger.kernel.org,
Phillip Lougher <phillip@squashfs.org.uk>,
David Woodhouse <dwmw2@infradead.org>,
linux-btrfs@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr
Date: Wed, 28 Aug 2019 07:40:15 -0700 [thread overview]
Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> (raw)
In-Reply-To: <20190828142423.GA1955@infradead.org>
On 8/28/19 7:24 AM, Christoph Hellwig wrote:
> On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote:
>> Replace arguments for get and set xattr methods, and __vfs_getxattr
>> and __vfs_setaxtr functions with a reference to the following now
>> common argument structure:
> Yikes. That looks like a mess. Why can't we pass a kernel-only
> flag in the existing flags field for ₋>set and add a flags field
> to ->get? Passing methods by structure always tends to be a mess.
This was a response to GregKH@ criticism, an earlier patch set just
added a flag as you stated to get method, until complaints of an
excessively long argument list and fragility to add or change more
arguments.
So many ways have been tried to skin this cat ... the risk was taken to
please some, and we now have hundreds of stakeholders, when the first
patch set was less than a dozen. A recipe for failure?
-- Mark
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salyzyn <salyzyn@android.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
Jan Kara <jack@suse.cz>, Stephen Smalley <sds@tycho.nsa.gov>,
linux-security-module@vger.kernel.org, stable@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>,
Gao Xiang <gaoxiang25@huawei.com>, Chao Yu <yuchao0@huawei.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
David Howells <dhowells@redhat.com>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>, Jeff Layton <jlayton@kernel.org>,
Sage Weil <sage@redhat.com>, Ilya Dryomov <idryomov@gmail.com>,
Steve French <sfrench@samba.org>,
Tyler Hicks <tyhicks@canonical.com>, Jan Kara <jack@suse.com>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>,
Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Richard Weinberger <richard@nod.at>,
Dave Kleikamp <shaggy@kernel.org>, Tejun Heo <tj@kernel.org>,
Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
Joseph Qi <joseph.qi@linux.alibaba.com>,
Mike Marshall <hubcap@omnibond.com>,
Martin Brandenburg <martin@omnibond.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Phillip Lougher <phillip@squashfs.org.uk>,
Artem Bityutskiy <dedekind1@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Hugh Dickins <hughd@google.com>,
"David S. Miller" <davem@davemloft.net>,
Serge Hallyn <serge@hallyn.com>, James Morris <jmorris@namei.org>,
Mimi Zohar <zohar@linux.ibm.com>,
Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@parisplace.org>,
Casey Schaufler <casey@schaufler-ca.com>,
"J. Bruce Fields" <bfields@redhat.com>,
Eric Biggers <ebiggers@google.com>,
Benjamin Coddington <bcodding@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mathieu Malaterre <malat@debian.org>,
Vyacheslav Dubeyko <slava@dubeyko.com>,
Bharath Vedartham <linux.bhar@gmail.com>,
Jann Horn <jannh@google.com>, Dave Chinner <dchinner@redhat.com>,
Allison Henderson <allison.henderson@oracle.com>,
Brian Foster <bfoster@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>,
linux-doc@vger.kernel.org, linux-erofs@lists.ozlabs.org,
devel@driverdev.osuosl.org, v9fs-developer@lists.sourceforge.net,
linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, ecryptfs@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
linux-mtd@lists.infradead.org,
jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org,
ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org,
linux-unionfs@vger.kernel.org, reiserfs-devel@vger.kernel.org,
linux-mm@kvack.org, netdev@vger.kernel.org,
linux-integrity@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr
Date: Wed, 28 Aug 2019 07:40:15 -0700 [thread overview]
Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> (raw)
In-Reply-To: <20190828142423.GA1955@infradead.org>
On 8/28/19 7:24 AM, Christoph Hellwig wrote:
> On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote:
>> Replace arguments for get and set xattr methods, and __vfs_getxattr
>> and __vfs_setaxtr functions with a reference to the following now
>> common argument structure:
> Yikes. That looks like a mess. Why can't we pass a kernel-only
> flag in the existing flags field for ₋>set and add a flags field
> to ->get? Passing methods by structure always tends to be a mess.
This was a response to GregKH@ criticism, an earlier patch set just
added a flag as you stated to get method, until complaints of an
excessively long argument list and fragility to add or change more
arguments.
So many ways have been tried to skin this cat ... the risk was taken to
please some, and we now have hundreds of stakeholders, when the first
patch set was less than a dozen. A recipe for failure?
-- Mark
next prev parent reply other threads:[~2019-08-28 14:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 15:05 [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr Mark Salyzyn via Linux-f2fs-devel
2019-08-27 15:05 ` Mark Salyzyn
2019-08-27 15:05 ` Mark Salyzyn
2019-08-27 15:05 ` [f2fs-dev] " Mark Salyzyn via Linux-f2fs-devel
2019-08-27 15:05 ` Mark Salyzyn via Linux-erofs
2019-08-27 15:05 ` [Cluster-devel] " Mark Salyzyn
2019-08-27 15:49 ` Jeff Layton
2019-08-27 15:49 ` Jeff Layton
2019-08-27 15:49 ` Jeff Layton
2019-08-27 15:49 ` [f2fs-dev] " Jeff Layton
2019-08-27 15:49 ` Jeff Layton
2019-08-27 15:49 ` [Cluster-devel] " Jeff Layton
2019-08-27 17:06 ` [Ocfs2-devel] " David Sterba
2019-08-27 17:07 ` David Sterba
2019-08-27 17:07 ` David Sterba
2019-08-27 17:07 ` [f2fs-dev] " David Sterba
2019-08-27 17:07 ` David Sterba
2019-08-27 17:07 ` [Cluster-devel] " David Sterba
2019-08-27 17:07 ` David Sterba
2019-08-27 21:35 ` Darrick J. Wong
2019-08-27 21:36 ` [Ocfs2-devel] " Darrick J. Wong
2019-08-27 21:35 ` Darrick J. Wong
2019-08-27 21:35 ` Darrick J. Wong
2019-08-27 21:35 ` [f2fs-dev] " Darrick J. Wong
2019-08-27 21:35 ` Darrick J. Wong
2019-08-27 21:35 ` [Cluster-devel] " Darrick J. Wong
2019-08-28 14:24 ` Christoph Hellwig
2019-08-28 14:26 ` [Ocfs2-devel] " Christoph Hellwig
2019-08-28 14:24 ` Christoph Hellwig
2019-08-28 14:24 ` Christoph Hellwig
2019-08-28 14:24 ` [f2fs-dev] " Christoph Hellwig
2019-08-28 14:24 ` Christoph Hellwig
2019-08-28 14:24 ` Christoph Hellwig
2019-08-28 14:24 ` [Cluster-devel] " Christoph Hellwig
2019-08-28 14:40 ` Mark Salyzyn via Linux-f2fs-devel [this message]
2019-08-28 14:40 ` Mark Salyzyn
2019-08-28 14:40 ` Mark Salyzyn
2019-08-28 14:40 ` [f2fs-dev] " Mark Salyzyn via Linux-f2fs-devel
2019-08-28 14:40 ` Mark Salyzyn via Linux-erofs
2019-08-28 14:40 ` Mark Salyzyn via Linux-f2fs-devel
2019-08-28 14:40 ` [Cluster-devel] " Mark Salyzyn
2019-08-30 1:24 ` Mike Marshall
2019-08-30 1:24 ` Mike Marshall
2019-08-30 1:24 ` Mike Marshall
2019-08-30 1:24 ` [f2fs-dev] " Mike Marshall
2019-08-30 1:24 ` Mike Marshall
2019-08-30 1:24 ` Mike Marshall
2019-08-30 1:24 ` [Cluster-devel] " Mike Marshall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=anna.schumaker@netapp.com \
--cc=casey@schaufler-ca.com \
--cc=darrick.wong@oracle.com \
--cc=devel@lists.orangefs.org \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hubcap@omnibond.com \
--cc=hughd@google.com \
--cc=jack@suse.com \
--cc=jlayton@kernel.org \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=kernel-team@android.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=malat@debian.org \
--cc=paul@paul-moore.com \
--cc=salyzyn@android.com \
--cc=sandeen@sandeen.net \
--cc=selinux@vger.kernel.o \
--cc=shaggy@kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.