All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v5 3/8] ath10k: change max RX bundle size from 8 to 32 for sdio
Date: Tue, 24 Sep 2019 17:32:25 +0800	[thread overview]
Message-ID: <5f2387dc4c97a5edff78fa6ce7dcd401@codeaurora.org> (raw)
In-Reply-To: <871rw79ycy.fsf@codeaurora.org>

On 2019-09-23 17:05, Kalle Valo wrote:

>> 
>> +#define ATH10K_HTC_FLAG_BUNDLE_MASK 0xF0
>> +#define ATH10K_HTC_BUNDLE_EXTRA_MASK GENMASK(3, 2)
>> +
>> +#define ATH10K_HTC_GET_BUNDLE_COUNT(flags) \
>> +	    (FIELD_GET(ATH10K_HTC_FLAG_BUNDLE_MASK, (flags)) +  \
>> +	    (FIELD_GET(ATH10K_HTC_BUNDLE_EXTRA_MASK, (flags)) << 4))
> 
> When using FIELD_GET() there should be no need to use '<<', the main id
> of FIELD_GET() and BITMASK() is that there's no need do any manual
> shifting. So I suspect something is wrong here, but didn't have time to
> investigate.
the value is like this:
the u8 flags:
b7 b6 b5 b4 b3 b2 b1 b0
the count= 0Bb7b6b5b4 + 0Bb3b2 << 4
FIELD_GET is to >>, not <<
so it need to manual shift for the "0Bb3b2 << 4"

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5 3/8] ath10k: change max RX bundle size from 8 to 32 for sdio
Date: Tue, 24 Sep 2019 17:32:25 +0800	[thread overview]
Message-ID: <5f2387dc4c97a5edff78fa6ce7dcd401@codeaurora.org> (raw)
In-Reply-To: <871rw79ycy.fsf@codeaurora.org>

On 2019-09-23 17:05, Kalle Valo wrote:

>> 
>> +#define ATH10K_HTC_FLAG_BUNDLE_MASK 0xF0
>> +#define ATH10K_HTC_BUNDLE_EXTRA_MASK GENMASK(3, 2)
>> +
>> +#define ATH10K_HTC_GET_BUNDLE_COUNT(flags) \
>> +	    (FIELD_GET(ATH10K_HTC_FLAG_BUNDLE_MASK, (flags)) +  \
>> +	    (FIELD_GET(ATH10K_HTC_BUNDLE_EXTRA_MASK, (flags)) << 4))
> 
> When using FIELD_GET() there should be no need to use '<<', the main id
> of FIELD_GET() and BITMASK() is that there's no need do any manual
> shifting. So I suspect something is wrong here, but didn't have time to
> investigate.
the value is like this:
the u8 flags:
b7 b6 b5 b4 b3 b2 b1 b0
the count= 0Bb7b6b5b4 + 0Bb3b2 << 4
FIELD_GET is to >>, not <<
so it need to manual shift for the "0Bb3b2 << 4"

  reply	other threads:[~2019-09-24  9:32 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 10:38 [PATCH v5 0/8] ath10k: improve throughout of tcp/udp TX/RX of sdio Wen Gong
2019-09-05 10:38 ` Wen Gong
2019-09-05 10:38 ` [PATCH v5 1/8] ath10k: adjust skb length in ath10k_sdio_mbox_rx_packet Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-12 13:46   ` Kalle Valo
2019-09-12 13:46     ` Kalle Valo
2019-09-12 14:02     ` Nicolas Boichat
2019-09-12 14:02       ` Nicolas Boichat
2019-09-12 14:54   ` Kalle Valo
2019-09-12 14:54   ` Kalle Valo
2019-09-05 10:38 ` [PATCH v5 2/8] ath10k: enable RX bundle receive for sdio Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-21 12:15   ` Kalle Valo
2019-09-21 12:15     ` Kalle Valo
2019-09-05 10:38 ` [PATCH v5 3/8] ath10k: change max RX bundle size from 8 to 32 " Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-23  9:05   ` Kalle Valo
2019-09-23  9:05     ` Kalle Valo
2019-09-24  9:32     ` Wen Gong [this message]
2019-09-24  9:32       ` Wen Gong
2019-09-05 10:38 ` [PATCH v5 4/8] ath10k: add workqueue for RX path of sdio Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-23  9:49   ` Kalle Valo
2019-09-23  9:49     ` Kalle Valo
2019-09-05 10:38 ` [PATCH v5 5/8] ath10k: disable TX complete indication of htt for sdio Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-21 12:02   ` Kalle Valo
2019-09-21 12:02     ` Kalle Valo
2019-09-05 10:38 ` [PATCH v5 6/8] ath10k: add htt TX bundle " Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-05 10:38 ` [PATCH v5 7/8] ath10k: enable alt data of TX path " Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-05 10:38 ` [PATCH v5 8/8] ath10k: enable napi on RX " Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-23  9:22   ` Kalle Valo
2019-09-23  9:22     ` Kalle Valo
2019-09-12 15:39 ` [PATCH v5 0/8] ath10k: improve throughout of tcp/udp TX/RX of sdio Kalle Valo
2019-09-12 15:39   ` Kalle Valo
2019-09-12 17:51   ` Kalle Valo
2019-09-12 17:51     ` Kalle Valo
2019-09-13  3:54     ` Wen Gong
2019-09-13  3:54       ` Wen Gong
2019-09-20 12:44       ` Kalle Valo
2019-09-20 12:44         ` Kalle Valo
2019-09-23  9:29 ` Kalle Valo
2019-09-23  9:29   ` Kalle Valo
2019-09-24 12:32   ` Wen Gong
2019-09-24 12:32     ` Wen Gong
2019-09-26  2:33     ` Wen Gong
2019-09-26  2:33       ` Wen Gong
2019-10-14 11:53       ` Wen Gong
2019-10-14 11:53         ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f2387dc4c97a5edff78fa6ce7dcd401@codeaurora.org \
    --to=wgong@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.