All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v5 5/8] ath10k: disable TX complete indication of htt for sdio
Date: Sat, 21 Sep 2019 15:02:28 +0300	[thread overview]
Message-ID: <87v9tlamcr.fsf@codeaurora.org> (raw)
In-Reply-To: <1567679893-14029-6-git-send-email-wgong@codeaurora.org> (Wen Gong's message of "Thu, 5 Sep 2019 18:38:10 +0800")

Wen Gong <wgong@codeaurora.org> writes:

> Tx complete message from firmware cost bus bandwidth of sdio, and bus
> bandwidth is the bollteneck of throughput, it will effect the bandwidth
> occupancy of data packet of TX and RX.

TBH I'm not enthuastic about this, this feels an ugly hack. And it adds
yet another module parameter which I detest.

> This patch disable TX complete indication from firmware for htt data
> packet, it results in significant performance improvement on TX path.

So how much does this feature improve through exactly? Do you have any
numbers?

> The downside of this patch is ath10k will not know the TX status of
> the data packet for poor signal situation. Although upper network stack
> or application layer have retry mechanism, the retry will be later than
> ath10k get the TX fail status if not disable TX complete.

I don't understand this description. What's the difference in practise
from user's point of view?

But I think this patch should dropped from the patchset and revisited
after rest of the patches are applied.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v5 5/8] ath10k: disable TX complete indication of htt for sdio
Date: Sat, 21 Sep 2019 15:02:28 +0300	[thread overview]
Message-ID: <87v9tlamcr.fsf@codeaurora.org> (raw)
In-Reply-To: <1567679893-14029-6-git-send-email-wgong@codeaurora.org> (Wen Gong's message of "Thu, 5 Sep 2019 18:38:10 +0800")

Wen Gong <wgong@codeaurora.org> writes:

> Tx complete message from firmware cost bus bandwidth of sdio, and bus
> bandwidth is the bollteneck of throughput, it will effect the bandwidth
> occupancy of data packet of TX and RX.

TBH I'm not enthuastic about this, this feels an ugly hack. And it adds
yet another module parameter which I detest.

> This patch disable TX complete indication from firmware for htt data
> packet, it results in significant performance improvement on TX path.

So how much does this feature improve through exactly? Do you have any
numbers?

> The downside of this patch is ath10k will not know the TX status of
> the data packet for poor signal situation. Although upper network stack
> or application layer have retry mechanism, the retry will be later than
> ath10k get the TX fail status if not disable TX complete.

I don't understand this description. What's the difference in practise
from user's point of view?

But I think this patch should dropped from the patchset and revisited
after rest of the patches are applied.

-- 
Kalle Valo

  reply	other threads:[~2019-09-21 12:02 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-05 10:38 [PATCH v5 0/8] ath10k: improve throughout of tcp/udp TX/RX of sdio Wen Gong
2019-09-05 10:38 ` Wen Gong
2019-09-05 10:38 ` [PATCH v5 1/8] ath10k: adjust skb length in ath10k_sdio_mbox_rx_packet Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-12 13:46   ` Kalle Valo
2019-09-12 13:46     ` Kalle Valo
2019-09-12 14:02     ` Nicolas Boichat
2019-09-12 14:02       ` Nicolas Boichat
2019-09-12 14:54   ` Kalle Valo
2019-09-12 14:54   ` Kalle Valo
2019-09-05 10:38 ` [PATCH v5 2/8] ath10k: enable RX bundle receive for sdio Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-21 12:15   ` Kalle Valo
2019-09-21 12:15     ` Kalle Valo
2019-09-05 10:38 ` [PATCH v5 3/8] ath10k: change max RX bundle size from 8 to 32 " Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-23  9:05   ` Kalle Valo
2019-09-23  9:05     ` Kalle Valo
2019-09-24  9:32     ` Wen Gong
2019-09-24  9:32       ` Wen Gong
2019-09-05 10:38 ` [PATCH v5 4/8] ath10k: add workqueue for RX path of sdio Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-23  9:49   ` Kalle Valo
2019-09-23  9:49     ` Kalle Valo
2019-09-05 10:38 ` [PATCH v5 5/8] ath10k: disable TX complete indication of htt for sdio Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-21 12:02   ` Kalle Valo [this message]
2019-09-21 12:02     ` Kalle Valo
2019-09-05 10:38 ` [PATCH v5 6/8] ath10k: add htt TX bundle " Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-05 10:38 ` [PATCH v5 7/8] ath10k: enable alt data of TX path " Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-05 10:38 ` [PATCH v5 8/8] ath10k: enable napi on RX " Wen Gong
2019-09-05 10:38   ` Wen Gong
2019-09-23  9:22   ` Kalle Valo
2019-09-23  9:22     ` Kalle Valo
2019-09-12 15:39 ` [PATCH v5 0/8] ath10k: improve throughout of tcp/udp TX/RX of sdio Kalle Valo
2019-09-12 15:39   ` Kalle Valo
2019-09-12 17:51   ` Kalle Valo
2019-09-12 17:51     ` Kalle Valo
2019-09-13  3:54     ` Wen Gong
2019-09-13  3:54       ` Wen Gong
2019-09-20 12:44       ` Kalle Valo
2019-09-20 12:44         ` Kalle Valo
2019-09-23  9:29 ` Kalle Valo
2019-09-23  9:29   ` Kalle Valo
2019-09-24 12:32   ` Wen Gong
2019-09-24 12:32     ` Wen Gong
2019-09-26  2:33     ` Wen Gong
2019-09-26  2:33       ` Wen Gong
2019-10-14 11:53       ` Wen Gong
2019-10-14 11:53         ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9tlamcr.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.