RE: [PATCH V1 4/4] ALSA: hda/realtek: fix mic jack detect failed on alc256

[Kailang <kailang@realtek.com>]

[-- Attachment #1: Type: text/plain, Size: 3225 bytes --]


Maybe your platform need to set spec->en_3kpull_low to false.
If spec->en_3kpull_low = false will help you to get MIC JD.


> -----Original Message-----
> From: Joakim Zhang <joakim.zhang@cixtech.com>
> Sent: Wednesday, June 25, 2025 9:32 AM
> To: Kailang <kailang@realtek.com>; Takashi Iwai <tiwai@suse.de>
> Cc: perex@perex.cz; tiwai@suse.com; linux-sound@vger.kernel.org;
> chris.chiu@canonical.com; Geans_chen <geans_chen@realsil.com.cn>;
> cix-kernel-upstream <cix-kernel-upstream@cixtech.com>
> Subject: RE: [PATCH V1 4/4] ALSA: hda/realtek: fix mic jack detect failed on
> alc256
> 
> 
> External mail : This email originated from outside the organization. Do not
> reply, click links, or open attachments unless you recognize the sender and
> know the content is safe.
> 
> 
> 
> Hello Kailang
> 
> > -----Original Message-----
> > From: Kailang <kailang@realtek.com>
> > Sent: Tuesday, June 24, 2025 2:18 PM
> > To: Joakim Zhang <joakim.zhang@cixtech.com>; Takashi Iwai
> > <tiwai@suse.de>
> > Cc: perex@perex.cz; tiwai@suse.com; linux-sound@vger.kernel.org;
> > chris.chiu@canonical.com; Geans_chen <geans_chen@realsil.com.cn>; cix-
> > kernel-upstream <cix-kernel-upstream@cixtech.com>
> > Subject: RE: [PATCH V1 4/4] ALSA: hda/realtek: fix mic jack detect
> > failed on
> > alc256
> >
> >
> > > > +             if (codec->core.vendor_id == 0x10ec0256)
> > > > +                     spec->en_3kpull_low = false;
> >
> > This usage will affect all ALC256.
> >
> > Codec: Realtek ALC256
> > Address: 0
> > AFG Function Id: 0x1 (unsol 1)
> > Vendor Id: 0x10ec0256
> > Subsystem Id: 0x10ec0256   ==>  Could you assign this to 0x10EC129E ?
> This
> > codec SSID was provide from our AE. It's verb table.
> > Revision Id: 0x100002
> > No Modem Function Group found
> > Default PCM:
> >
> > We can check Subsystem Id to let spec->en_3kpull_low = false.
> 
> Did you find anything from the log? Is it a potential issue?
No, there were many platform need this setting.

> 
> You mean re-generate the verb table with SSID equal 0x10EC129E? But from
> the patch_realtek.c have not found any hook to fixup this SSID.
This SSID need add menually. Like attach patch.

> 
> 
> This email (including its attachments) is intended only for the person or entity
> to which it is addressed and may contain information that is privileged,
> confidential or otherwise protected from disclosure. Unauthorized use,
> dissemination, distribution or copying of this email or the information herein
> or taking any action in reliance on the contents of this email or the
> information herein, by anyone other than the intended recipient, or an
> employee or agent responsible for delivering the message to the intended
> recipient, is strictly prohibited. If you are not the intended recipient, please do
> not read, copy, use or disclose any part of this e-mail to others. Please notify
> the sender immediately and permanently delete this e-mail and any
> attachments if you received it in error. Internet communications cannot be
> guaranteed to be timely, secure, error-free or virus-free. The sender does not
> accept liability for any errors or omissions.

[-- Attachment #2: 0000-dis-3kpull-low.patch --]
[-- Type: application/octet-stream, Size: 1838 bytes --]

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 9108c712db03..066703838380 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7734,6 +7734,15 @@ static void alc283_fixup_dell_hp_resume(struct hda_codec *codec,
 		alc_write_coef_idx(codec, 0xd, 0x2800);
 }
 
+static void alc_fixup_3kpull_low(struct hda_codec *codec,
+				  const struct hda_fixup *fix, int action)
+{
+	struct alc_spec *spec = codec->spec;
+
+	if (action == HDA_FIXUP_ACT_PRE_PROBE)
+		spec->en_3kpull_low = false;
+}
+
 enum {
 	ALC269_FIXUP_GPIO2,
 	ALC269_FIXUP_SONY_VAIO,
@@ -8049,6 +8058,7 @@ enum {
 	ALC285_FIXUP_ASUS_GA605K_HEADSET_MIC,
 	ALC285_FIXUP_ASUS_GA605K_I2C_SPEAKER2_TO_DAC1,
 	ALC269_FIXUP_POSITIVO_P15X_HEADSET_MIC,
+	ALC256_FIXUP_DIS_3KPULL_LOW,
 };
 
 /* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -10463,6 +10473,10 @@ static const struct hda_fixup alc269_fixups[] = {
 		.chained = true,
 		.chain_id = ALC269VC_FIXUP_ACER_MIC_NO_PRESENCE,
 	},
+	[ALC256_FIXUP_DIS_3KPULL_LOW] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc_fixup_3kpull_low,
+	},
 };
 
 static const struct hda_quirk alc269_fixup_tbl[] = {
@@ -11128,6 +11142,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x10ec, 0x124c, "Intel Reference board", ALC295_FIXUP_CHROME_BOOK),
 	SND_PCI_QUIRK(0x10ec, 0x1252, "Intel Reference board", ALC295_FIXUP_CHROME_BOOK),
 	SND_PCI_QUIRK(0x10ec, 0x1254, "Intel Reference board", ALC295_FIXUP_CHROME_BOOK),
+	SND_PCI_QUIRK(0x10ec, 0x129e, "CIX Phecda Board", ALC256_FIXUP_DIS_3KPULL_LOW),
 	SND_PCI_QUIRK(0x10ec, 0x12cc, "Intel Reference board", ALC295_FIXUP_CHROME_BOOK),
 	SND_PCI_QUIRK(0x10ec, 0x12f6, "Intel Reference board", ALC295_FIXUP_CHROME_BOOK),
 	SND_PCI_QUIRK(0x10f7, 0x8338, "Panasonic CF-SZ6", ALC269_FIXUP_ASPIRE_HEADSET_MIC),