Re: [PATCH V1 3/4] ALSA: hda: disable jackpoll_in_suspend when system shutdown

[Takashi Iwai <tiwai@suse.de>]

On Thu, 19 Jun 2025 04:08:43 +0200,
joakim.zhang@cixtech.com wrote:
> 
> From: Joakim Zhang <joakim.zhang@cixtech.com>
> 
> When do reboot test, kernel panic when system shutdown since
> jackpoll delayed work tries to read registers via hda bus
> but the drivers are all shut down.
> 
> The root cause is that when system shutdown but codec may in
> runtime resume state, call runtime force suspend would trigger
> jackpoll delayed work active again, finally cause the kernel
> panic since it access registers with clocks/reset/power off.
> 
> Signed-off-by: Joakim Zhang <joakim.zhang@cixtech.com>
> ---
>  sound/pci/hda/hda_codec.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
> index 12caa5b2e678..e3424ac7b5a7 100644
> --- a/sound/pci/hda/hda_codec.c
> +++ b/sound/pci/hda/hda_codec.c
> @@ -3026,6 +3026,7 @@ void snd_hda_codec_shutdown(struct hda_codec *codec)
>  	list_for_each_entry(cpcm, &codec->pcm_list_head, list)
>  		snd_pcm_suspend_all(cpcm->pcm);
>  
> +	codec->bus->jackpoll_in_suspend = 0;
>  	pm_runtime_force_suspend(hda_codec_dev(codec));

This one should be better with codec->jackpoll_interval = 0, set
before cancel_work_sync().  Then it'll guarantee that the jackpoll
work won't be called any more.


thanks,

Takashi