Re: [PATCH V1 2/4] ALSA: hda: add no_pin_sense_update flag for jack detection

[Takashi Iwai <tiwai@suse.de>]

On Thu, 19 Jun 2025 04:08:42 +0200,
joakim.zhang@cixtech.com wrote:
> 
> From: Joakim Zhang <joakim.zhang@cixtech.com>
> 
> snd_hda_jack_detect_* functions should be called when want to
> detect then report jack status immediately, however it now called
> from other points such as patch_ops.init which just want to
> judge if the device is attached and no report behaviour.
> 
> Let take corner case into account:
> 1) device is de-attached before suspended, old pin sense is not present
> 2) attach the device when device in suspended
> 3) when codec resume back and the device is attached, it will update
>    pin sense as present from codec init function (patch_ops.init),
>    when it tries to read pin sense from jackpoll delayed work,
>    the old pin sense would be present (but actaully it is not present),
>    and the new pin sense also is present, so decides no changes, cause
>    the device cannot be detected.
> 
> Add no_pin_sense_update flag to control if we need update the pin
> sense when read the hardware pin sense.

I don't understand the situation well.  Do you mean "device" in the
steps 1/2/3 as a device to be connected to the jack, such as a
headphone, not the HD-audio codec device, right?

Even with that assumption, I still don't follow your logic fully...
Basically, when snd_hda_jack_report_sync() is called, this should
report the jack state changes.  I believe we should simply call
snd_hda_jack_report_sync() unconditionally, then schedule the jackpoll
work, as done in my PoC patch.


thanks,

Takashi