All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: jrodrigues <jrodrigues@ubimet.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)
Date: Sun, 29 Oct 2023 09:13:17 +0100	[thread overview]
Message-ID: <5f685552-4bbf-480a-b1d7-9573b554dcdc@linaro.org> (raw)
In-Reply-To: <20231027211548.21a6cee7@pcn112>

On 27/10/2023 21:15, jrodrigues wrote:
> 

1. Drop stray blank line
2. Please use scripts/get_maintainers.pl to get a list of necessary
people and lists to CC (and consider --no-git-fallback argument). It
might happen, that command when run on an older kernel, gives you
outdated entries. Therefore please be sure you base your patches on
recent Linux kernel.

Your patch will be ignored since you did not send it to anyone :(


> TQMa7x (revision 01xxx) uses a different (LM75A) temperature sensor.
> The two sensors use different I2C address, so we can set both sensors
> simultaneously.
> 
> Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> ---
>  arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> index fe42b0a468..b87560d037 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> @@ -128,7 +128,14 @@ vgen6_reg: vldo4 {
>  		};
>  	};
>  
> -	/* NXP SE97BTP with temperature sensor + eeprom */
> +	/* LM75A - temperature sensor, TQMa7x 01xx */
> +	lm75a: temperature-sensor@48 {
> +		compatible = "national,lm75a";
> +		reg = <0x48>;
> +		status = "okay";

Drop status.

> +	};
> +
> +	/* NXP SE97BTP with temperature sensor + eeprom, TQMa7x 02xx */
>  	se97b: temperature-sensor-eeprom@1e {
>  		compatible = "nxp,se97b", "jedec,jc-42.4-temp";
>  		reg = <0x1e>;
> --
> 
> The differences in the ICs are shown here:
> The TQMa7 manual only references the latest version
> https://www.tq-group.com/filedownloads/files/products/embedded/manuals/arm/embedded-modul/TQ-Socket/TQMa7x/TQMa7x.UM.0203.pdf
> in section 3.2.4, while the board manual
> https://www.tq-group.com/filedownloads/files/products/embedded/manuals/arm/carrierboard/MBa7x/MBa7x.UM.0101.pdf
> in section 4.1.2 references the old version, introduced by this patch.
> 
> I have tested this change in a board which uses the TQMa7x
> module, and with this patch we always a temperature sensors available.

This does not look like patch at all... Patches are created the easiest
with b4 or git format-patch.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: jrodrigues <jrodrigues@ubimet.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx)
Date: Sun, 29 Oct 2023 09:13:17 +0100	[thread overview]
Message-ID: <5f685552-4bbf-480a-b1d7-9573b554dcdc@linaro.org> (raw)
In-Reply-To: <20231027211548.21a6cee7@pcn112>

On 27/10/2023 21:15, jrodrigues wrote:
> 

1. Drop stray blank line
2. Please use scripts/get_maintainers.pl to get a list of necessary
people and lists to CC (and consider --no-git-fallback argument). It
might happen, that command when run on an older kernel, gives you
outdated entries. Therefore please be sure you base your patches on
recent Linux kernel.

Your patch will be ignored since you did not send it to anyone :(


> TQMa7x (revision 01xxx) uses a different (LM75A) temperature sensor.
> The two sensors use different I2C address, so we can set both sensors
> simultaneously.
> 
> Signed-off-by: João Rodrigues <jrodrigues@ubimet.com>
> ---
>  arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> index fe42b0a468..b87560d037 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx7-tqma7.dtsi
> @@ -128,7 +128,14 @@ vgen6_reg: vldo4 {
>  		};
>  	};
>  
> -	/* NXP SE97BTP with temperature sensor + eeprom */
> +	/* LM75A - temperature sensor, TQMa7x 01xx */
> +	lm75a: temperature-sensor@48 {
> +		compatible = "national,lm75a";
> +		reg = <0x48>;
> +		status = "okay";

Drop status.

> +	};
> +
> +	/* NXP SE97BTP with temperature sensor + eeprom, TQMa7x 02xx */
>  	se97b: temperature-sensor-eeprom@1e {
>  		compatible = "nxp,se97b", "jedec,jc-42.4-temp";
>  		reg = <0x1e>;
> --
> 
> The differences in the ICs are shown here:
> The TQMa7 manual only references the latest version
> https://www.tq-group.com/filedownloads/files/products/embedded/manuals/arm/embedded-modul/TQ-Socket/TQMa7x/TQMa7x.UM.0203.pdf
> in section 3.2.4, while the board manual
> https://www.tq-group.com/filedownloads/files/products/embedded/manuals/arm/carrierboard/MBa7x/MBa7x.UM.0101.pdf
> in section 4.1.2 references the old version, introduced by this patch.
> 
> I have tested this change in a board which uses the TQMa7x
> module, and with this patch we always a temperature sensors available.

This does not look like patch at all... Patches are created the easiest
with b4 or git format-patch.

Best regards,
Krzysztof


  reply	other threads:[~2023-10-29  8:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27 19:15 [PATCH] ARM: dts: imx: tqma7: add lm75a sensor (rev. 01xxx) jrodrigues
2023-10-27 19:15 ` jrodrigues
2023-10-27 19:15 ` jrodrigues
2023-10-29  8:13 ` Krzysztof Kozlowski [this message]
2023-10-29  8:13   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f685552-4bbf-480a-b1d7-9573b554dcdc@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jrodrigues@ubimet.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.