Re: [Qemu-devel] [PATCH v3 4/6] target/s390x: Implement LOAD PAIR DISJOINT

["Éric Bischoff" <ebischoff@nerim.net>]

Le mercredi 10 mai 2017, 12:16:20 Aurelien Jarno a écrit :
> > +    /* In a parallel context, stop the world and single step.  */
> > +    if (parallel_cpus) {
> > +        potential_page_fault(s);
> > +        gen_helper_exit_atomic(cpu_env);
> > +        return EXIT_NORETURN;
> > +    }
> 
> One small additional comment about this patch I haven't spotted at the
> first review. The exit_atomic helper is properly restoring the CPU state
> passing the return address to cpu_loop_exit_atomic, so I believe the
> potential_page_fault call is not necessary. That said, it doesn't hurt
> either.

Merci pour la relecture Aurélien.

Richard, what do we do? We remove the potential_page_fault(s); or not?


-- 
Éric Bischoff