From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linus.walleij@linaro.org, grant.likely@secretlab.ca,
horms@verge.net.au
Subject: Re: [PATCH 02/03] gpio: em: Setup gpiochip->dev
Date: Thu, 14 Nov 2013 00:08:14 +0000 [thread overview]
Message-ID: <6382126.xmUMBJLTFI@avalon> (raw)
In-Reply-To: <20131113225946.21449.68990.sendpatchset@w520>
Hi Magnus,
Thank you for the patch.
On Thursday 14 November 2013 07:59:46 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Make sure gpio_chip->dev is setup so of_gpiochip_add()
> will work as expected.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> drivers/gpio/gpio-em.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- 0001/drivers/gpio/gpio-em.c
> +++ work/drivers/gpio/gpio-em.c 2013-11-13 20:47:40.000000000 +0900
> @@ -327,6 +327,7 @@ static int em_gio_probe(struct platform_
> gpio_chip->request = em_gio_request;
> gpio_chip->free = em_gio_free;
> gpio_chip->label = name;
> + gpio_chip->dev = &pdev->dev;
> gpio_chip->owner = THIS_MODULE;
> gpio_chip->base = pdata->gpio_base;
> gpio_chip->ngpio = pdata->number_of_pins;
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linus.walleij@linaro.org, grant.likely@secretlab.ca,
horms@verge.net.au
Subject: Re: [PATCH 02/03] gpio: em: Setup gpiochip->dev
Date: Thu, 14 Nov 2013 01:08:14 +0100 [thread overview]
Message-ID: <6382126.xmUMBJLTFI@avalon> (raw)
In-Reply-To: <20131113225946.21449.68990.sendpatchset@w520>
Hi Magnus,
Thank you for the patch.
On Thursday 14 November 2013 07:59:46 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Make sure gpio_chip->dev is setup so of_gpiochip_add()
> will work as expected.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> drivers/gpio/gpio-em.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- 0001/drivers/gpio/gpio-em.c
> +++ work/drivers/gpio/gpio-em.c 2013-11-13 20:47:40.000000000 +0900
> @@ -327,6 +327,7 @@ static int em_gio_probe(struct platform_
> gpio_chip->request = em_gio_request;
> gpio_chip->free = em_gio_free;
> gpio_chip->label = name;
> + gpio_chip->dev = &pdev->dev;
> gpio_chip->owner = THIS_MODULE;
> gpio_chip->base = pdata->gpio_base;
> gpio_chip->ngpio = pdata->number_of_pins;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-11-14 0:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 22:59 [PATCH 00/03] gpio: R-Car and EM GPIO update Magnus Damm
2013-11-13 22:59 ` Magnus Damm
2013-11-13 22:59 ` [PATCH 01/03] gpio: rcar: Use lazy disable and mask on suspend Magnus Damm
2013-11-13 22:59 ` Magnus Damm
2013-11-14 0:07 ` Laurent Pinchart
2013-11-14 0:07 ` Laurent Pinchart
2013-11-14 2:03 ` Magnus Damm
2013-11-14 2:03 ` Magnus Damm
2013-11-14 2:17 ` Laurent Pinchart
2013-11-14 2:17 ` Laurent Pinchart
2013-11-14 8:50 ` Magnus Damm
2013-11-14 8:50 ` Magnus Damm
2013-11-14 14:57 ` Laurent Pinchart
2013-11-14 14:57 ` Laurent Pinchart
2013-11-13 22:59 ` [PATCH 02/03] gpio: em: Setup gpiochip->dev Magnus Damm
2013-11-13 22:59 ` Magnus Damm
2013-11-14 0:08 ` Laurent Pinchart [this message]
2013-11-14 0:08 ` Laurent Pinchart
2013-11-13 22:59 ` [PATCH 03/03] gpio: em: Use lazy disable and mask on suspend Magnus Damm
2013-11-13 22:59 ` Magnus Damm
2013-11-19 8:26 ` [PATCH 00/03] gpio: R-Car and EM GPIO update Linus Walleij
2013-11-19 8:26 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6382126.xmUMBJLTFI@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=grant.likely@secretlab.ca \
--cc=horms@verge.net.au \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.