From: Icenowy Zheng <icenowy@aosc.xyz>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Russell King <linux@armlinux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33
Date: Tue, 23 Aug 2016 14:50:32 +0800 [thread overview]
Message-ID: <652921471935032@web14j.yandex.ru> (raw)
In-Reply-To: <20160823064755.GA2598@lukather>
23.08.2016, 14:47, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> Hi,
>
> On Tue, Aug 23, 2016 at 01:58:25PM +0800, Icenowy Zheng wrote:
>> PG8, PG9 is said to be the CTS/RTS pins for UART1 according to the A23/33
>> datasheets. However, the function is wrongly named "uart2" in the pinctrl
>> driver. This patch fixes this by modifying them to be named "uart1".
>>
>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> This looks good, but could you send it to stable?
Yes... But currently in mainline kernel, no dt file for A23/33 uses UART1.
(Lots of the tablets is so low-end that they do not ship with BT support, and
then no support for extra UART is needed)
I found the problem when running mainline kernel on my iNet D978 Rev2 board
tablet. It come with a RTL8723BS.
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: icenowy@aosc.xyz (Icenowy Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33
Date: Tue, 23 Aug 2016 14:50:32 +0800 [thread overview]
Message-ID: <652921471935032@web14j.yandex.ru> (raw)
In-Reply-To: <20160823064755.GA2598@lukather>
23.08.2016, 14:47, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> Hi,
>
> On Tue, Aug 23, 2016 at 01:58:25PM +0800, Icenowy Zheng wrote:
>> ?PG8, PG9 is said to be the CTS/RTS pins for UART1 according to the A23/33
>> ?datasheets. However, the function is wrongly named "uart2" in the pinctrl
>> ?driver. This patch fixes this by modifying them to be named "uart1".
>>
>> ?Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> This looks good, but could you send it to stable?
Yes... But currently in mainline kernel, no dt file for A23/33 uses UART1.
(Lots of the tablets is so low-end that they do not ship with BT support, and
then no support for extra UART is needed)
I found the problem when running mainline kernel on my iNet D978 Rev2 board
tablet. It come with a RTL8723BS.
>
> Thanks,
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
next prev parent reply other threads:[~2016-08-23 6:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 5:58 [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33 Icenowy Zheng
2016-08-23 5:58 ` Icenowy Zheng
2016-08-23 5:58 ` [PATCH 2/2] ARM: dts: sun8i: Add extra UART pinmux settings for A23/33 Icenowy Zheng
2016-08-23 5:58 ` Icenowy Zheng
2016-08-23 11:42 ` Maxime Ripard
2016-08-23 11:42 ` Maxime Ripard
2016-08-23 11:42 ` Maxime Ripard
2016-08-23 13:51 ` Icenowy Zheng
2016-08-23 13:51 ` Icenowy Zheng
2016-08-26 20:18 ` Maxime Ripard
2016-08-26 20:18 ` Maxime Ripard
2016-08-23 6:47 ` [PATCH 1/2] pinctrl: sunxi: fix uart1 CTS/RTS pins at PG on A23/A33 Maxime Ripard
2016-08-23 6:47 ` Maxime Ripard
2016-08-23 6:47 ` Maxime Ripard
2016-08-23 6:50 ` Icenowy Zheng [this message]
2016-08-23 6:50 ` Icenowy Zheng
2016-08-23 9:27 ` Linus Walleij
2016-08-23 9:27 ` Linus Walleij
2016-08-23 9:27 ` Linus Walleij
2016-08-23 9:54 ` Maxime Ripard
2016-08-23 9:54 ` Maxime Ripard
2016-08-23 9:54 ` Maxime Ripard
2016-08-23 10:29 ` Linus Walleij
2016-08-23 10:29 ` Linus Walleij
2016-08-23 10:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=652921471935032@web14j.yandex.ru \
--to=icenowy@aosc.xyz \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.