From: Damien Le Moal <dlemoal@kernel.org>
To: "Yu Kuai" <yukuai1@huaweicloud.com>,
"Csordás Hunor" <csordas.hunor@gmail.com>,
"Coly Li" <colyli@kernel.org>,
hch@lst.de
Cc: linux-block@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: Improper io_opt setting for md raid5
Date: Mon, 28 Jul 2025 11:41:30 +0900 [thread overview]
Message-ID: <655cb7e6-897a-4fab-a8ce-8832f2bc7274@kernel.org> (raw)
In-Reply-To: <6ab1be6e-380b-d4aa-dd71-f53373a66e29@huaweicloud.com>
On 7/28/25 9:55 AM, Yu Kuai wrote:
> Hi,
>
> 在 2025/07/28 8:39, Damien Le Moal 写道:
>> md setting its io_opt to 64K*number of drives in the array is strange... It
>> does not have to be that large since io_opt is an upper bound and not a "issue
>> that IO size for optimal performance". io_opt is simply a limit saying: if you
>> exceed that IO size, performance may suffer.
>>
>
> At least from Documentation, for raid arrays, multiple of io_opt is the
> prefereed io size to the optimal io performance, and for raid5, this is
> chunksize * data disks.
>
>> So a default of stride size x number of drives for the io_opt may be OK, but
>> that should be bound to some reasonable value. Furthermore, this is likely
>> suboptimal. I woulld think that setting the md array io_opt initially to
>> min(all drives io_opt) x number of drives would be a better default.
>
> For raid5, this is not ok, the value have to be chunksize * data disks,
> regardless of io_opt from member disks, otherwise raid5 have to issue
> additional IO from other disks to build xor data.
>
> For example:
>
> - write aligned chunksize to one disk, actually means read chunksize
> old xor data,then write chunksize data and chunksize new xor data.
> - write aligned chunksize * data disks, new xor data can be build
> directly without reading old xor data.
I understand all of that. But you missed my point: io_opt simply indicates an
upper bound for an IO size. If exceeded, performance may be degraded. This has
*nothing* to do with the io granularity, which for a RAID array should ideally
be equal to stride size x number of data disks.
This is the confusion here. md setting io_opt to stride x number of disks in
the array is simply not what io_opt is supposed to indicate.
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-07-28 2:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 15:56 Improper io_opt setting for md raid5 Coly Li
2025-07-15 16:51 ` Keith Busch
2025-07-15 17:28 ` Keith Busch
2025-07-16 7:26 ` Yu Kuai
2025-07-16 12:34 ` Coly Li
2025-07-27 10:50 ` Csordás Hunor
2025-07-28 0:39 ` Damien Le Moal
2025-07-28 0:55 ` Yu Kuai
2025-07-28 2:41 ` Damien Le Moal [this message]
2025-07-28 3:08 ` Yu Kuai
2025-07-28 3:49 ` Damien Le Moal
2025-07-28 7:14 ` Yu Kuai
2025-07-28 7:44 ` Damien Le Moal
2025-07-28 9:02 ` Yu Kuai
2025-07-29 4:23 ` Martin K. Petersen
2025-07-29 6:25 ` Yu Kuai
2025-07-29 22:02 ` Tony Battersby
2025-07-29 6:13 ` Hannes Reinecke
2025-07-29 6:29 ` Yu Kuai
2025-07-29 22:24 ` Keith Busch
2025-07-28 10:56 ` Csordás Hunor
2025-07-29 4:08 ` Martin K. Petersen
2025-07-29 3:53 ` Martin K. Petersen
2025-07-29 3:49 ` Martin K. Petersen
2025-07-29 4:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=655cb7e6-897a-4fab-a8ce-8832f2bc7274@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=colyli@kernel.org \
--cc=csordas.hunor@gmail.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.