* [PATCH 0/2] arm64: dts: hisilicon: hikey970-pmic: clean up PMIC nodes
@ 2023-11-30 17:56 ` Johan Hovold
0 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2023-11-30 17:56 UTC (permalink / raw)
To: Wei Xu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, Johan Hovold
When reviewing the various SPMI PMIC bindings, I noticed that several
examples were incorrect and misleading and could also use some cleanup.
This series cleans up the hisilicon hikey970 PMIC dtsi which appears to
have been used as the basis for some of the examples.
Note that the binding documents "hisilicon,hi6421v600-spmi" while the
devicetree and driver only uses and recognises "hisilicon,hi6421-spmi".
I'll leave that as is for now...
Johan
Johan Hovold (2):
arm64: dts: hisilicon: hikey970-pmic: fix regulator cells properties
arm64: dts: hisilicon: hikey970-pmic: clean up SPMI node
arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--
2.41.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] arm64: dts: hisilicon: hikey970-pmic: fix regulator cells properties
2023-11-30 17:56 ` Johan Hovold
@ 2023-11-30 17:56 ` Johan Hovold
-1 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2023-11-30 17:56 UTC (permalink / raw)
To: Wei Xu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, Johan Hovold
The Hi6421 PMIC regulator child nodes do not have unit addresses so drop
the incorrect '#address-cells' and '#size-cells' properties.
Fixes: 6219b20e1ecd ("arm64: dts: hisilicon: Add support for Hikey 970 PMIC")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
index 970047f2dabd..c06e011a6c3f 100644
--- a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
@@ -25,9 +25,6 @@ pmic: pmic@0 {
gpios = <&gpio28 0 0>;
regulators {
- #address-cells = <1>;
- #size-cells = <0>;
-
ldo3: ldo3 { /* HDMI */
regulator-name = "ldo3";
regulator-min-microvolt = <1500000>;
--
2.41.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 1/2] arm64: dts: hisilicon: hikey970-pmic: fix regulator cells properties
@ 2023-11-30 17:56 ` Johan Hovold
0 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2023-11-30 17:56 UTC (permalink / raw)
To: Wei Xu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, Johan Hovold
The Hi6421 PMIC regulator child nodes do not have unit addresses so drop
the incorrect '#address-cells' and '#size-cells' properties.
Fixes: 6219b20e1ecd ("arm64: dts: hisilicon: Add support for Hikey 970 PMIC")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
index 970047f2dabd..c06e011a6c3f 100644
--- a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
@@ -25,9 +25,6 @@ pmic: pmic@0 {
gpios = <&gpio28 0 0>;
regulators {
- #address-cells = <1>;
- #size-cells = <0>;
-
ldo3: ldo3 { /* HDMI */
regulator-name = "ldo3";
regulator-min-microvolt = <1500000>;
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm64: dts: hisilicon: hikey970-pmic: clean up SPMI node
2023-11-30 17:56 ` Johan Hovold
@ 2023-11-30 17:56 ` Johan Hovold
-1 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2023-11-30 17:56 UTC (permalink / raw)
To: Wei Xu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, Johan Hovold
Clean up the SPMI node by dropping the redundant status property and
moving the 'reg' property after 'compatible' for consistency.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
index c06e011a6c3f..299c4ab630e8 100644
--- a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
@@ -10,10 +10,9 @@
/ {
spmi: spmi@fff24000 {
compatible = "hisilicon,kirin970-spmi-controller";
+ reg = <0x0 0xfff24000 0x0 0x1000>;
#address-cells = <2>;
#size-cells = <0>;
- status = "okay";
- reg = <0x0 0xfff24000 0x0 0x1000>;
hisilicon,spmi-channel = <2>;
pmic: pmic@0 {
--
2.41.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/2] arm64: dts: hisilicon: hikey970-pmic: clean up SPMI node
@ 2023-11-30 17:56 ` Johan Hovold
0 siblings, 0 replies; 8+ messages in thread
From: Johan Hovold @ 2023-11-30 17:56 UTC (permalink / raw)
To: Wei Xu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, Johan Hovold
Clean up the SPMI node by dropping the redundant status property and
moving the 'reg' property after 'compatible' for consistency.
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
index c06e011a6c3f..299c4ab630e8 100644
--- a/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi
@@ -10,10 +10,9 @@
/ {
spmi: spmi@fff24000 {
compatible = "hisilicon,kirin970-spmi-controller";
+ reg = <0x0 0xfff24000 0x0 0x1000>;
#address-cells = <2>;
#size-cells = <0>;
- status = "okay";
- reg = <0x0 0xfff24000 0x0 0x1000>;
hisilicon,spmi-channel = <2>;
pmic: pmic@0 {
--
2.41.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] arm64: dts: hisilicon: hikey970-pmic: clean up PMIC nodes
2023-11-30 17:56 ` Johan Hovold
@ 2023-12-08 7:17 ` Wei Xu
-1 siblings, 0 replies; 8+ messages in thread
From: Wei Xu @ 2023-12-08 7:17 UTC (permalink / raw)
To: Johan Hovold
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, xuwei5
Hi Johan,
On 2023/12/1 1:56, Johan Hovold wrote:
> When reviewing the various SPMI PMIC bindings, I noticed that several
> examples were incorrect and misleading and could also use some cleanup.
>
> This series cleans up the hisilicon hikey970 PMIC dtsi which appears to
> have been used as the basis for some of the examples.
>
> Note that the binding documents "hisilicon,hi6421v600-spmi" while the
> devicetree and driver only uses and recognises "hisilicon,hi6421-spmi".
> I'll leave that as is for now...
>
> Johan
>
>
> Johan Hovold (2):
> arm64: dts: hisilicon: hikey970-pmic: fix regulator cells properties
> arm64: dts: hisilicon: hikey970-pmic: clean up SPMI node
>
> arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
Series applied to the HiSilicon arm64 dt tree as the binding part has been applied.
Thanks!
Best Regards,
Wei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] arm64: dts: hisilicon: hikey970-pmic: clean up PMIC nodes
@ 2023-12-08 7:17 ` Wei Xu
0 siblings, 0 replies; 8+ messages in thread
From: Wei Xu @ 2023-12-08 7:17 UTC (permalink / raw)
To: Johan Hovold
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel, xuwei5
Hi Johan,
On 2023/12/1 1:56, Johan Hovold wrote:
> When reviewing the various SPMI PMIC bindings, I noticed that several
> examples were incorrect and misleading and could also use some cleanup.
>
> This series cleans up the hisilicon hikey970 PMIC dtsi which appears to
> have been used as the basis for some of the examples.
>
> Note that the binding documents "hisilicon,hi6421v600-spmi" while the
> devicetree and driver only uses and recognises "hisilicon,hi6421-spmi".
> I'll leave that as is for now...
>
> Johan
>
>
> Johan Hovold (2):
> arm64: dts: hisilicon: hikey970-pmic: fix regulator cells properties
> arm64: dts: hisilicon: hikey970-pmic: clean up SPMI node
>
> arch/arm64/boot/dts/hisilicon/hikey970-pmic.dtsi | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
Series applied to the HiSilicon arm64 dt tree as the binding part has been applied.
Thanks!
Best Regards,
Wei
^ permalink raw reply [flat|nested] 8+ messages in thread