From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Mark Brown <broonie@kernel.org>, Jon Hunter <jonathanh@nvidia.com>
Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Edward Cragg <edward.cragg@codethink.co.uk>,
linux-tegra@vger.kernel.org, Dmitry Osipenko <digetx@gmail.com>
Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples
Date: Fri, 24 Jan 2020 17:03:07 +0000 [thread overview]
Message-ID: <666737c3-69c8-3bd1-e7d3-5c845fe09e60@codethink.co.uk> (raw)
In-Reply-To: <20200124170059.GB4918@sirena.org.uk>
On 24/01/2020 17:00, Mark Brown wrote:
> On Fri, Jan 24, 2020 at 04:56:41PM +0000, Jon Hunter wrote:
>
>> Yes that is going to be a problem. I assume that your codec wants a
>> 256*fs MCLK? Maybe in that case you are better off having the codec
>> drive the bit clock and fsync?
Would be lovely, but tegra i2s clock slave is still on the list
of things I have to get into the kernel (it doesn't work and no-one
in the kernel currently uses it...)
>> Is 24-bit critical to what you are doing?
>
>> Otherwise maybe we should drop the 24-bit support for now and just keep
>> 32-bit.
>
> Removing the support because one particular board has limited clocks
> isn't good - it'd be better to have components with clocking
> restrictions impose constraints as needed.
>
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel-81qHHgoATdFT9dQujB1mzip2UmYkHbXO@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Edward Cragg
<edward.cragg-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples
Date: Fri, 24 Jan 2020 17:03:07 +0000 [thread overview]
Message-ID: <666737c3-69c8-3bd1-e7d3-5c845fe09e60@codethink.co.uk> (raw)
In-Reply-To: <20200124170059.GB4918-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 24/01/2020 17:00, Mark Brown wrote:
> On Fri, Jan 24, 2020 at 04:56:41PM +0000, Jon Hunter wrote:
>
>> Yes that is going to be a problem. I assume that your codec wants a
>> 256*fs MCLK? Maybe in that case you are better off having the codec
>> drive the bit clock and fsync?
Would be lovely, but tegra i2s clock slave is still on the list
of things I have to get into the kernel (it doesn't work and no-one
in the kernel currently uses it...)
>> Is 24-bit critical to what you are doing?
>
>> Otherwise maybe we should drop the 24-bit support for now and just keep
>> 32-bit.
>
> Removing the support because one particular board has limited clocks
> isn't good - it'd be better to have components with clocking
> restrictions impose constraints as needed.
>
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
next prev parent reply other threads:[~2020-01-24 17:04 UTC|newest]
Thread overview: 182+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 15:48 [alsa-devel] tegra30 tdm audio support Ben Dooks
2019-10-18 15:48 ` Ben Dooks
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 1/7] ASoC: tegra: add a TDM configuration callback Ben Dooks
2019-10-18 15:48 ` Ben Dooks
2019-10-24 15:50 ` [alsa-devel] " Jon Hunter
2019-10-24 15:50 ` Jon Hunter
2019-10-25 10:12 ` [alsa-devel] Applied "ASoC: tegra: add a TDM configuration callback" to the asoc tree Mark Brown
2019-10-25 10:12 ` Mark Brown
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Ben Dooks
2019-10-18 15:48 ` Ben Dooks
2019-10-24 15:54 ` [alsa-devel] " Jon Hunter
2019-10-24 15:54 ` Jon Hunter
2019-10-25 10:12 ` [alsa-devel] Applied "ASoC: tegra: Allow 24bit and 32bit samples" to the asoc tree Mark Brown
2019-10-25 10:12 ` Mark Brown
2019-11-23 21:09 ` [alsa-devel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Dmitry Osipenko
2019-11-23 21:09 ` Dmitry Osipenko
2019-11-25 10:37 ` [alsa-devel] " Ben Dooks
2019-11-25 10:37 ` Ben Dooks
2019-11-25 17:22 ` [alsa-devel] " Dmitry Osipenko
2019-11-25 17:22 ` Dmitry Osipenko
2019-11-25 17:28 ` [alsa-devel] " Dmitry Osipenko
2019-11-25 17:28 ` Dmitry Osipenko
2019-12-19 21:21 ` [alsa-devel] " Dmitry Osipenko
2019-12-19 21:21 ` Dmitry Osipenko
2019-12-20 10:56 ` [alsa-devel] " Ben Dooks
2019-12-20 10:56 ` Ben Dooks
2019-12-20 11:30 ` [alsa-devel] " Jon Hunter
2019-12-20 11:30 ` Jon Hunter
2019-12-20 11:38 ` [alsa-devel] " Ben Dooks
2019-12-20 11:38 ` Ben Dooks
2019-12-20 13:57 ` [alsa-devel] " Jon Hunter
2019-12-20 13:57 ` Jon Hunter
2019-12-20 14:43 ` [alsa-devel] " Dmitry Osipenko
2019-12-20 14:43 ` Dmitry Osipenko
2019-12-20 14:56 ` [alsa-devel] " Ben Dooks
2019-12-20 14:56 ` Ben Dooks
2019-12-20 15:02 ` [alsa-devel] " Dmitry Osipenko
2019-12-20 15:02 ` Dmitry Osipenko
2019-12-20 15:25 ` [alsa-devel] " Ben Dooks
2019-12-20 15:25 ` Ben Dooks
2019-12-20 16:40 ` [alsa-devel] " Dmitry Osipenko
2019-12-20 16:40 ` Dmitry Osipenko
2019-12-20 17:06 ` [alsa-devel] " Ben Dooks
2019-12-20 17:06 ` Ben Dooks
2019-12-22 17:08 ` [alsa-devel] " Dmitry Osipenko
2019-12-22 17:08 ` Dmitry Osipenko
2020-01-05 0:04 ` [alsa-devel] " Ben Dooks
2020-01-05 0:04 ` Ben Dooks
2020-01-05 1:48 ` [alsa-devel] " Dmitry Osipenko
2020-01-05 1:48 ` Dmitry Osipenko
2020-01-05 10:53 ` [alsa-devel] " Ben Dooks
2020-01-05 10:53 ` Ben Dooks
2020-01-06 19:00 ` [alsa-devel] [Linux-kernel] " Ben Dooks
2020-01-06 19:00 ` Ben Dooks
2020-01-07 1:39 ` [alsa-devel] " Dmitry Osipenko
2020-01-07 1:39 ` Dmitry Osipenko
2020-01-08 11:37 ` [alsa-devel] " Jon Hunter
2020-01-08 11:37 ` Jon Hunter
2020-01-20 16:50 ` [alsa-devel] " Dmitry Osipenko
2020-01-20 16:50 ` Dmitry Osipenko
2020-01-20 17:36 ` [alsa-devel] " Ben Dooks
2020-01-20 17:36 ` Ben Dooks
2020-01-23 19:38 ` [alsa-devel] " Ben Dooks
2020-01-23 19:38 ` Ben Dooks
2020-01-23 21:59 ` Ben Dooks
2020-01-23 21:59 ` Ben Dooks
2020-01-23 22:11 ` Dmitry Osipenko
2020-01-23 22:11 ` Dmitry Osipenko
2020-01-24 4:31 ` Dmitry Osipenko
2020-01-24 4:31 ` Dmitry Osipenko
2020-01-24 16:56 ` Jon Hunter
2020-01-24 16:56 ` Jon Hunter
2020-01-24 17:00 ` Mark Brown
2020-01-24 17:00 ` Mark Brown
2020-01-24 17:03 ` Ben Dooks [this message]
2020-01-24 17:03 ` Ben Dooks
2020-01-24 16:50 ` Jon Hunter
2020-01-24 16:50 ` Jon Hunter
2020-01-24 17:00 ` Ben Dooks
2020-01-24 17:00 ` Ben Dooks
2020-01-28 7:49 ` Ricard Wanderlof
2020-01-28 7:49 ` Ricard Wanderlof
2020-01-24 17:06 ` Ben Dooks
2020-01-24 17:06 ` Ben Dooks
2020-01-27 19:20 ` Dmitry Osipenko
2020-01-27 19:20 ` Dmitry Osipenko
2020-01-27 19:23 ` Dmitry Osipenko
2020-01-27 19:23 ` Dmitry Osipenko
2020-01-28 8:59 ` Ben Dooks
2020-01-28 8:59 ` Ben Dooks
2020-01-28 13:19 ` [alsa-devel] " Jon Hunter
2020-01-28 13:19 ` Jon Hunter
2020-01-28 15:25 ` Dmitry Osipenko
2020-01-28 15:25 ` Dmitry Osipenko
2020-01-28 15:26 ` Mark Brown
2020-01-28 15:26 ` Mark Brown
2020-01-28 17:45 ` Dmitry Osipenko
2020-01-28 17:45 ` Dmitry Osipenko
2020-01-28 18:42 ` Jon Hunter
2020-01-28 18:42 ` Jon Hunter
2020-01-30 8:04 ` Ben Dooks
2020-01-30 8:04 ` Ben Dooks
2020-01-28 8:58 ` Ben Dooks
2020-01-28 8:58 ` Ben Dooks
2020-01-28 12:13 ` [alsa-devel] " Mark Brown
2020-01-28 12:13 ` Mark Brown
2020-01-28 17:42 ` Dmitry Osipenko
2020-01-28 17:42 ` Dmitry Osipenko
2020-01-28 18:19 ` Jon Hunter
2020-01-28 18:19 ` Jon Hunter
2020-01-29 0:17 ` Dmitry Osipenko
2020-01-29 0:17 ` Dmitry Osipenko
2020-01-30 8:05 ` [alsa-devel] (no subject) Ben Dooks
2020-01-30 8:05 ` Ben Dooks
2020-01-30 9:31 ` [alsa-devel] (no subject) Clemens Ladisch
2020-01-30 9:31 ` Clemens Ladisch
2020-01-30 9:39 ` [alsa-devel] " Ben Dooks
2020-01-30 9:39 ` Ben Dooks
2020-01-30 14:58 ` Clemens Ladisch
2020-01-30 14:58 ` Clemens Ladisch
2020-01-31 10:50 ` Ben Dooks
2020-01-31 10:50 ` Ben Dooks
2020-01-31 11:03 ` Clemens Ladisch
2020-01-31 11:03 ` Clemens Ladisch
2020-01-29 10:49 ` [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Jon Hunter
2020-01-29 10:49 ` Jon Hunter
2020-01-29 14:33 ` Jon Hunter
2020-01-29 14:33 ` Jon Hunter
2020-01-29 15:22 ` Dmitry Osipenko
2020-01-29 15:22 ` Dmitry Osipenko
2020-01-30 8:17 ` Ben Dooks
2020-01-30 8:17 ` Ben Dooks
2020-01-30 12:05 ` Jon Hunter
2020-01-30 12:05 ` Jon Hunter
2020-01-30 12:07 ` Ben Dooks
2020-01-30 12:07 ` Ben Dooks
2020-01-30 13:09 ` Jon Hunter
2020-01-30 13:09 ` Jon Hunter
2020-01-30 13:10 ` Mark Brown
2020-01-30 13:10 ` Mark Brown
2020-03-19 15:32 ` Ben Dooks
2020-03-19 15:32 ` Ben Dooks
2020-03-20 14:18 ` Dmitry Osipenko
2020-03-20 14:18 ` Dmitry Osipenko
2020-01-30 8:06 ` Ben Dooks
2020-01-30 8:06 ` Ben Dooks
2020-01-29 17:52 ` Ben Dooks
2020-01-29 17:52 ` Ben Dooks
2020-01-07 10:29 ` [alsa-devel] " Jon Hunter
2020-01-07 10:29 ` Jon Hunter
2020-01-07 10:35 ` [alsa-devel] " Ben Dooks
2020-01-07 10:35 ` Ben Dooks
2020-01-21 18:15 ` [alsa-devel] " Ben Dooks
2020-01-21 18:15 ` Ben Dooks
2020-01-21 18:54 ` Dmitry Osipenko
2020-01-21 18:54 ` Dmitry Osipenko
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 3/7] ASoC: tegra: i2s: Add support for more than 2 channels Ben Dooks
2019-10-18 15:48 ` Ben Dooks
2019-10-24 16:12 ` [alsa-devel] " Jon Hunter
2019-10-24 16:12 ` Jon Hunter
2019-10-24 19:18 ` [alsa-devel] " Mark Brown
2019-10-24 19:18 ` Mark Brown
2019-10-25 7:48 ` [alsa-devel] " Jon Hunter
2019-10-25 7:48 ` Jon Hunter
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 4/7] ASoC: tegra: disable rx_fifo after disable stream Ben Dooks
2019-10-18 15:48 ` Ben Dooks
2019-10-24 16:12 ` [alsa-devel] " Jon Hunter
2019-10-24 16:12 ` Jon Hunter
2019-10-25 10:12 ` [alsa-devel] Applied "ASoC: tegra: disable rx_fifo after disable stream" to the asoc tree Mark Brown
2019-10-25 10:12 ` Mark Brown
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 5/7] ASoC: tegra: set i2s_offset to 0 for tdm Ben Dooks
2019-10-18 15:48 ` Ben Dooks
2019-10-25 7:58 ` [alsa-devel] " Jon Hunter
2019-10-25 7:58 ` Jon Hunter
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 6/7] ASoC: tegra: config fifos on hw_param changes Ben Dooks
2019-10-18 15:48 ` Ben Dooks
2019-10-25 8:18 ` [alsa-devel] " Jon Hunter
2019-10-25 8:18 ` Jon Hunter
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 7/7] ASoC: tegra: take packing settings from the audio cif_config Ben Dooks
2019-10-18 15:48 ` Ben Dooks
2019-10-25 8:47 ` [alsa-devel] " Jon Hunter
2019-10-25 8:47 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=666737c3-69c8-3bd1-e7d3-5c845fe09e60@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=edward.cragg@codethink.co.uk \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.