From: Marek Vasut <marek.vasut@mailbox.org>
To: Adam Ford <aford173@gmail.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>
Cc: u-boot@lists.denx.de, Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
Paul Barker <paul.barker.ct@bp.renesas.com>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 7/8] arm64: renesas: Deduplicate board_early_init_f()
Date: Sat, 18 Jan 2025 08:59:24 +0100 [thread overview]
Message-ID: <69d26454-10d5-4c3e-89f3-a4a0843700d3@mailbox.org> (raw)
In-Reply-To: <CAHCN7xJ+T_m_MR0PuHNMyuMegFGykPp-CpS8sCX6EYb3ksvfRg@mail.gmail.com>
On 1/13/25 4:40 PM, Adam Ford wrote:
> On Sun, Jan 12, 2025 at 4:36 PM Marek Vasut
> <marek.vasut+renesas@mailbox.org> wrote:
>>
>> Introduce common weak board_early_init_f() in rcar64-common.c
>> which is the default implementation in case there is no other
>> board specific board_early_init_f(). Remove board_early_init_f()
>> from Salvator-X, ULCB and Draak boards where this function is
>> empty.
>
> Isn't there a config option to enable/disable board_early_init_f? If
> they are do-nothing functions, can the config option be disabled?
There is , but I am still on the fence whether it wouldn't be better to
remove it in favor of weak symbol, which would get optimized out. I
think it is more user friendly as user does not have to fiddle with any
config options, only fill in the non-weak symbol with content in their
board file and it automatically takes effect.
next prev parent reply other threads:[~2025-01-18 8:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 22:34 [PATCH 1/8] ARM: renesas: Rename board/renesas/rcar-common to board/renesas/common Marek Vasut
2025-01-12 22:34 ` [PATCH 2/8] ARM: renesas: Simplify board Makefiles Marek Vasut
2025-01-15 10:22 ` Quentin Schulz
2025-01-18 7:53 ` Marek Vasut
2025-01-12 22:34 ` [PATCH 3/8] ARM: renesas: Rename common/common.c to common/rcar64-common.c Marek Vasut
2025-01-15 10:27 ` Quentin Schulz
2025-01-18 8:03 ` Marek Vasut
2025-01-12 22:34 ` [PATCH 4/8] arm64: renesas: Drop unused code and clean up headers on R-Car D3 Draak Marek Vasut
2025-01-12 22:34 ` [PATCH 5/8] arm64: renesas: Drop unused code and clean up headers on Salvator-X boards Marek Vasut
2025-01-12 22:34 ` [PATCH 6/8] arm64: renesas: Drop unused code and clean up headers on ULCB boards Marek Vasut
2025-01-12 22:34 ` [PATCH 7/8] arm64: renesas: Deduplicate board_early_init_f() Marek Vasut
2025-01-13 15:40 ` Adam Ford
2025-01-18 7:59 ` Marek Vasut [this message]
2025-01-12 22:34 ` [PATCH 8/8] arm64: renesas: Deduplicate R-Car Gen3 and Gen4 SPL Marek Vasut
2025-01-15 10:34 ` Quentin Schulz
2025-01-18 7:56 ` Marek Vasut
2025-01-15 9:58 ` [PATCH 1/8] ARM: renesas: Rename board/renesas/rcar-common to board/renesas/common Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69d26454-10d5-4c3e-89f3-a4a0843700d3@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=aford173@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=iwamatsu@nigauri.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=paul.barker.ct@bp.renesas.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.