From: Quentin Schulz <quentin.schulz@cherry.de>
To: Marek Vasut <marek.vasut+renesas@mailbox.org>, u-boot@lists.denx.de
Cc: Adam Ford <aford173@gmail.com>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
Paul Barker <paul.barker.ct@bp.renesas.com>,
Simon Glass <sjg@chromium.org>, Tom Rini <trini@konsulko.com>
Subject: Re: [PATCH 1/8] ARM: renesas: Rename board/renesas/rcar-common to board/renesas/common
Date: Wed, 15 Jan 2025 10:58:29 +0100 [thread overview]
Message-ID: <b541c7ce-eb71-491d-acc9-a224617ba46a@cherry.de> (raw)
In-Reply-To: <20250112223528.179828-1-marek.vasut+renesas@mailbox.org>
Hi Marek,
On 1/12/25 11:34 PM, Marek Vasut wrote:
> Rename directory board/renesas/rcar-common to board/renesas/common and
> move files. This allows the build system to use HAVE_VENDOR_COMMON_LIB
> which automatically includes board/$(VENDOR)/common/Makefile . This is
Please mention this is NOT sufficient to make use of
HAVE_VENDOR_COMMON_LIB as board/renesas/common is missing a Makefile.
Something like:
This will allow the build system to use HAVE_VENDOR_COMMON_LIB once a
Makefile is added in a later commit. This mechanism automatically
includes board/$(VENDOR)/common/Makefile.
or something like that.
> a preparatory patch for board Makefile simplification. No functional
> change so far.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
The change is fine, but please make the commit log a bit less confusing
around the use of HAVE_VENDOR_COMMON_LIB in this commit.
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
prev parent reply other threads:[~2025-01-15 9:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-12 22:34 [PATCH 1/8] ARM: renesas: Rename board/renesas/rcar-common to board/renesas/common Marek Vasut
2025-01-12 22:34 ` [PATCH 2/8] ARM: renesas: Simplify board Makefiles Marek Vasut
2025-01-15 10:22 ` Quentin Schulz
2025-01-18 7:53 ` Marek Vasut
2025-01-12 22:34 ` [PATCH 3/8] ARM: renesas: Rename common/common.c to common/rcar64-common.c Marek Vasut
2025-01-15 10:27 ` Quentin Schulz
2025-01-18 8:03 ` Marek Vasut
2025-01-12 22:34 ` [PATCH 4/8] arm64: renesas: Drop unused code and clean up headers on R-Car D3 Draak Marek Vasut
2025-01-12 22:34 ` [PATCH 5/8] arm64: renesas: Drop unused code and clean up headers on Salvator-X boards Marek Vasut
2025-01-12 22:34 ` [PATCH 6/8] arm64: renesas: Drop unused code and clean up headers on ULCB boards Marek Vasut
2025-01-12 22:34 ` [PATCH 7/8] arm64: renesas: Deduplicate board_early_init_f() Marek Vasut
2025-01-13 15:40 ` Adam Ford
2025-01-18 7:59 ` Marek Vasut
2025-01-12 22:34 ` [PATCH 8/8] arm64: renesas: Deduplicate R-Car Gen3 and Gen4 SPL Marek Vasut
2025-01-15 10:34 ` Quentin Schulz
2025-01-18 7:56 ` Marek Vasut
2025-01-15 9:58 ` Quentin Schulz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b541c7ce-eb71-491d-acc9-a224617ba46a@cherry.de \
--to=quentin.schulz@cherry.de \
--cc=aford173@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=iwamatsu@nigauri.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=paul.barker.ct@bp.renesas.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.