* [BlueZ] avctp: Fix typo in comment which contradicts the conditional below
@ 2026-08-18 10:58 Bastien Nocera
2026-08-18 12:21 ` bluez.test.bot
0 siblings, 1 reply; 2+ messages in thread
From: Bastien Nocera @ 2026-08-18 10:58 UTC (permalink / raw)
To: linux-bluetooth
The comment says "If the request set a callback send it directly" but
checks for whether "the request did not set a callback" using
if (!func)
---
profiles/audio/avctp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c
index f20e08c00ac8..336511bf9612 100644
--- a/profiles/audio/avctp.c
+++ b/profiles/audio/avctp.c
@@ -1632,7 +1632,7 @@ static int avctp_send_req(struct avctp *session, uint8_t code,
if (control == NULL)
return -ENOTCONN;
- /* If the request set a callback send it directly */
+ /* If the request did not set a callback send it directly */
if (!func)
return avctp_send(session->control, -1, AVCTP_COMMAND,
code, subunit, opcode, operands, operand_count);
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [BlueZ] avctp: Fix typo in comment which contradicts the conditional below
2026-08-18 10:58 [BlueZ] avctp: Fix typo in comment which contradicts the conditional below Bastien Nocera
@ 2026-08-18 12:21 ` bluez.test.bot
0 siblings, 0 replies; 2+ messages in thread
From: bluez.test.bot @ 2026-08-18 12:21 UTC (permalink / raw)
To: linux-bluetooth, hadess
[-- Attachment #1: Type: text/plain, Size: 989 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1147758
---Test result---
Test Summary:
CheckPatch PASS 0.30 seconds
GitLint PASS 0.20 seconds
BuildEll PASS 20.88 seconds
BluezMake PASS 628.01 seconds
MakeCheck PASS 3.27 seconds
MakeDistcheck PASS 165.31 seconds
CheckValgrind PASS 168.89 seconds
CheckSmatch PASS 333.63 seconds
bluezmakeextell PASS 105.42 seconds
IncrementalBuild PASS 629.40 seconds
ScanBuild PASS 1011.35 seconds
https://github.com/bluez/bluez/pull/2411
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-18 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-18 10:58 [BlueZ] avctp: Fix typo in comment which contradicts the conditional below Bastien Nocera
2026-08-18 12:21 ` bluez.test.bot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.