From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
Tyrel Datwyler <tyreld@linux.ibm.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH v2] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work
Date: Mon, 3 Jun 2019 16:25:13 -0700 [thread overview]
Message-ID: <6fa1dd2e-676f-b12a-5bb6-e86f5c5628fa@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190603221941.65432-1-natechancellor@gmail.com>
On 06/03/2019 03:19 PM, Nathan Chancellor wrote:
> clang warns:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used
> uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
> case IBMVSCSI_HOST_ACTION_NONE:
> ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:6: note: uninitialized use occurs
> here
> if (rc) {
> ^~
>
> Initialize rc to zero in the case statements that clang mentions so that
> the atomic_set and dev_err statement don't trigger for them.
>
> Fixes: 035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")
> Link: https://github.com/ClangBuiltLinux/linux/issues/502
> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
Tyrel Datwyler <tyreld@linux.ibm.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: clang-built-linux@googlegroups.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work
Date: Mon, 3 Jun 2019 16:25:13 -0700 [thread overview]
Message-ID: <6fa1dd2e-676f-b12a-5bb6-e86f5c5628fa@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190603221941.65432-1-natechancellor@gmail.com>
On 06/03/2019 03:19 PM, Nathan Chancellor wrote:
> clang warns:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used
> uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
> case IBMVSCSI_HOST_ACTION_NONE:
> ^~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:6: note: uninitialized use occurs
> here
> if (rc) {
> ^~
>
> Initialize rc to zero in the case statements that clang mentions so that
> the atomic_set and dev_err statement don't trigger for them.
>
> Fixes: 035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")
> Link: https://github.com/ClangBuiltLinux/linux/issues/502
> Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com>
next prev parent reply other threads:[~2019-06-03 23:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 18:53 [PATCH] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work Nathan Chancellor
2019-05-31 18:53 ` Nathan Chancellor
2019-06-02 10:15 ` Michael Ellerman
2019-06-02 10:15 ` Michael Ellerman
2019-06-03 3:23 ` Nathan Chancellor
2019-06-03 3:23 ` Nathan Chancellor
2019-06-03 23:30 ` Tyrel Datwyler
2019-06-03 8:45 ` Christophe Leroy
2019-06-03 22:19 ` [PATCH v2] " Nathan Chancellor
2019-06-03 22:19 ` Nathan Chancellor
2019-06-03 23:25 ` Tyrel Datwyler [this message]
2019-06-03 23:25 ` Tyrel Datwyler
2019-06-03 23:34 ` Tyrel Datwyler
2019-06-03 23:34 ` Tyrel Datwyler
2019-06-03 23:35 ` Tyrel Datwyler
2019-06-03 23:35 ` Tyrel Datwyler
2019-06-03 23:44 ` [PATCH v3] " Nathan Chancellor
2019-06-03 23:44 ` Nathan Chancellor
2019-06-03 23:58 ` Tyrel Datwyler
2019-06-03 23:58 ` Tyrel Datwyler
2019-06-05 2:39 ` Martin K. Petersen
2019-06-05 2:39 ` Martin K. Petersen
2019-06-05 11:08 ` Michael Ellerman
2019-06-05 11:08 ` Michael Ellerman
2019-06-05 11:08 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fa1dd2e-676f-b12a-5bb6-e86f5c5628fa@linux.vnet.ibm.com \
--to=tyreld@linux.vnet.ibm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=natechancellor@gmail.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.