All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Tyrel Datwyler <tyreld@linux.ibm.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
	Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH v3] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work
Date: Tue, 04 Jun 2019 22:39:19 -0400	[thread overview]
Message-ID: <yq1ef48rc14.fsf@oracle.com> (raw)
In-Reply-To: <20190603234405.29600-1-natechancellor@gmail.com> (Nathan Chancellor's message of "Mon, 3 Jun 2019 16:44:06 -0700")


Nathan,

> clang warns:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used
> uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
>         case IBMVSCSI_HOST_ACTION_NONE:
>              ^~~~~~~~~~~~~~~~~~~~~~~~~

Applied to 5.3/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

WARNING: multiple messages have this Message-ID (diff)
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Tyrel Datwyler <tyreld@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work
Date: Tue, 04 Jun 2019 22:39:19 -0400	[thread overview]
Message-ID: <yq1ef48rc14.fsf@oracle.com> (raw)
In-Reply-To: <20190603234405.29600-1-natechancellor@gmail.com> (Nathan Chancellor's message of "Mon, 3 Jun 2019 16:44:06 -0700")


Nathan,

> clang warns:
>
> drivers/scsi/ibmvscsi/ibmvscsi.c:2126:7: warning: variable 'rc' is used
> uninitialized whenever switch case is taken [-Wsometimes-uninitialized]
>         case IBMVSCSI_HOST_ACTION_NONE:
>              ^~~~~~~~~~~~~~~~~~~~~~~~~

Applied to 5.3/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

  parent reply	other threads:[~2019-06-05  2:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-31 18:53 [PATCH] scsi: ibmvscsi: Don't use rc uninitialized in ibmvscsi_do_work Nathan Chancellor
2019-05-31 18:53 ` Nathan Chancellor
2019-06-02 10:15 ` Michael Ellerman
2019-06-02 10:15   ` Michael Ellerman
2019-06-03  3:23   ` Nathan Chancellor
2019-06-03  3:23     ` Nathan Chancellor
2019-06-03 23:30   ` Tyrel Datwyler
2019-06-03  8:45 ` Christophe Leroy
2019-06-03 22:19 ` [PATCH v2] " Nathan Chancellor
2019-06-03 22:19   ` Nathan Chancellor
2019-06-03 23:25   ` Tyrel Datwyler
2019-06-03 23:25     ` Tyrel Datwyler
2019-06-03 23:34     ` Tyrel Datwyler
2019-06-03 23:34       ` Tyrel Datwyler
2019-06-03 23:35       ` Tyrel Datwyler
2019-06-03 23:35         ` Tyrel Datwyler
2019-06-03 23:44   ` [PATCH v3] " Nathan Chancellor
2019-06-03 23:44     ` Nathan Chancellor
2019-06-03 23:58     ` Tyrel Datwyler
2019-06-03 23:58       ` Tyrel Datwyler
2019-06-05  2:39     ` Martin K. Petersen [this message]
2019-06-05  2:39       ` Martin K. Petersen
2019-06-05 11:08       ` Michael Ellerman
2019-06-05 11:08         ` Michael Ellerman
2019-06-05 11:08         ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1ef48rc14.fsf@oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=natechancellor@gmail.com \
    --cc=tyreld@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.