Re: [mtd:nand/next 11/31] drivers/mtd/nand/raw/cadence-nand-controller.c:1893:4: error: implicit declaration of function 'ioread64_rep' is invalid in C99

[Valentin Korenblit <vkorenblit@sequans.com>]

[-- Attachment #1: Type: text/plain, Size: 6445 bytes --]

Hi Miquel,

I see that x86_64 doesn't support readsq/writesq because of
CONFIG_GENERIC_IOMAP (I was building for arm64). However,
__raw_readq/writeq are available and there are a few drivers
using them.

Do you want me to re-implement readsq and writesq in Cadence
driver privately or do you suggest a different (cleaner) approach?

Thanks in advance,

Valentin

On 9/21/22 10:45, Valentin Korenblit wrote:
> Hi Miquel,
>
> I will take a look at it today.
>
> Best regards,
>
> Valentin
>
> On 9/21/22 10:40, Miquel Raynal wrote:
>> Hi Valentin,
>>
>> lkp(a)intel.com wrote on Wed, 21 Sep 2022 06:31:23 +0800:
>>
>>> tree: 
>>> https://secure-web.cisco.com/1Z7olKSJj_FWb335mmjHNiDM4FObh2m2Kr4CVmzRDX7-wZ9HzSUvxLN_OyF3NWS1vplF7quihKo97ocKqspSHS_xSUcBq7SoYyT4aiP0BVJtAGm55P1k9Mssa77KKPNUbAMyq4MzD4d9367IHSlU-8_Yma1xswyK72pByqojTDRaGeSLMcd3Efp9JB-7etBNOZ0Mq_7dqMyKuUwbZU8WIna-ZwHW_CCvS7DHXp86ZFUoRXPszt3szYeRa8qRCGcnf5H_LmZXUU46OcwE1MO85qwzYn-0jrSBK0Z0LnL63DxMcgpLBkIUBtTgPtqFi4eHLWI6u2BTdadLQdfQrkT7Ucrl1UbGhmfniZR7GvpQcpCslyPVbEPjQM94cygTmfnRfCQeEsIkB2SxIBR7D_XKq_8VDlmXBV1PuielMjqML7CbtTiWUZ8UQBcaHprmlKDYh/https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fmtd%2Flinux.git 
>>> nand/next
>>> head:   63de24fccb6b831be1abfe07292449105b467731
>>> commit: 7e7dc04774b18c0e42ce74aa3357021cda979674 [11/31] mtd: 
>>> rawnand: cadence: support 64-bit slave dma interface
>>> config: x86_64-randconfig-a001 
>>> (https://secure-web.cisco.com/10lsHqk23p4vjII4hdwyDVKjI5rVkWwyx1jI7f1QftDDRv-ChD7hGjvTtAOzKDcC5WNVJzgIOH_H5iX14jjNXRZmHnxAlNscjTbzSQ6XFgA__Gk-uZA21dWuP-k-xSOQmagW6OnnsvlbNvaj4z3B3-K10Mio7ZhaHmKpvXkuFnTkopDEFB_18jYwKBzqFH4HqK7OQs8z2ldAFAPyeS4pf2QB6gWtU7uw3_DM0Ffn22F7e6ErZ5TARWROXHEra3q8HTLL8YuuBtg-o98Lt_uo-p0lp_B50lGPRb1aotz73TGtcMPqacct_gweoopRth138iqcqhoKVUtwDmvi0Cq7MNEUW2I1SnlB7jl7mLNbp66sw2cCdqt_97tioK6I1NazsNUZ5gW4kuKFevcgnarV4Z8KOQtPXyyC6DReQJ9tBCH4yWC8IyYUQN0246z2s1lcb/https%3A%2F%2Fdownload.01.org%2F0day-ci%2Farchive%2F20220921%2F202209210641.MziHAbW7-lkp%40intel.com%2Fconfig)
>>> compiler: clang version 14.0.6 
>>> (https://secure-web.cisco.com/1hFQ6b9I5rEbgJTBrSNYQ96NB2HBZl-vFn04fAzzx9TgVr-ZI2Yh78eJSHuVIXXUt7Y0FAQd5Hc5WbfhA3fBv9CZgiR1tSFSEk-TlQ8fHqEzUsO6pKVxVbq9NwFv3zIICt7M0Kjt_xyFZFD_pLrl-IlgkdddvWWGkrs6AUXwLKqfCRKrb4d3tGsfDNMN5PTj2SDjwnXBrFFC92LBxjNU1cK3VajqDxJ99oVgNDlhaJTlmsv48TcpOVugnYTf9qpQh2gxoQj6RqjoY-a9YlMYKtGjubYGgVyv0t9begalDgEeHU-YYOgLRNChdYZn5_DcojgYxjgSVr65RzBDt782Jnk94SSMcI4RV9yETmRwpS6hyiQKXxW2iigxlisod4NqU34ctO3xUECSsxQEnHjkodp72aMWWF2IEUpnnnZ9kQHHldB5_qQNZ0jGyM2N-Yrgm/https%3A%2F%2Fgithub.com%2Fllvm%2Fllvm-project 
>>> f28c006a5895fc0e329fe15fead81e37457cb1d1)
>>> reproduce (this is a W=1 build):
>>>          wget 
>>> https://secure-web.cisco.com/1NixR8yM6cIQS7ncp2355n_85DjQ7PwQ8LJ4AtQRZ5vVAKsZUe2UDZW75tWk6nSotBZh4xXA4HlaBWc_XXiD5WNwEPEG6RIaFDZw7vpNSEO5UcrmnjqlejH8aJ6qBsNLGSi-9NxzBboH3tX2PFjnd751CP7XZNayy-jQeaodwkRS3qWaGdwnQI75u6_E2T4zhNUCwS5nxmh5GkTN7gk77lQoH89_EyptFbGvU1zk1cbCdMV_XS9aDfjH0SyloO_Je38ire_caQsnZbRi5lGRjczbhbhvlbgnsH5jS4q8kNgxMQcaYXxr57u-YhtX9Fqr3vJinftsYTt00wtexc4kdx2nUDuY1F1NNU_wT0OiH0MxuuzvAmazz1tjgwExi9D_KnHDu4cXnbfOyS_aEr3FPZIUvgJKbeJyvDpE6F1sRY4qrSO4dmuBRTQO3Ya4T-xTJ/https%3A%2F%2Fraw.githubusercontent.com%2Fintel%2Flkp-tests%2Fmaster%2Fsbin%2Fmake.cross 
>>> -O ~/bin/make.cross
>>>          chmod +x ~/bin/make.cross
>>>          # 
>>> https://secure-web.cisco.com/1GbV0WGD053fzgXwafNb9gIz6l_aVKdavZ9hBiGrxLQ4FuFGlfprHSkexNTIiRSf7WMRS2n0YEMNksbrqzajQre4UdkaGPrh-mUGZDWPWTD5X90ypVAk7Lt9t_5k2WBYPECGzW9U0HNMDgZqHuxMPZ1PnAguUNmw7TttND56Hvw6agQd0NzAboe1bcSg51IGYxLZXqDb1SSd__2WCkrAb5kNEcxMS8nKNrB55ZD111-UV3kZkzvEweSsciS0LOTa-OqYDUEeA0y94DhSOmjGqZpZXIU1ZA4mZ0_6hSkdmc1DF1sPrB2QiQ_E63CY9C-908GCmIGmrBZivyuRuxsuR0y9al38fKX8Zvmk9szy8afe36sGUpMoXijrPLUnPKmdV-2OCVj26sSaXKRtktrOsOI0b8esgEHuB1FxBHZjKxLCHONZecIdNO5B9mAUTu3UV/https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fmtd%2Flinux.git%2Fcommit%2F%3Fid%3D7e7dc04774b18c0e42ce74aa3357021cda979674
>>>          git remote add mtd 
>>> https://secure-web.cisco.com/1Z7olKSJj_FWb335mmjHNiDM4FObh2m2Kr4CVmzRDX7-wZ9HzSUvxLN_OyF3NWS1vplF7quihKo97ocKqspSHS_xSUcBq7SoYyT4aiP0BVJtAGm55P1k9Mssa77KKPNUbAMyq4MzD4d9367IHSlU-8_Yma1xswyK72pByqojTDRaGeSLMcd3Efp9JB-7etBNOZ0Mq_7dqMyKuUwbZU8WIna-ZwHW_CCvS7DHXp86ZFUoRXPszt3szYeRa8qRCGcnf5H_LmZXUU46OcwE1MO85qwzYn-0jrSBK0Z0LnL63DxMcgpLBkIUBtTgPtqFi4eHLWI6u2BTdadLQdfQrkT7Ucrl1UbGhmfniZR7GvpQcpCslyPVbEPjQM94cygTmfnRfCQeEsIkB2SxIBR7D_XKq_8VDlmXBV1PuielMjqML7CbtTiWUZ8UQBcaHprmlKDYh/https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fmtd%2Flinux.git
>>>          git fetch --no-tags mtd nand/next
>>>          git checkout 7e7dc04774b18c0e42ce74aa3357021cda979674
>>>          # save the config file
>>>          mkdir build_dir && cp config build_dir/.config
>>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross 
>>> W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/mtd/nand/raw/
>>>
>>> If you fix the issue, kindly add following tag where applicable
>>> | Reported-by: kernel test robot <lkp@intel.com>
>>>
>>> All errors (new ones prefixed by >>):
>>>
>>>>> drivers/mtd/nand/raw/cadence-nand-controller.c:1893:4: error: 
>>>>> implicit declaration of function 'ioread64_rep' is invalid in C99 
>>>>> [-Werror,-Wimplicit-function-declaration]
>>> ioread64_rep(cdns_ctrl->io.virt, buf, len_in_words);
>>>                             ^
>>>>> drivers/mtd/nand/raw/cadence-nand-controller.c:1962:4: error: 
>>>>> implicit declaration of function 'iowrite64_rep' is invalid in C99 
>>>>> [-Werror,-Wimplicit-function-declaration]
>>> iowrite64_rep(cdns_ctrl->io.virt, buf, len_in_words);
>>>                             ^
>>>     2 errors generated.
>> I've dropped your patch from nand/next, here you can check what's
>> missing in the configuration, should not be too hard to solve. Once
>> done, you can send a new version of the patch.
>>
>> Thanks,
>> Miquèl
>>
-- IMPORTANT NOTICE:



The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.



Thank you.

[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 12074 bytes --]