From: David Howells <dhowells@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Linux-Kernel List <linux-kernel@vger.kernel.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: spin_is_locked() broken for uniprocessor?
Date: Wed, 19 Aug 2009 10:38:06 +0100 [thread overview]
Message-ID: <7099.1250674686@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0908190022570.3361@localhost.localdomain>
Thomas Gleixner <tglx@linutronix.de> wrote:
> > which implies to me that spin_is_locked() will always return false. Is this
> > expected behavior.
>
> That's wrong. spin_is_locked should always return true on UP.
Surely it's not that simple? Maybe spin_is_lock() should be undefined on UP.
David
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: dhowells@redhat.com, Kumar Gala <galak@kernel.crashing.org>,
Peter Zijlstra <peterz@infradead.org>,
Linux-Kernel List <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: spin_is_locked() broken for uniprocessor?
Date: Wed, 19 Aug 2009 10:38:06 +0100 [thread overview]
Message-ID: <7099.1250674686@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0908190022570.3361@localhost.localdomain>
Thomas Gleixner <tglx@linutronix.de> wrote:
> > which implies to me that spin_is_locked() will always return false. Is this
> > expected behavior.
>
> That's wrong. spin_is_locked should always return true on UP.
Surely it's not that simple? Maybe spin_is_lock() should be undefined on UP.
David
next prev parent reply other threads:[~2009-08-19 9:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-18 22:09 spin_is_locked() broken for uniprocessor? Kumar Gala
2009-08-18 22:09 ` Kumar Gala
2009-08-18 22:24 ` Thomas Gleixner
2009-08-18 22:24 ` Thomas Gleixner
2009-08-19 9:38 ` David Howells [this message]
2009-08-19 9:38 ` David Howells
2009-08-19 9:41 ` Peter Zijlstra
2009-08-19 9:41 ` Peter Zijlstra
2009-08-27 9:32 ` Benjamin Herrenschmidt
2009-08-27 9:32 ` Benjamin Herrenschmidt
2009-08-19 10:53 ` Alan Cox
2009-08-19 10:53 ` Alan Cox
2009-08-19 11:16 ` Leon Woestenberg
2009-08-19 11:16 ` Leon Woestenberg
2009-08-19 11:23 ` Peter Zijlstra
2009-08-19 11:23 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7099.1250674686@redhat.com \
--to=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.