From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Use correct requested freq for SLPC
Date: Wed, 8 Mar 2023 10:52:41 +0000 [thread overview]
Message-ID: <70e694cd-45d0-7b98-b0d2-eebb15283239@linux.intel.com> (raw)
In-Reply-To: <87ilfbn6s0.wl-ashutosh.dixit@intel.com>
On 08/03/2023 05:36, Dixit, Ashutosh wrote:
> On Mon, 06 Mar 2023 03:10:24 -0800, Tvrtko Ursulin wrote:
>>
>
> Hi Tvrtko,
>
>> On 04/03/2023 01:27, Ashutosh Dixit wrote:
>>> SLPC does not use 'struct intel_rps'. Use UNSLICE_RATIO bits from
>>
>> Would it be more accurate to say 'SLPC does not use rps->cur_freq' rather
>> than it not using struct intel_rps?
>
> No actually SLPC maintains a separate 'struct intel_guc_slpc' and does not
> use 'struct intel_rps' at all so all of 'struct intel_rps' is 0.
I keep forgetting how there is zero code / data sharing with all this.. :(
>> Fixes: / stable ? CI chances of catching this?
>
> Same issue as Patch 1, I have answered this there.
Okay lets see it clarified there.
Regards,
Tvrtko
WARNING: multiple messages have this Message-ID (diff)
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 2/2] drm/i915/pmu: Use correct requested freq for SLPC
Date: Wed, 8 Mar 2023 10:52:41 +0000 [thread overview]
Message-ID: <70e694cd-45d0-7b98-b0d2-eebb15283239@linux.intel.com> (raw)
In-Reply-To: <87ilfbn6s0.wl-ashutosh.dixit@intel.com>
On 08/03/2023 05:36, Dixit, Ashutosh wrote:
> On Mon, 06 Mar 2023 03:10:24 -0800, Tvrtko Ursulin wrote:
>>
>
> Hi Tvrtko,
>
>> On 04/03/2023 01:27, Ashutosh Dixit wrote:
>>> SLPC does not use 'struct intel_rps'. Use UNSLICE_RATIO bits from
>>
>> Would it be more accurate to say 'SLPC does not use rps->cur_freq' rather
>> than it not using struct intel_rps?
>
> No actually SLPC maintains a separate 'struct intel_guc_slpc' and does not
> use 'struct intel_rps' at all so all of 'struct intel_rps' is 0.
I keep forgetting how there is zero code / data sharing with all this.. :(
>> Fixes: / stable ? CI chances of catching this?
>
> Same issue as Patch 1, I have answered this there.
Okay lets see it clarified there.
Regards,
Tvrtko
next prev parent reply other threads:[~2023-03-08 10:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 1:27 [Intel-gfx] [PATCH 0/2] drm/i915/pmu: Freq sampling: Fix requested freq fallback Ashutosh Dixit
2023-03-04 1:27 ` Ashutosh Dixit
2023-03-04 1:27 ` [Intel-gfx] [PATCH 1/2] drm/i915/pmu: Use only freq bits for falling back to requested freq Ashutosh Dixit
2023-03-04 1:27 ` Ashutosh Dixit
2023-03-06 11:04 ` [Intel-gfx] " Tvrtko Ursulin
2023-03-06 11:04 ` Tvrtko Ursulin
2023-03-08 5:36 ` [Intel-gfx] " Dixit, Ashutosh
2023-03-08 5:36 ` Dixit, Ashutosh
2023-03-08 10:40 ` [Intel-gfx] " Tvrtko Ursulin
2023-03-08 10:40 ` Tvrtko Ursulin
2023-03-04 1:27 ` [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Use correct requested freq for SLPC Ashutosh Dixit
2023-03-04 1:27 ` Ashutosh Dixit
2023-03-06 11:10 ` [Intel-gfx] " Tvrtko Ursulin
2023-03-06 11:10 ` Tvrtko Ursulin
2023-03-08 5:36 ` [Intel-gfx] " Dixit, Ashutosh
2023-03-08 5:36 ` Dixit, Ashutosh
2023-03-08 10:52 ` Tvrtko Ursulin [this message]
2023-03-08 10:52 ` Tvrtko Ursulin
2023-03-04 2:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Freq sampling: Fix requested freq fallback Patchwork
2023-03-06 22:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70e694cd-45d0-7b98-b0d2-eebb15283239@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.