Re: [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen

From: "Heiko Stübner" <heiko@sntech.de>
To: Peter Robinson <pbrobinson@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	Peter Geis <pgwipeout@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen
Date: Tue, 10 Jun 2025 13:15:19 +0200	[thread overview]
Message-ID: <7187768.GXAFRqVoOG@diego> (raw)
In-Reply-To: <78773d27-d815-4fac-a131-275bde51788d@kernel.org>

Am Dienstag, 10. Juni 2025, 12:48:50 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:
> On 10/06/2025 12:44, Krzysztof Kozlowski wrote:
> > On 18/05/2025 23:59, Peter Robinson wrote:
> >> The Pine64 touch panel is a panel consisting of the Feiyang fy07024di26a30d
> >> panel with a Goodix gt911 touch screen. Add a device tree overlay to
> >> allow the display to be easily used on the device.
> >>
> >> This was previously included in the main device tree but left disabled
> >> by default which still required rebuilding the DT to use the device, now
> >> overlays can go upstream the overlay is the best way to handle the
> >> add on devices.
> >>
> >> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> >> ---
> >>  arch/arm64/boot/dts/rockchip/Makefile         |  9 ++
> >>  .../dts/rockchip/rk3399-rockpro64-screen.dtso | 89 +++++++++++++++++++
> >>  2 files changed, 98 insertions(+)
> >>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> >> index 3e8771ef69ba1..c7b13bff3ac20 100644
> >> --- a/arch/arm64/boot/dts/rockchip/Makefile
> >> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> >> @@ -77,6 +77,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4c.dtb
> >>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb
> >>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-v2.dtb
> >>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb
> >> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtso
> > 
> > 
> > This was absolutely never built as reported by Naresh. You should never
> > sent patches which are at least built tested... although they should be
> > actually tested as well, but if code does not build actual testing is
> > impossible.
> 
> Huh, I was wrong - this actually builds, just cannot execute install target.

I did build it as well after applying - but still managed to overlook the dtso vs. dtbo
But I'm surprised that still built yesterday

I'll amend the commit for the dtso -> dtbo change.

Heiko