Re: [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen

From: "Diederik de Haas" <didi.debian@cknow.org>
To: "Peter Robinson" <pbrobinson@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-rockchip@lists.infradead.org>,
	"Peter Geis" <pgwipeout@gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add overlay for RockPro64 screen
Date: Tue, 10 Jun 2025 13:33:25 +0200	[thread overview]
Message-ID: <DAITK5IPG0QA.2EMB23KS83SBE@cknow.org> (raw)
In-Reply-To: <20250518215944.178582-2-pbrobinson@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2388 bytes --]

Hi,

On Sun May 18, 2025 at 11:59 PM CEST, Peter Robinson wrote:
> The Pine64 touch panel is a panel consisting of the Feiyang fy07024di26a30d
> panel with a Goodix gt911 touch screen. Add a device tree overlay to
> allow the display to be easily used on the device.
>
> This was previously included in the main device tree but left disabled
> by default which still required rebuilding the DT to use the device, now
> overlays can go upstream the overlay is the best way to handle the
> add on devices.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |  9 ++
>  .../dts/rockchip/rk3399-rockpro64-screen.dtso | 89 +++++++++++++++++++
>  2 files changed, 98 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 3e8771ef69ba1..c7b13bff3ac20 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -77,6 +77,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-pi-4c.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock960.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-v2.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtso

``s/rk3399-rockpro64-screen.dtso/rk3399-rockpro64-screen.dtbo``

Cheers,
  Diederik

>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb
> @@ -209,6 +210,14 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-puma-haikou-haikou-video-demo.dtb
>  rk3399-puma-haikou-haikou-video-demo-dtbs := rk3399-puma-haikou.dtb \
>  	rk3399-puma-haikou-video-demo.dtbo
>  
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtb
> +rk3399-rockpro64-screen-dtbs := rk3399-rockpro64.dtb \
> +	rk3399-rockpro64-screen.dtbo
> +
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rockpro64-screen.dtb
> +rk3399-rockpro64-v2-screen-dtbs := rk3399-rockpro64-v2.dtb \
> +	rk3399-rockpro64-screen.dtbo
> +
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-vz-2-uhd.dtb
>  rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \
>  	rk3568-wolfvision-pf5-display-vz.dtbo \
> <snip>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]