From: Dimitris Papavasiliou <dpapavas@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: Need help fixing pop/click artifacts in an ASOC driver
Date: Sat, 24 Nov 2018 22:17:49 +0200 [thread overview]
Message-ID: <724efe46-d604-0de1-caa2-efcfd7c91510@gmail.com> (raw)
In-Reply-To: <00b68fe8-403d-b129-1166-f414e5bd21ab@gmail.com>
I've submitted a patch for the pcm512x CODEC, that is relevant to
this problem. The patch implements the digital_mute interface,
suppressing various clicks and pops, including the loud pop under
discussion here. I still feel that fixing the machine driver, so
that it doesn't generate the pop at all would be desirable, as
I'm not sure whether the digital_mute callback is guaranteed to
have muted the device when the clock source takes place.
Does that sound reasonable, or would it be preferable to simply
rely on the digital_mute mechanism (assuming the patch is
acceptable)?
next prev parent reply other threads:[~2018-11-24 20:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 16:37 Need help fixing pop/click artifacts in an ASOC driver Dimitris Papavasiliou
2018-11-08 1:42 ` Pierre-Louis Bossart
2018-11-08 15:18 ` Takashi Iwai
2018-11-10 15:46 ` Dimitris Papavasiliou
2018-11-14 22:06 ` Mark Brown
2018-11-14 22:50 ` Dimitris Papavasiliou
2018-11-14 23:02 ` Mark Brown
2018-11-14 23:55 ` Dimitris Papavasiliou
2018-11-15 0:33 ` Mark Brown
2018-11-15 11:25 ` Dimitris Papavasiliou
2018-11-15 19:04 ` Mark Brown
2018-11-18 13:37 ` Dimitris Papavasiliou
2018-11-24 20:17 ` Dimitris Papavasiliou [this message]
2018-12-13 17:42 ` Mark Brown
2018-12-17 12:17 ` Dimitris Papavasiliou
2018-12-17 12:37 ` Mark Brown
2018-12-17 12:58 ` Dimitris Papavasiliou
2018-12-17 14:10 ` Mark Brown
2018-12-17 15:03 ` Dimitris Papavasiliou
2018-12-17 15:40 ` Mark Brown
2018-12-17 16:23 ` Dimitris Papavasiliou
2018-12-17 16:52 ` Mark Brown
2018-12-18 10:39 ` Dimitris Papavasiliou
2018-12-19 16:19 ` Mark Brown
2018-12-19 21:44 ` Dimitris Papavasiliou
2018-12-20 15:36 ` Mark Brown
2018-12-20 20:41 ` Dimitris Papavasiliou
2018-12-21 10:57 ` Mark Brown
2018-12-21 13:05 ` Dimitris Papavasiliou
2018-12-21 17:33 ` Mark Brown
2018-12-23 20:11 ` Dimitris Papavasiliou
2018-12-22 14:44 ` Matthias Reichl
2018-12-23 20:15 ` Dimitris Papavasiliou
2018-12-17 15:03 ` Pierre-Louis Bossart
2018-12-17 17:39 ` Mark Brown
2018-12-17 18:08 ` Pierre-Louis Bossart
2018-12-17 19:02 ` Mark Brown
2018-12-17 19:14 ` Pierre-Louis Bossart
2019-01-05 19:01 ` Pierre-Louis Bossart
2018-12-18 11:32 ` Dimitris Papavasiliou
2018-12-18 14:12 ` Pierre-Louis Bossart
2018-12-18 17:10 ` Dimitris Papavasiliou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=724efe46-d604-0de1-caa2-efcfd7c91510@gmail.com \
--to=dpapavas@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.