All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rudraksha Gupta <guptarud@gmail.com>
To: Diederik de Haas <didi.debian@cknow.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Ondrej Jirman" <megi@xff.cz>,
	"Martijn Braam" <martijn@brixit.nl>,
	"Kamil Trzciński" <ayufan@ayufan.eu>
Subject: Re: [PATCH v4 1/4] arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support
Date: Mon, 6 Oct 2025 22:59:14 -0700	[thread overview]
Message-ID: <7476a26d-c629-49a4-ab47-eaffda482782@gmail.com> (raw)
In-Reply-To: <DD5714TDL1NA.26WS3YF7EMZ5I@cknow.org>

Hello Diederik,

>> +	stk3311 {
>> +		stk3311_int: stk3311-int {
>> +			rockchip,pins = <4 RK_PD3 RK_FUNC_GPIO &pcfg_input_pull_up>;
> On page 11 and 17 of PPP schematic V1.0-20211127 I see LIGHT_INT_L as
> identifier so it's best to use that identifier here, thus
> ``light_int_l: light-int-l {``
> and update the pinctrl-0 reference accordingly.
Thanks! Since this is a simple change, I will wait for more comments in 
this patch series (would like comments on the mount matrices for the 
accelerometer and the magnetometer). I will put this change in v5 if I 
send one.


Thanks,

Rudraksha



WARNING: multiple messages have this Message-ID (diff)
From: Rudraksha Gupta <guptarud@gmail.com>
To: Diederik de Haas <didi.debian@cknow.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	"Ondrej Jirman" <megi@xff.cz>,
	"Martijn Braam" <martijn@brixit.nl>,
	"Kamil Trzciński" <ayufan@ayufan.eu>
Subject: Re: [PATCH v4 1/4] arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support
Date: Mon, 6 Oct 2025 22:59:14 -0700	[thread overview]
Message-ID: <7476a26d-c629-49a4-ab47-eaffda482782@gmail.com> (raw)
In-Reply-To: <DD5714TDL1NA.26WS3YF7EMZ5I@cknow.org>

Hello Diederik,

>> +	stk3311 {
>> +		stk3311_int: stk3311-int {
>> +			rockchip,pins = <4 RK_PD3 RK_FUNC_GPIO &pcfg_input_pull_up>;
> On page 11 and 17 of PPP schematic V1.0-20211127 I see LIGHT_INT_L as
> identifier so it's best to use that identifier here, thus
> ``light_int_l: light-int-l {``
> and update the pinctrl-0 reference accordingly.
Thanks! Since this is a simple change, I will wait for more comments in 
this patch series (would like comments on the mount matrices for the 
accelerometer and the magnetometer). I will put this change in v5 if I 
send one.


Thanks,

Rudraksha


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-10-07  5:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-29  7:35 [PATCH v4 0/4] Upstreaming Pinephone Pro Patches Rudraksha Gupta
2025-09-29  7:35 ` Rudraksha Gupta via B4 Relay
2025-09-29  7:35 ` Rudraksha Gupta via B4 Relay
2025-09-29  7:35 ` [PATCH v4 1/4] arm64: dts: rk3399-pinephone-pro: Add light/proximity sensor support Rudraksha Gupta
2025-09-29  7:35   ` Rudraksha Gupta via B4 Relay
2025-09-29  7:35   ` Rudraksha Gupta via B4 Relay
2025-09-29  9:57   ` Diederik de Haas
2025-09-29  9:57     ` Diederik de Haas
2025-10-07  5:59     ` Rudraksha Gupta [this message]
2025-10-07  5:59       ` Rudraksha Gupta
2025-09-29  7:35 ` [PATCH v4 2/4] arm64: dts: rk3399-pinephone-pro: Add accelerometer " Rudraksha Gupta
2025-09-29  7:35   ` Rudraksha Gupta via B4 Relay
2025-09-29  7:35   ` Rudraksha Gupta via B4 Relay
2025-10-22 11:11   ` Pavel Machek
2025-10-22 11:11     ` Pavel Machek
2025-09-29  7:35 ` [PATCH v4 3/4] arm64: dts: rk3399-pinephone-pro: Add magnetometer " Rudraksha Gupta
2025-09-29  7:35   ` Rudraksha Gupta via B4 Relay
2025-09-29  7:35   ` Rudraksha Gupta via B4 Relay
2025-10-22 11:12   ` Pavel Machek
2025-10-22 11:12     ` Pavel Machek
2025-09-29  7:35 ` [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume keys Rudraksha Gupta
2025-09-29  7:35   ` Rudraksha Gupta via B4 Relay
2025-09-29  7:35   ` Rudraksha Gupta via B4 Relay
2025-10-22 11:13   ` Pavel Machek
2025-10-22 11:13     ` Pavel Machek
2025-09-29  8:32 ` [PATCH v4 0/4] Upstreaming Pinephone Pro Patches Dragan Simic
2025-09-29  8:32   ` Dragan Simic
2025-09-29 15:39   ` Heiko Stuebner
2025-09-29 15:39     ` Heiko Stuebner
2025-10-07  5:56     ` Rudraksha Gupta
2025-10-07  5:56       ` Rudraksha Gupta
2025-10-22 11:09 ` Pavel Machek
2025-10-22 11:09   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7476a26d-c629-49a4-ab47-eaffda482782@gmail.com \
    --to=guptarud@gmail.com \
    --cc=ayufan@ayufan.eu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=didi.debian@cknow.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=martijn@brixit.nl \
    --cc=megi@xff.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.