Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume keys

From: Pavel Machek <pavel@ucw.cz>
To: guptarud@gmail.com
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Ondrej Jirman <megi@xff.cz>
Subject: Re: [PATCH v4 4/4] arm64: dts: rk3399-pinephone-pro: Fix voltage threshold for volume keys
Date: Wed, 22 Oct 2025 13:13:18 +0200	[thread overview]
Message-ID: <aPi8TsoarXJXvKuz@duo.ucw.cz> (raw)
In-Reply-To: <20250929-ppp_light_accel_mag_vol-down-v4-4-6598f22d3451@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

Hi!

> From: Ondrej Jirman <megi@xff.cz>
> 
> Previously sometimes pressing the volume-down button would register as
> a volume-up button. Match the thresholds as shown in the Pinephone Pro
> schematic.
> 
> Tests:
> 
> ~ $ evtest
>     // Mashed the volume down ~100 times with varying intensity
>     Event: time xxx, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 1
>     Event: time xxx, type 1 (EV_KEY), code 114 (KEY_VOLUMEDOWN), value 0
>     // Mashed the volume up ~100 times with varying intensity
>     Event: time xxx, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 1
>     Event: time xxx, type 1 (EV_KEY), code 115 (KEY_VOLUMEUP), value 0
> 
> Signed-off-by: Ondrej Jirman <megi@xff.cz>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>

Reviewed-by: Pavel Machek <pavel@ucw.cz>

BR,
								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]