All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alistair Popple <alistair@popple.id.au>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/7] IBM Akebono: Add support for a new PHY interface to the IBM emac driver
Date: Mon, 24 Feb 2014 13:09:19 +1100	[thread overview]
Message-ID: <7545458.ltLKFumBkZ@mexican> (raw)
In-Reply-To: <20140221111823.GA8783@e106331-lin.cambridge.arm.com>

On Fri, 21 Feb 2014 11:18:23 Mark Rutland wrote:
> On Fri, Feb 21, 2014 at 06:31:28AM +0000, Alistair Popple wrote:

[...]

> 
> > +       /* Check for RGMII flags */
> > +       if (of_get_property(ofdev->dev.of_node, "has-mdio", NULL))
> > +               dev->flags |= EMAC_RGMII_FLAG_HAS_MDIO;
> 
> You can use of_property_read_bool here.

Thanks. I will update it.

Regards,

Alistair

> 
> Cheers,
> Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Alistair Popple <alistair-Y4h6yKqj69EXC2x5gXVKYQ@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
	<linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [PATCH 2/7] IBM Akebono: Add support for a new PHY interface to the IBM emac driver
Date: Mon, 24 Feb 2014 13:09:19 +1100	[thread overview]
Message-ID: <7545458.ltLKFumBkZ@mexican> (raw)
In-Reply-To: <20140221111823.GA8783-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>

On Fri, 21 Feb 2014 11:18:23 Mark Rutland wrote:
> On Fri, Feb 21, 2014 at 06:31:28AM +0000, Alistair Popple wrote:

[...]

> 
> > +       /* Check for RGMII flags */
> > +       if (of_get_property(ofdev->dev.of_node, "has-mdio", NULL))
> > +               dev->flags |= EMAC_RGMII_FLAG_HAS_MDIO;
> 
> You can use of_property_read_bool here.

Thanks. I will update it.

Regards,

Alistair

> 
> Cheers,
> Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Alistair Popple <alistair@popple.id.au>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 2/7] IBM Akebono: Add support for a new PHY interface to the IBM emac driver
Date: Mon, 24 Feb 2014 13:09:19 +1100	[thread overview]
Message-ID: <7545458.ltLKFumBkZ@mexican> (raw)
In-Reply-To: <20140221111823.GA8783@e106331-lin.cambridge.arm.com>

On Fri, 21 Feb 2014 11:18:23 Mark Rutland wrote:
> On Fri, Feb 21, 2014 at 06:31:28AM +0000, Alistair Popple wrote:

[...]

> 
> > +       /* Check for RGMII flags */
> > +       if (of_get_property(ofdev->dev.of_node, "has-mdio", NULL))
> > +               dev->flags |= EMAC_RGMII_FLAG_HAS_MDIO;
> 
> You can use of_property_read_bool here.

Thanks. I will update it.

Regards,

Alistair

> 
> Cheers,
> Mark.

  reply	other threads:[~2014-02-24  2:09 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21  6:31 [PATCH 0/7] IBM Akebono/PPC476GTR Support Alistair Popple
2014-02-21  6:31 ` Alistair Popple
2014-02-21  6:31 ` Alistair Popple
2014-02-21  6:31 ` [PATCH 1/7] IBM Akebono: Add a SDHCI platform driver Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21  6:31   ` Alistair Popple
     [not found]   ` <1392964293-13687-2-git-send-email-alistair-Y4h6yKqj69EXC2x5gXVKYQ@public.gmane.org>
2014-02-21 14:14     ` Arnd Bergmann
2014-02-21 14:14       ` Arnd Bergmann
2014-02-21 14:14       ` Arnd Bergmann
2014-02-24  0:38       ` Alistair Popple
2014-02-24  0:38         ` Alistair Popple
2014-02-21  6:31 ` [PATCH 2/7] IBM Akebono: Add support for a new PHY interface to the IBM emac driver Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21 11:18   ` Mark Rutland
2014-02-21 11:18     ` Mark Rutland
2014-02-21 11:18     ` Mark Rutland
2014-02-24  2:09     ` Alistair Popple [this message]
2014-02-24  2:09       ` Alistair Popple
2014-02-24  2:09       ` Alistair Popple
2014-02-21  6:31 ` [PATCH 3/7] IBM Akebono: Add support to the OHCI platform driver for PPC476GTR Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21 14:16   ` Arnd Bergmann
2014-02-21 14:16     ` Arnd Bergmann
2014-02-21 14:16     ` Arnd Bergmann
2014-02-24  0:20     ` Alistair Popple
2014-02-24  0:20       ` Alistair Popple
2014-02-24  0:20       ` Alistair Popple
2014-02-21 15:34   ` Alan Stern
2014-02-21 15:34     ` Alan Stern
2014-02-21 15:34     ` Alan Stern
2014-02-21  6:31 ` [PATCH 4/7] ECHI Platform: Merge ppc-of EHCI driver into the ehci-platform driver Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21 11:48   ` Mark Rutland
2014-02-21 11:48     ` Mark Rutland
2014-02-21 11:48     ` Mark Rutland
2014-02-21 14:21     ` Arnd Bergmann
2014-02-21 14:21       ` Arnd Bergmann
2014-02-21 14:21       ` Arnd Bergmann
2014-02-22  2:32     ` Tony Prisk
2014-02-22  2:32       ` Tony Prisk
2014-02-22  2:32       ` Tony Prisk
2014-02-21 15:41   ` Alan Stern
2014-02-21 15:41     ` Alan Stern
2014-02-21 15:41     ` Alan Stern
2014-02-24  0:28     ` Alistair Popple
2014-02-24  0:28       ` Alistair Popple
2014-02-21  6:31 ` [PATCH 5/7] IBM Currituck: Clean up board specific code before adding Akebono code Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21  6:31 ` [PATCH 6/7] IBM Akebono: Add the Akebono platform Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21  6:31 ` [PATCH 7/7] powerpc: Added PCI MSI support using the HSTA module Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21  6:31   ` Alistair Popple
2014-02-21 14:33   ` Arnd Bergmann
2014-02-21 14:33     ` Arnd Bergmann
2014-02-21 14:33     ` Arnd Bergmann
2014-02-21 20:41     ` Benjamin Herrenschmidt
2014-02-21 20:41       ` Benjamin Herrenschmidt
2014-02-21 20:41       ` Benjamin Herrenschmidt
2014-02-21 21:53       ` Arnd Bergmann
2014-02-21 21:53         ` Arnd Bergmann
2014-02-21 21:53         ` Arnd Bergmann
2014-02-25  5:54       ` Alistair Popple
2014-02-25  5:54         ` Alistair Popple
2014-02-25  5:54         ` Alistair Popple

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7545458.ltLKFumBkZ@mexican \
    --to=alistair@popple.id.au \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.