All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Law <jlaw@ventanamicro.com>
To: Palmer Dabbelt <palmer@dabbelt.com>, Conor Dooley <conor@kernel.org>
Cc: heiko@sntech.de, Paul Walmsley <paul.walmsley@sifive.com>,
	aou@eecs.berkeley.edu, herbert@gondor.apana.org.au,
	davem@davemloft.net, Conor Dooley <conor.dooley@microchip.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, christoph.muellner@vrull.eu,
	heiko.stuebner@vrull.eu
Subject: Re: [PATCH v5 1/4] RISC-V: add Zbc extension detection
Date: Tue, 20 Jun 2023 13:37:00 -0600	[thread overview]
Message-ID: <75cf8335-af1f-e06c-c770-b2b540e812ed@ventanamicro.com> (raw)
In-Reply-To: <mhng-919a6ed5-c8b0-4311-9a8f-8c204b81a8e0@palmer-ri-x1c9a>



On 6/20/23 13:09, Palmer Dabbelt wrote:
> On Mon, 12 Jun 2023 14:31:14 PDT (-0700), Conor Dooley wrote:
>> Hey Heiko,
>>
>> On Mon, Jun 12, 2023 at 11:04:39PM +0200, Heiko Stuebner wrote:
>>> From: Heiko Stuebner <heiko.stuebner@vrull.eu>
>>>
>>> Add handling for Zbc extension.
>>>
>>> Zbc provides instruction for carry-less multiplication.
>>>
>>> Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu>
>>> ---
>>>  arch/riscv/Kconfig             | 22 ++++++++++++++++++++++
>>>  arch/riscv/include/asm/hwcap.h |  1 +
>>>  arch/riscv/kernel/cpu.c        |  1 +
>>>  arch/riscv/kernel/cpufeature.c |  1 +
>>>  4 files changed, 25 insertions(+)
>>
>> Plumbing into the hwprobe stuff would be nice, but that's not a
>> requirement for getting stuff merged :)
> 
> IIRC we talked about this on IRC, but IMO we shouldn't require something 
> be user visible for it to be merged in the kernel.
Note that exposing Zbc is potentially useful.  We've got GCC and LLVM 
code that can detect and rewrite a bitwise CRC into clmul.

Jeff

WARNING: multiple messages have this Message-ID (diff)
From: Jeff Law <jlaw@ventanamicro.com>
To: Palmer Dabbelt <palmer@dabbelt.com>, Conor Dooley <conor@kernel.org>
Cc: heiko@sntech.de, Paul Walmsley <paul.walmsley@sifive.com>,
	aou@eecs.berkeley.edu, herbert@gondor.apana.org.au,
	davem@davemloft.net, Conor Dooley <conor.dooley@microchip.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, christoph.muellner@vrull.eu,
	heiko.stuebner@vrull.eu
Subject: Re: [PATCH v5 1/4] RISC-V: add Zbc extension detection
Date: Tue, 20 Jun 2023 13:37:00 -0600	[thread overview]
Message-ID: <75cf8335-af1f-e06c-c770-b2b540e812ed@ventanamicro.com> (raw)
In-Reply-To: <mhng-919a6ed5-c8b0-4311-9a8f-8c204b81a8e0@palmer-ri-x1c9a>



On 6/20/23 13:09, Palmer Dabbelt wrote:
> On Mon, 12 Jun 2023 14:31:14 PDT (-0700), Conor Dooley wrote:
>> Hey Heiko,
>>
>> On Mon, Jun 12, 2023 at 11:04:39PM +0200, Heiko Stuebner wrote:
>>> From: Heiko Stuebner <heiko.stuebner@vrull.eu>
>>>
>>> Add handling for Zbc extension.
>>>
>>> Zbc provides instruction for carry-less multiplication.
>>>
>>> Signed-off-by: Heiko Stuebner <heiko.stuebner@vrull.eu>
>>> ---
>>>  arch/riscv/Kconfig             | 22 ++++++++++++++++++++++
>>>  arch/riscv/include/asm/hwcap.h |  1 +
>>>  arch/riscv/kernel/cpu.c        |  1 +
>>>  arch/riscv/kernel/cpufeature.c |  1 +
>>>  4 files changed, 25 insertions(+)
>>
>> Plumbing into the hwprobe stuff would be nice, but that's not a
>> requirement for getting stuff merged :)
> 
> IIRC we talked about this on IRC, but IMO we shouldn't require something 
> be user visible for it to be merged in the kernel.
Note that exposing Zbc is potentially useful.  We've got GCC and LLVM 
code that can detect and rewrite a bitwise CRC into clmul.

Jeff

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  parent reply	other threads:[~2023-06-20 19:37 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 21:04 [PATCH v5 0/4] Implement GCM ghash using Zbc and Zbkb extensions Heiko Stuebner
2023-06-12 21:04 ` Heiko Stuebner
2023-06-12 21:04 ` [PATCH v5 1/4] RISC-V: add Zbc extension detection Heiko Stuebner
2023-06-12 21:04   ` Heiko Stuebner
2023-06-12 21:31   ` Conor Dooley
2023-06-12 21:31     ` Conor Dooley
2023-06-20 19:09     ` Palmer Dabbelt
2023-06-20 19:09       ` Palmer Dabbelt
2023-06-20 19:12       ` Conor Dooley
2023-06-20 19:12         ` Conor Dooley
2023-06-20 19:37       ` Jeff Law [this message]
2023-06-20 19:37         ` Jeff Law
2023-06-20 19:42         ` Palmer Dabbelt
2023-06-20 19:42           ` Palmer Dabbelt
2023-06-12 21:04 ` [PATCH v5 2/4] RISC-V: add Zbkb " Heiko Stuebner
2023-06-12 21:04   ` Heiko Stuebner
2023-06-12 21:33   ` Conor Dooley
2023-06-12 21:33     ` Conor Dooley
2023-06-12 21:04 ` [PATCH v5 3/4] RISC-V: hook new crypto subdir into build-system Heiko Stuebner
2023-06-12 21:04   ` Heiko Stuebner
2023-06-13 16:54   ` Conor Dooley
2023-06-13 16:54     ` Conor Dooley
2023-06-12 21:04 ` [PATCH v5 4/4] RISC-V: crypto: add accelerated GCM GHASH implementation Heiko Stuebner
2023-06-12 21:04   ` Heiko Stuebner
2023-06-13  3:10   ` Eric Biggers
2023-06-13  3:10     ` Eric Biggers
2023-06-13  8:00     ` Heiko Stübner
2023-06-13  8:00       ` Heiko Stübner
2023-06-13 19:01       ` Eric Biggers
2023-06-13 19:01         ` Eric Biggers
2023-06-16 10:34   ` Herbert Xu
2023-06-16 10:34     ` Herbert Xu
2023-07-07 17:57     ` Heiko Stübner
2023-07-07 17:57       ` Heiko Stübner
2023-06-13  3:02 ` [PATCH v5 0/4] Implement GCM ghash using Zbc and Zbkb extensions Eric Biggers
2023-06-13  3:02   ` Eric Biggers
2023-07-10  9:44   ` Heiko Stuebner
2023-07-10  9:44     ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75cf8335-af1f-e06c-c770-b2b540e812ed@ventanamicro.com \
    --to=jlaw@ventanamicro.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=christoph.muellner@vrull.eu \
    --cc=conor.dooley@microchip.com \
    --cc=conor@kernel.org \
    --cc=davem@davemloft.net \
    --cc=heiko.stuebner@vrull.eu \
    --cc=heiko@sntech.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.