All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kumar Gala <kumar.gala@freescale.com>
To: "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux/PPC Development <linuxppc-dev@ozlabs.org>,
	Paul Mackerras <paulus@samba.org>,
	Kumar Gala <galak@somerset.sps.mot.com>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][PPC32] Add performance counters to cpu_spec
Date: Tue, 9 Nov 2004 08:27:22 -0600	[thread overview]
Message-ID: <781C4866-325B-11D9-AD97-000393DBC2E8@freescale.com> (raw)
In-Reply-To: <Pine.GSO.4.61.0411091012550.25943@waterleaf.sonytel.be>


On Nov 9, 2004, at 3:13 AM, Geert Uytterhoeven wrote:

> On Mon, 8 Nov 2004, Kumar Gala wrote:
>  > Adds the number of performance monitor counters each PowerPC=20
> processor has to
>  > the cpu table.=A0 Makes oprofile support a bit cleaner since we =
dont=20
> need a case
>  > statement on processor version to determine the number of counters.
>  >
> > Signed-off-by: Kumar Gala <kumar.gala@freescale.com>
> >
> > --
>  >
> > diff -Nru a/arch/ppc/kernel/cputable.c b/arch/ppc/kernel/cputable.c
> > --- a/arch/ppc/kernel/cputable.c=A0=A0=A0=A0=A0 2004-11-08 21:02:51 =
-06:00
>  > +++ b/arch/ppc/kernel/cputable.c=A0=A0=A0=A0=A0 2004-11-08 21:02:51 =
-06:00
>  > @@ -82,6 +82,7 @@
>  >=A0 =A0=A0=A0=A0 CPU_FTR_601 | CPU_FTR_HPTE_TABLE,
> >=A0 =A0=A0=A0=A0 COMMON_PPC | PPC_FEATURE_601_INSTR | =
PPC_FEATURE_UNIFIED_CACHE,
> >=A0 =A0=A0=A0=A0 32, 32,
>  > +=A0=A0=A0=A0 0,
>  >=A0 =A0=A0=A0=A0 __setup_cpu_601
> >=A0=A0=A0=A0=A0 },
>  >=A0=A0=A0=A0=A0 {=A0=A0=A0=A0=A0=A0=A0 /* 603 */
>
> Perhaps you want to switch to C99-style struct initialization as well?

I can change it C99-style as well as fixing the formatting, just wanted=20=

to see if there we any other comments.  Will resend with those changes=20=

if I dont hear any other feedback.

- kumar

WARNING: multiple messages have this Message-ID (diff)
From: Kumar Gala <kumar.gala@freescale.com>
To: "Geert Uytterhoeven" <geert@linux-m68k.org>
Cc: "Paul Mackerras" <paulus@samba.org>,
	"Andrew Morton" <akpm@osdl.org>,
	"Linux/PPC Development" <linuxppc-dev@ozlabs.org>,
	"Kumar Gala" <galak@somerset.sps.mot.com>,
	"Linux Kernel Development" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][PPC32] Add performance counters to cpu_spec
Date: Tue, 9 Nov 2004 08:27:22 -0600	[thread overview]
Message-ID: <781C4866-325B-11D9-AD97-000393DBC2E8@freescale.com> (raw)
In-Reply-To: <Pine.GSO.4.61.0411091012550.25943@waterleaf.sonytel.be>


On Nov 9, 2004, at 3:13 AM, Geert Uytterhoeven wrote:

> On Mon, 8 Nov 2004, Kumar Gala wrote:
>  > Adds the number of performance monitor counters each PowerPC 
> processor has to
>  > the cpu table.  Makes oprofile support a bit cleaner since we dont 
> need a case
>  > statement on processor version to determine the number of counters.
>  >
> > Signed-off-by: Kumar Gala <kumar.gala@freescale.com>
> >
> > --
>  >
> > diff -Nru a/arch/ppc/kernel/cputable.c b/arch/ppc/kernel/cputable.c
> > --- a/arch/ppc/kernel/cputable.c      2004-11-08 21:02:51 -06:00
>  > +++ b/arch/ppc/kernel/cputable.c      2004-11-08 21:02:51 -06:00
>  > @@ -82,6 +82,7 @@
>  >       CPU_FTR_601 | CPU_FTR_HPTE_TABLE,
> >       COMMON_PPC | PPC_FEATURE_601_INSTR | PPC_FEATURE_UNIFIED_CACHE,
> >       32, 32,
>  > +     0,
>  >       __setup_cpu_601
> >      },
>  >      {        /* 603 */
>
> Perhaps you want to switch to C99-style struct initialization as well?

I can change it C99-style as well as fixing the formatting, just wanted 
to see if there we any other comments.  Will resend with those changes 
if I dont hear any other feedback.

- kumar


  reply	other threads:[~2004-11-09 14:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-09  5:39 [PATCH][PPC32] Add performance counters to cpu_spec Kumar Gala
2004-11-09  5:39 ` Kumar Gala
2004-11-09  9:13 ` Geert Uytterhoeven
2004-11-09 14:27   ` Kumar Gala [this message]
2004-11-09 14:27     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=781C4866-325B-11D9-AD97-000393DBC2E8@freescale.com \
    --to=kumar.gala@freescale.com \
    --cc=akpm@osdl.org \
    --cc=galak@somerset.sps.mot.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.