All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Frank Wunderlich <linux@fw-web.de>
Cc: Jason Cooper <jason@lakedaemon.net>,
	Frank Wunderlich <frank-w@public-files.de>,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver"
Date: Mon, 17 Aug 2020 16:27:05 +0100	[thread overview]
Message-ID: <7b9c3ee73faeaf8d2e64c228047438f1@kernel.org> (raw)
In-Reply-To: <20200817145738.986999-1-linux@fw-web.de>

On 2020-08-17 15:57, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> This reverts commit f97dbf48ca43009e8b8bcdf07f47fc9f06149b36 which
> breaks bootup of arm/arm64 devices like bananapi-r2/mt7623 and
> bananapi-r64/mt7622
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  drivers/irqchip/irq-mtk-sysirq.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-mtk-sysirq.c 
> b/drivers/irqchip/irq-mtk-sysirq.c
> index 7299c5ab4d10..6ff98b87e5c0 100644
> --- a/drivers/irqchip/irq-mtk-sysirq.c
> +++ b/drivers/irqchip/irq-mtk-sysirq.c
> @@ -231,6 +231,4 @@ static int __init mtk_sysirq_of_init(struct
> device_node *node,
>  	kfree(chip_data);
>  	return ret;
>  }
> -IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq)
> -IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init)
> -IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq)
> +IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", 
> mtk_sysirq_of_init);

There is already a fix queued for this.

        M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Frank Wunderlich <linux@fw-web.de>
Cc: Jason Cooper <jason@lakedaemon.net>,
	Frank Wunderlich <frank-w@public-files.de>,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver"
Date: Mon, 17 Aug 2020 16:27:05 +0100	[thread overview]
Message-ID: <7b9c3ee73faeaf8d2e64c228047438f1@kernel.org> (raw)
In-Reply-To: <20200817145738.986999-1-linux@fw-web.de>

On 2020-08-17 15:57, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> This reverts commit f97dbf48ca43009e8b8bcdf07f47fc9f06149b36 which
> breaks bootup of arm/arm64 devices like bananapi-r2/mt7623 and
> bananapi-r64/mt7622
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  drivers/irqchip/irq-mtk-sysirq.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-mtk-sysirq.c 
> b/drivers/irqchip/irq-mtk-sysirq.c
> index 7299c5ab4d10..6ff98b87e5c0 100644
> --- a/drivers/irqchip/irq-mtk-sysirq.c
> +++ b/drivers/irqchip/irq-mtk-sysirq.c
> @@ -231,6 +231,4 @@ static int __init mtk_sysirq_of_init(struct
> device_node *node,
>  	kfree(chip_data);
>  	return ret;
>  }
> -IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq)
> -IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init)
> -IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq)
> +IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", 
> mtk_sysirq_of_init);

There is already a fix queued for this.

        M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Frank Wunderlich <linux@fw-web.de>
Cc: linux-mediatek@lists.infradead.org,
	Frank Wunderlich <frank-w@public-files.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver"
Date: Mon, 17 Aug 2020 16:27:05 +0100	[thread overview]
Message-ID: <7b9c3ee73faeaf8d2e64c228047438f1@kernel.org> (raw)
In-Reply-To: <20200817145738.986999-1-linux@fw-web.de>

On 2020-08-17 15:57, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> 
> This reverts commit f97dbf48ca43009e8b8bcdf07f47fc9f06149b36 which
> breaks bootup of arm/arm64 devices like bananapi-r2/mt7623 and
> bananapi-r64/mt7622
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
>  drivers/irqchip/irq-mtk-sysirq.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-mtk-sysirq.c 
> b/drivers/irqchip/irq-mtk-sysirq.c
> index 7299c5ab4d10..6ff98b87e5c0 100644
> --- a/drivers/irqchip/irq-mtk-sysirq.c
> +++ b/drivers/irqchip/irq-mtk-sysirq.c
> @@ -231,6 +231,4 @@ static int __init mtk_sysirq_of_init(struct
> device_node *node,
>  	kfree(chip_data);
>  	return ret;
>  }
> -IRQCHIP_PLATFORM_DRIVER_BEGIN(mtk_sysirq)
> -IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init)
> -IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq)
> +IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", 
> mtk_sysirq_of_init);

There is already a fix queued for this.

        M.
-- 
Jazz is not dead. It just smells funny...

  parent reply	other threads:[~2020-08-17 15:27 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 14:57 [PATCH] Revert "irqchip/mtk-sysirq: Convert to a platform driver" Frank Wunderlich
2020-08-17 14:57 ` Frank Wunderlich
2020-08-17 14:57 ` Frank Wunderlich
2020-08-17 15:04 ` Enric Balletbo Serra
2020-08-17 15:04   ` Enric Balletbo Serra
2020-08-17 15:04   ` Enric Balletbo Serra
2020-08-21 14:07   ` Frank Wunderlich
2020-08-21 14:07     ` Frank Wunderlich
2020-08-21 14:07     ` Frank Wunderlich
2020-08-17 15:27 ` Marc Zyngier [this message]
2020-08-17 15:27   ` Marc Zyngier
2020-08-17 15:27   ` Marc Zyngier
  -- strict thread matches above, loose matches on Subject: below --
2020-08-19 16:19 Enric Balletbo i Serra
2020-08-19 16:19 ` Enric Balletbo i Serra
2020-08-19 16:19 ` Enric Balletbo i Serra
     [not found] ` <C9E59107-CE83-4554-9447-5DE5BEE09A3B@fw-web.de>
2020-08-19 18:51   ` Saravana Kannan
2020-08-19 18:51     ` Saravana Kannan
2020-08-19 18:51     ` Saravana Kannan
2020-08-20  7:56     ` Marc Zyngier
2020-08-20  7:56       ` Marc Zyngier
2020-08-20  7:56       ` Marc Zyngier
2020-08-20  8:07       ` Saravana Kannan
2020-08-20  8:07         ` Saravana Kannan
2020-08-20  8:07         ` Saravana Kannan
2020-08-20 14:53         ` Marc Zyngier
2020-08-20 14:53           ` Marc Zyngier
2020-08-20 14:53           ` Marc Zyngier
2020-08-20 19:39           ` Saravana Kannan
2020-08-20 19:39             ` Saravana Kannan
2020-08-20 19:39             ` Saravana Kannan
2020-08-21  9:20           ` Enric Balletbo i Serra
2020-08-21  9:20             ` Enric Balletbo i Serra
2020-08-21  9:20             ` Enric Balletbo i Serra
2020-08-21 10:17             ` Marc Zyngier
2020-08-21 10:17               ` Marc Zyngier
2020-08-21 10:17               ` Marc Zyngier
2020-08-21 14:03               ` Frank Wunderlich
2020-08-21 14:03                 ` Frank Wunderlich
2020-08-21 14:03                 ` Frank Wunderlich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b9c3ee73faeaf8d2e64c228047438f1@kernel.org \
    --to=maz@kernel.org \
    --cc=frank-w@public-files.de \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@fw-web.de \
    --cc=matthias.bgg@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.