From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Jason Baron <jbaron@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH] ARC: ARCv2: jump label: implement jump label patching
Date: Fri, 28 Jun 2019 22:59:33 +0000 [thread overview]
Message-ID: <7ef18a49-cc5a-6cd1-bed3-beec003a73c3@synopsys.com> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA2307501A252CCC3@us01wembx1.internal.synopsys.com>
On 6/18/19 9:16 AM, Vineet Gupta wrote:
> On 6/14/19 9:41 AM, Eugeniy Paltsev wrote:
>> Implement jump label patching for ARC. Jump labels provide
>> an interface to generate dynamic branches using
>> self-modifying code.
>>
>> This allows us to implement conditional branches where
>> changing branch direction is expensive but branch selection
>> is basically 'free'
>>
>> This implementation uses 32-bit NOP and BRANCH instructions
>> which forced to be aligned by 4 to guarantee that they don't
>> cross L1 cache line and can be update atomically.
>>
>> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
>
> LGTM overall - nits below.
@Peter can we have your reviewed/ack or some such assuming you don't have any
objections !
Thx,
-Vineet
WARNING: multiple messages have this Message-ID (diff)
From: Vineet.Gupta1@synopsys.com (Vineet Gupta)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] ARC: ARCv2: jump label: implement jump label patching
Date: Fri, 28 Jun 2019 22:59:33 +0000 [thread overview]
Message-ID: <7ef18a49-cc5a-6cd1-bed3-beec003a73c3@synopsys.com> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA2307501A252CCC3@us01wembx1.internal.synopsys.com>
On 6/18/19 9:16 AM, Vineet Gupta wrote:
> On 6/14/19 9:41 AM, Eugeniy Paltsev wrote:
>> Implement jump label patching for ARC. Jump labels provide
>> an interface to generate dynamic branches using
>> self-modifying code.
>>
>> This allows us to implement conditional branches where
>> changing branch direction is expensive but branch selection
>> is basically 'free'
>>
>> This implementation uses 32-bit NOP and BRANCH instructions
>> which forced to be aligned by 4 to guarantee that they don't
>> cross L1 cache line and can be update atomically.
>>
>> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
>
> LGTM overall - nits below.
@Peter can we have your reviewed/ack or some such assuming you don't have any
objections !
Thx,
-Vineet
next prev parent reply other threads:[~2019-06-28 22:59 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 16:40 [PATCH] ARC: ARCv2: jump label: implement jump label patching Eugeniy Paltsev
2019-06-14 16:40 ` Eugeniy Paltsev
2019-06-18 16:16 ` Vineet Gupta
2019-06-18 16:16 ` Vineet Gupta
2019-06-19 8:12 ` Peter Zijlstra
2019-06-19 8:12 ` Peter Zijlstra
2019-06-19 23:55 ` Vineet Gupta
2019-06-19 23:55 ` Vineet Gupta
2019-06-20 7:01 ` Peter Zijlstra
2019-06-20 7:01 ` Peter Zijlstra
2019-06-20 18:34 ` Eugeniy Paltsev
2019-06-20 18:34 ` Eugeniy Paltsev
2019-06-20 21:30 ` Peter Zijlstra
2019-06-20 21:30 ` Peter Zijlstra
2019-06-20 21:30 ` Peter Zijlstra
2019-06-20 18:48 ` Vineet Gupta
2019-06-20 18:48 ` Vineet Gupta
2019-06-20 21:22 ` Peter Zijlstra
2019-06-20 21:22 ` Peter Zijlstra
2019-06-21 12:09 ` Peter Zijlstra
2019-06-21 12:09 ` Peter Zijlstra
2019-06-21 12:09 ` Peter Zijlstra
2019-06-21 12:12 ` Peter Zijlstra
2019-06-21 12:12 ` Peter Zijlstra
2019-06-21 12:12 ` Peter Zijlstra
2019-06-21 18:37 ` Nadav Amit
2019-06-21 18:37 ` Nadav Amit
2019-06-20 7:15 ` Peter Zijlstra
2019-06-20 7:15 ` Peter Zijlstra
2019-06-20 7:15 ` Peter Zijlstra
2019-06-20 7:21 ` Peter Zijlstra
2019-06-20 7:21 ` Peter Zijlstra
2019-06-20 7:52 ` Peter Zijlstra
2019-06-20 7:52 ` Peter Zijlstra
2019-06-20 7:52 ` Peter Zijlstra
2019-06-20 20:49 ` Vineet Gupta
2019-06-20 20:49 ` Vineet Gupta
2019-06-21 15:39 ` Alexey Brodkin
2019-06-21 15:39 ` Alexey Brodkin
2019-06-20 18:34 ` Eugeniy Paltsev
2019-06-20 18:34 ` Eugeniy Paltsev
2019-06-20 21:12 ` Peter Zijlstra
2019-06-20 21:12 ` Peter Zijlstra
2019-06-28 22:59 ` Vineet Gupta [this message]
2019-06-28 22:59 ` Vineet Gupta
2019-07-03 16:15 ` Vineet Gupta
2019-07-03 16:15 ` Vineet Gupta
2019-07-17 15:09 ` Eugeniy Paltsev
2019-07-17 15:09 ` Eugeniy Paltsev
2019-07-17 17:45 ` Vineet Gupta
2019-07-17 17:45 ` Vineet Gupta
2019-07-17 18:54 ` Eugeniy Paltsev
2019-07-17 18:54 ` Eugeniy Paltsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef18a49-cc5a-6cd1-bed3-beec003a73c3@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=ard.biesheuvel@linaro.org \
--cc=jbaron@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.