All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Christian Hewitt <christianshewitt@gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: meson-g12b-gtking: add initial device-tree
Date: Mon, 16 Mar 2020 09:44:39 -0700	[thread overview]
Message-ID: <7h36a8w8p4.fsf@baylibre.com> (raw)
In-Reply-To: <1582985353-83371-3-git-send-email-christianshewitt@gmail.com>

Christian Hewitt <christianshewitt@gmail.com> writes:

> The Shenzen AZW (Beelink) GT-King is based on the Amlogic W400 reference
> board with an S922X chip.
>
> - 4GB LPDDR4 RAM
> - 64GB eMMC storage
> - 10/100/1000 Base-T Ethernet
> - AP6356S Wireless (802.11 a/b/g/n/ac, BT 4.1)
> - HDMI 2.1 video
> - S/PDIF optical output
> - Analogue audio output
> - 1x USB 2.0 port
> - 2x USB 3.0 ports
> - IR receiver
> - 1x micro SD card slot
>
> The device-tree is largely based on meson-g12b-ugoos-am6.

It's more than just based on, it's identical (other than compatible
strings and whitespace fixup[1].)

Both of these are based on the W400 ref design, so please make a W400
.dtsi that can be used by both ugoos and this.

Sorry to be a bit picky here, but there's a prolifieration of these
boards out there based on the Amlogic designs with little/no difference,
so I'd like our DTs to reflect that.

Thanks,

Kevin


[1]
$ diff -u arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts
--- arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts	2020-03-04 07:06:17.089604752 -0800
+++ arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts	2020-03-16 09:38:06.983705705 -0700
@@ -14,8 +14,8 @@
 #include <dt-bindings/sound/meson-g12a-tohdmitx.h>
 
 / {
-	compatible = "ugoos,am6", "amlogic,g12b";
-	model = "Ugoos AM6";
+	compatible = "azw,gtking", "amlogic,g12b";
+	model = "Beelink GT-King";
 
 	aliases {
 		serial0 = &uart_AO;
@@ -200,7 +200,7 @@
 
 	sound {
 		compatible = "amlogic,axg-sound-card";
-		model = "G12B-UGOOS-AM6";
+		model = "G12B-GTKING";
 		audio-aux-devs = <&tdmout_b>;
 		audio-routing = "TDMOUT_B IN 0", "FRDDR_A OUT 1",
 				"TDMOUT_B IN 1", "FRDDR_B OUT 1",
@@ -532,7 +532,7 @@
 		shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
 		max-speed = <2000000>;
 		clocks = <&wifi32k>;
-	clock-names = "lpo";
+		clock-names = "lpo";
 	};
 };
 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Christian Hewitt <christianshewitt@gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: meson-g12b-gtking: add initial device-tree
Date: Mon, 16 Mar 2020 09:44:39 -0700	[thread overview]
Message-ID: <7h36a8w8p4.fsf@baylibre.com> (raw)
In-Reply-To: <1582985353-83371-3-git-send-email-christianshewitt@gmail.com>

Christian Hewitt <christianshewitt@gmail.com> writes:

> The Shenzen AZW (Beelink) GT-King is based on the Amlogic W400 reference
> board with an S922X chip.
>
> - 4GB LPDDR4 RAM
> - 64GB eMMC storage
> - 10/100/1000 Base-T Ethernet
> - AP6356S Wireless (802.11 a/b/g/n/ac, BT 4.1)
> - HDMI 2.1 video
> - S/PDIF optical output
> - Analogue audio output
> - 1x USB 2.0 port
> - 2x USB 3.0 ports
> - IR receiver
> - 1x micro SD card slot
>
> The device-tree is largely based on meson-g12b-ugoos-am6.

It's more than just based on, it's identical (other than compatible
strings and whitespace fixup[1].)

Both of these are based on the W400 ref design, so please make a W400
.dtsi that can be used by both ugoos and this.

Sorry to be a bit picky here, but there's a prolifieration of these
boards out there based on the Amlogic designs with little/no difference,
so I'd like our DTs to reflect that.

Thanks,

Kevin


[1]
$ diff -u arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts
--- arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts	2020-03-04 07:06:17.089604752 -0800
+++ arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts	2020-03-16 09:38:06.983705705 -0700
@@ -14,8 +14,8 @@
 #include <dt-bindings/sound/meson-g12a-tohdmitx.h>
 
 / {
-	compatible = "ugoos,am6", "amlogic,g12b";
-	model = "Ugoos AM6";
+	compatible = "azw,gtking", "amlogic,g12b";
+	model = "Beelink GT-King";
 
 	aliases {
 		serial0 = &uart_AO;
@@ -200,7 +200,7 @@
 
 	sound {
 		compatible = "amlogic,axg-sound-card";
-		model = "G12B-UGOOS-AM6";
+		model = "G12B-GTKING";
 		audio-aux-devs = <&tdmout_b>;
 		audio-routing = "TDMOUT_B IN 0", "FRDDR_A OUT 1",
 				"TDMOUT_B IN 1", "FRDDR_B OUT 1",
@@ -532,7 +532,7 @@
 		shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
 		max-speed = <2000000>;
 		clocks = <&wifi32k>;
-	clock-names = "lpo";
+		clock-names = "lpo";
 	};
 };
 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Christian Hewitt <christianshewitt@gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: meson-g12b-gtking: add initial device-tree
Date: Mon, 16 Mar 2020 09:44:39 -0700	[thread overview]
Message-ID: <7h36a8w8p4.fsf@baylibre.com> (raw)
In-Reply-To: <1582985353-83371-3-git-send-email-christianshewitt@gmail.com>

Christian Hewitt <christianshewitt@gmail.com> writes:

> The Shenzen AZW (Beelink) GT-King is based on the Amlogic W400 reference
> board with an S922X chip.
>
> - 4GB LPDDR4 RAM
> - 64GB eMMC storage
> - 10/100/1000 Base-T Ethernet
> - AP6356S Wireless (802.11 a/b/g/n/ac, BT 4.1)
> - HDMI 2.1 video
> - S/PDIF optical output
> - Analogue audio output
> - 1x USB 2.0 port
> - 2x USB 3.0 ports
> - IR receiver
> - 1x micro SD card slot
>
> The device-tree is largely based on meson-g12b-ugoos-am6.

It's more than just based on, it's identical (other than compatible
strings and whitespace fixup[1].)

Both of these are based on the W400 ref design, so please make a W400
.dtsi that can be used by both ugoos and this.

Sorry to be a bit picky here, but there's a prolifieration of these
boards out there based on the Amlogic designs with little/no difference,
so I'd like our DTs to reflect that.

Thanks,

Kevin


[1]
$ diff -u arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts
--- arch/arm64/boot/dts/amlogic/meson-g12b-ugoos-am6.dts	2020-03-04 07:06:17.089604752 -0800
+++ arch/arm64/boot/dts/amlogic/meson-g12b-gtking.dts	2020-03-16 09:38:06.983705705 -0700
@@ -14,8 +14,8 @@
 #include <dt-bindings/sound/meson-g12a-tohdmitx.h>
 
 / {
-	compatible = "ugoos,am6", "amlogic,g12b";
-	model = "Ugoos AM6";
+	compatible = "azw,gtking", "amlogic,g12b";
+	model = "Beelink GT-King";
 
 	aliases {
 		serial0 = &uart_AO;
@@ -200,7 +200,7 @@
 
 	sound {
 		compatible = "amlogic,axg-sound-card";
-		model = "G12B-UGOOS-AM6";
+		model = "G12B-GTKING";
 		audio-aux-devs = <&tdmout_b>;
 		audio-routing = "TDMOUT_B IN 0", "FRDDR_A OUT 1",
 				"TDMOUT_B IN 1", "FRDDR_B OUT 1",
@@ -532,7 +532,7 @@
 		shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>;
 		max-speed = <2000000>;
 		clocks = <&wifi32k>;
-	clock-names = "lpo";
+		clock-names = "lpo";
 	};
 };
 

  parent reply	other threads:[~2020-03-16 16:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-29 14:09 [PATCH 0/2] arm64: dts: meson: add dts/bindings for Beelink GT-King Christian Hewitt
2020-02-29 14:09 ` Christian Hewitt
2020-02-29 14:09 ` Christian Hewitt
2020-02-29 14:09 ` [PATCH 1/2] dt-bindings: arm: amlogic: add support for the " Christian Hewitt
2020-02-29 14:09   ` Christian Hewitt
2020-02-29 14:09   ` Christian Hewitt
2020-03-03 14:50   ` Neil Armstrong
2020-03-03 14:50     ` Neil Armstrong
2020-03-03 14:50     ` Neil Armstrong
2020-03-10 18:49   ` Rob Herring
2020-03-10 18:49     ` Rob Herring
2020-03-10 18:49     ` Rob Herring
2020-02-29 14:09 ` [PATCH 2/2] arm64: dts: meson-g12b-gtking: add initial device-tree Christian Hewitt
2020-02-29 14:09   ` Christian Hewitt
2020-02-29 14:09   ` Christian Hewitt
2020-03-03 14:50   ` Neil Armstrong
2020-03-03 14:50     ` Neil Armstrong
2020-03-03 14:50     ` Neil Armstrong
2020-03-05  8:22     ` Jerome Brunet
2020-03-05  8:22       ` Jerome Brunet
2020-03-05  8:22       ` Jerome Brunet
2020-03-16 16:44   ` Kevin Hilman [this message]
2020-03-16 16:44     ` Kevin Hilman
2020-03-16 16:44     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7h36a8w8p4.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=christianshewitt@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.