All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@baylibre.com>
To: Julien Masson <jmasson@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>
Cc: Julien Masson <jmasson@baylibre.com>,
	linux-amlogic@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] drm: meson: global clean-up (use proper macros, update comments ...)
Date: Mon, 24 Jun 2019 16:24:35 -0700	[thread overview]
Message-ID: <7ho92mwor0.fsf@baylibre.com> (raw)
In-Reply-To: <86zhm782g5.fsf@baylibre.com>

Julien Masson <jmasson@baylibre.com> writes:

> This patch series aims to clean-up differents parts of the drm meson
> code source.
>
> Couple macros have been defined and used to set several registers
> instead of using magic constants.
>
> I also took the opportunity to:
> - add/remove/update comments
> - remove useless code
> - minor fix/improvment

Nice set of cleanups, thanks!  I especially like the extra in-code
comments.

Could you also add to the cover-letter how this was tested, and on what
platforms so we know it's not going to introduce any regressions.

Thanks,

Kevin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Julien Masson <jmasson@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>
Cc: Julien Masson <jmasson@baylibre.com>,
	linux-amlogic@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/9] drm: meson: global clean-up (use proper macros, update comments ...)
Date: Mon, 24 Jun 2019 16:24:35 -0700	[thread overview]
Message-ID: <7ho92mwor0.fsf@baylibre.com> (raw)
In-Reply-To: <86zhm782g5.fsf@baylibre.com>

Julien Masson <jmasson@baylibre.com> writes:

> This patch series aims to clean-up differents parts of the drm meson
> code source.
>
> Couple macros have been defined and used to set several registers
> instead of using magic constants.
>
> I also took the opportunity to:
> - add/remove/update comments
> - remove useless code
> - minor fix/improvment

Nice set of cleanups, thanks!  I especially like the extra in-code
comments.

Could you also add to the cover-letter how this was tested, and on what
platforms so we know it's not going to introduce any regressions.

Thanks,

Kevin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Julien Masson <jmasson@baylibre.com>
Subject: Re: [PATCH 0/9] drm: meson: global clean-up (use proper macros, update comments ...)
Date: Mon, 24 Jun 2019 16:24:35 -0700	[thread overview]
Message-ID: <7ho92mwor0.fsf@baylibre.com> (raw)
In-Reply-To: <86zhm782g5.fsf@baylibre.com>

Julien Masson <jmasson@baylibre.com> writes:

> This patch series aims to clean-up differents parts of the drm meson
> code source.
>
> Couple macros have been defined and used to set several registers
> instead of using magic constants.
>
> I also took the opportunity to:
> - add/remove/update comments
> - remove useless code
> - minor fix/improvment

Nice set of cleanups, thanks!  I especially like the extra in-code
comments.

Could you also add to the cover-letter how this was tested, and on what
platforms so we know it's not going to introduce any regressions.

Thanks,

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Julien Masson <jmasson@baylibre.com>,
	Neil Armstrong <narmstrong@baylibre.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Julien Masson <jmasson@baylibre.com>
Subject: Re: [PATCH 0/9] drm: meson: global clean-up (use proper macros, update comments ...)
Date: Mon, 24 Jun 2019 16:24:35 -0700	[thread overview]
Message-ID: <7ho92mwor0.fsf@baylibre.com> (raw)
In-Reply-To: <86zhm782g5.fsf@baylibre.com>

Julien Masson <jmasson@baylibre.com> writes:

> This patch series aims to clean-up differents parts of the drm meson
> code source.
>
> Couple macros have been defined and used to set several registers
> instead of using magic constants.
>
> I also took the opportunity to:
> - add/remove/update comments
> - remove useless code
> - minor fix/improvment

Nice set of cleanups, thanks!  I especially like the extra in-code
comments.

Could you also add to the cover-letter how this was tested, and on what
platforms so we know it's not going to introduce any regressions.

Thanks,

Kevin

  parent reply	other threads:[~2019-06-24 23:24 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-24 14:20 [PATCH 0/9] drm: meson: global clean-up (use proper macros, update comments ...) Julien Masson
2019-06-24 14:20 ` Julien Masson
2019-06-24 14:20 ` Julien Masson
2019-06-24 14:47 ` [PATCH 1/9] drm: meson: mask value when writing bits relaxed Julien Masson
2019-06-24 14:47   ` Julien Masson
2019-06-24 14:47   ` Julien Masson
2019-06-24 14:48 ` [PATCH 2/9] drm: meson: crtc: use proper macros instead of magic constants Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:48 ` [PATCH 3/9] drm: meson: drv: use macro when initializing vpu Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:48 ` [PATCH 4/9] drm: meson: vpp: use proper macros instead of magic constants Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 23:15   ` Kevin Hilman
2019-06-24 23:15     ` Kevin Hilman
2019-06-24 23:15     ` Kevin Hilman
2019-08-08 14:09     ` Neil Armstrong
2019-08-08 14:09       ` Neil Armstrong
2019-08-08 14:09       ` Neil Armstrong
2019-08-08 14:09       ` Neil Armstrong
2019-06-24 14:48 ` [PATCH 5/9] drm: meson: viu: " Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:48 ` [PATCH 6/9] drm: meson: venc: " Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:48 ` [PATCH 7/9] drm: meson: global clean-up Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:48   ` Julien Masson
2019-06-24 14:49 ` [PATCH 8/9] drm: meson: add macro used to enable HDMI PLL Julien Masson
2019-06-24 14:49   ` Julien Masson
2019-06-24 14:49   ` Julien Masson
2019-06-24 23:20   ` Kevin Hilman
2019-06-24 23:20     ` Kevin Hilman
2019-06-24 23:20     ` Kevin Hilman
2019-08-08 14:10     ` Neil Armstrong
2019-08-08 14:10       ` Neil Armstrong
2019-08-08 14:10       ` Neil Armstrong
2019-06-24 14:49 ` [PATCH 9/9] drm: meson: venc: set the correct macrovision max amplitude value Julien Masson
2019-06-24 14:49   ` Julien Masson
2019-06-24 14:49   ` Julien Masson
2019-06-24 23:24 ` Kevin Hilman [this message]
2019-06-24 23:24   ` [PATCH 0/9] drm: meson: global clean-up (use proper macros, update comments ...) Kevin Hilman
2019-06-24 23:24   ` Kevin Hilman
2019-06-24 23:24   ` Kevin Hilman
2019-08-08 14:12   ` Neil Armstrong
2019-08-08 14:12     ` Neil Armstrong
2019-08-08 14:12     ` Neil Armstrong
2019-08-09  9:29     ` Neil Armstrong
2019-08-09  9:29       ` Neil Armstrong
2019-08-09  9:29       ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ho92mwor0.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jmasson@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.