* [PATCH 0/4] cpufreq: Make cpufreq_driver->exit() return void @ 2024-07-04 6:53 ` Viresh Kumar 0 siblings, 0 replies; 20+ messages in thread From: Viresh Kumar @ 2024-07-04 6:53 UTC (permalink / raw) To: Rafael J. Wysocki, Alyssa Rosenzweig, AngeloGioacchino Del Regno, Broadcom internal kernel review list, Christophe Leroy, Cristian Marussi, Gautham R. Shenoy, Hector Martin, Huang Rui, Jiaxun Yang, Jonathan Hunter, Kevin Hilman, Len Brown, Mario Limonciello, Markus Mayer, Matthias Brugger, Michael Ellerman, Naveen N. Rao, Nicholas Piggin, Perry Yuan, Srinivas Pandruvada, Sudeep Holla, Sven Peter, Thierry Reding, Viresh Kumar Cc: linux-pm, Vincent Guittot, asahi, linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek, linux-mips, linux-omap, linuxppc-dev, linux-tegra, Lizhe Make exit() return void, since it isn't used by the core. Based on initial patches sent by Lizhe [1]. Rafael, I will take this through my tree for 6.11. -- Viresh [1] https://lore.kernel.org/all/20240410132132.3526-1-sensor1010@163.com/ Lizhe (1): cpufreq: Make cpufreq_driver->exit() return void Viresh Kumar (3): cpufreq: nforce2: Remove empty exit() callback cpufreq: loongson2: Remove empty exit() callback cpufreq: pcc: Remove empty exit() callback drivers/cpufreq/acpi-cpufreq.c | 4 +--- drivers/cpufreq/amd-pstate.c | 7 ++----- drivers/cpufreq/apple-soc-cpufreq.c | 4 +--- drivers/cpufreq/bmips-cpufreq.c | 4 +--- drivers/cpufreq/cppc_cpufreq.c | 3 +-- drivers/cpufreq/cpufreq-dt.c | 3 +-- drivers/cpufreq/cpufreq-nforce2.c | 6 ------ drivers/cpufreq/e_powersaver.c | 3 +-- drivers/cpufreq/intel_pstate.c | 8 +++----- drivers/cpufreq/loongson2_cpufreq.c | 6 ------ drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +--- drivers/cpufreq/mediatek-cpufreq.c | 4 +--- drivers/cpufreq/omap-cpufreq.c | 3 +-- drivers/cpufreq/pasemi-cpufreq.c | 6 ++---- drivers/cpufreq/pcc-cpufreq.c | 6 ------ drivers/cpufreq/powernow-k6.c | 5 ++--- drivers/cpufreq/powernow-k7.c | 3 +-- drivers/cpufreq/powernow-k8.c | 6 ++---- drivers/cpufreq/powernv-cpufreq.c | 4 +--- drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +-- drivers/cpufreq/qcom-cpufreq-hw.c | 4 +--- drivers/cpufreq/qoriq-cpufreq.c | 4 +--- drivers/cpufreq/scmi-cpufreq.c | 4 +--- drivers/cpufreq/scpi-cpufreq.c | 4 +--- drivers/cpufreq/sh-cpufreq.c | 4 +--- drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +-- drivers/cpufreq/sparc-us3-cpufreq.c | 3 +-- drivers/cpufreq/speedstep-centrino.c | 10 +++------- drivers/cpufreq/tegra194-cpufreq.c | 4 +--- drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- include/linux/cpufreq.h | 2 +- 31 files changed, 37 insertions(+), 102 deletions(-) -- 2.31.1.272.g89b43f80a514 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 0/4] cpufreq: Make cpufreq_driver->exit() return void @ 2024-07-04 6:53 ` Viresh Kumar 0 siblings, 0 replies; 20+ messages in thread From: Viresh Kumar @ 2024-07-04 6:53 UTC (permalink / raw) To: Rafael J. Wysocki, Alyssa Rosenzweig, AngeloGioacchino Del Regno, Broadcom internal kernel review list, Christophe Leroy, Cristian Marussi, Gautham R. Shenoy, Hector Martin, Huang Rui, Jiaxun Yang, Jonathan Hunter, Kevin Hilman, Len Brown, Mario Limonciello, Markus Mayer, Matthias Brugger, Michael Ellerman, Naveen N. Rao, Nicholas Piggin, Perry Yuan, Srinivas Pandruvada, Sudeep Holla, Sven Peter, Thierry Reding, Viresh Kumar Cc: Vincent Guittot, linux-pm, linux-arm-msm, linux-kernel, linux-mips, linux-mediatek, asahi, Lizhe, linux-tegra, linux-omap, linuxppc-dev, linux-arm-kernel Make exit() return void, since it isn't used by the core. Based on initial patches sent by Lizhe [1]. Rafael, I will take this through my tree for 6.11. -- Viresh [1] https://lore.kernel.org/all/20240410132132.3526-1-sensor1010@163.com/ Lizhe (1): cpufreq: Make cpufreq_driver->exit() return void Viresh Kumar (3): cpufreq: nforce2: Remove empty exit() callback cpufreq: loongson2: Remove empty exit() callback cpufreq: pcc: Remove empty exit() callback drivers/cpufreq/acpi-cpufreq.c | 4 +--- drivers/cpufreq/amd-pstate.c | 7 ++----- drivers/cpufreq/apple-soc-cpufreq.c | 4 +--- drivers/cpufreq/bmips-cpufreq.c | 4 +--- drivers/cpufreq/cppc_cpufreq.c | 3 +-- drivers/cpufreq/cpufreq-dt.c | 3 +-- drivers/cpufreq/cpufreq-nforce2.c | 6 ------ drivers/cpufreq/e_powersaver.c | 3 +-- drivers/cpufreq/intel_pstate.c | 8 +++----- drivers/cpufreq/loongson2_cpufreq.c | 6 ------ drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +--- drivers/cpufreq/mediatek-cpufreq.c | 4 +--- drivers/cpufreq/omap-cpufreq.c | 3 +-- drivers/cpufreq/pasemi-cpufreq.c | 6 ++---- drivers/cpufreq/pcc-cpufreq.c | 6 ------ drivers/cpufreq/powernow-k6.c | 5 ++--- drivers/cpufreq/powernow-k7.c | 3 +-- drivers/cpufreq/powernow-k8.c | 6 ++---- drivers/cpufreq/powernv-cpufreq.c | 4 +--- drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +-- drivers/cpufreq/qcom-cpufreq-hw.c | 4 +--- drivers/cpufreq/qoriq-cpufreq.c | 4 +--- drivers/cpufreq/scmi-cpufreq.c | 4 +--- drivers/cpufreq/scpi-cpufreq.c | 4 +--- drivers/cpufreq/sh-cpufreq.c | 4 +--- drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +-- drivers/cpufreq/sparc-us3-cpufreq.c | 3 +-- drivers/cpufreq/speedstep-centrino.c | 10 +++------- drivers/cpufreq/tegra194-cpufreq.c | 4 +--- drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- include/linux/cpufreq.h | 2 +- 31 files changed, 37 insertions(+), 102 deletions(-) -- 2.31.1.272.g89b43f80a514 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 1/4] cpufreq: nforce2: Remove empty exit() callback 2024-07-04 6:53 ` Viresh Kumar (?) @ 2024-07-04 6:53 ` Viresh Kumar -1 siblings, 0 replies; 20+ messages in thread From: Viresh Kumar @ 2024-07-04 6:53 UTC (permalink / raw) To: Rafael J. Wysocki, Viresh Kumar; +Cc: linux-pm, Vincent Guittot, linux-kernel The exit() callback is optional, remove the empty one. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/cpufreq-nforce2.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/cpufreq/cpufreq-nforce2.c b/drivers/cpufreq/cpufreq-nforce2.c index f7a7bcf6f52e..fedad1081973 100644 --- a/drivers/cpufreq/cpufreq-nforce2.c +++ b/drivers/cpufreq/cpufreq-nforce2.c @@ -359,11 +359,6 @@ static int nforce2_cpu_init(struct cpufreq_policy *policy) return 0; } -static int nforce2_cpu_exit(struct cpufreq_policy *policy) -{ - return 0; -} - static struct cpufreq_driver nforce2_driver = { .name = "nforce2", .flags = CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING, @@ -371,7 +366,6 @@ static struct cpufreq_driver nforce2_driver = { .target = nforce2_target, .get = nforce2_get, .init = nforce2_cpu_init, - .exit = nforce2_cpu_exit, }; #ifdef MODULE -- 2.31.1.272.g89b43f80a514 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/4] cpufreq: loongson2: Remove empty exit() callback 2024-07-04 6:53 ` Viresh Kumar (?) (?) @ 2024-07-04 6:53 ` Viresh Kumar 2024-07-04 9:36 ` Huacai Chen -1 siblings, 1 reply; 20+ messages in thread From: Viresh Kumar @ 2024-07-04 6:53 UTC (permalink / raw) To: Rafael J. Wysocki, Jiaxun Yang, Viresh Kumar Cc: linux-pm, Vincent Guittot, linux-mips, linux-kernel The exit() callback is optional, remove the empty one. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/loongson2_cpufreq.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c index afc59b292153..6a8e97896d38 100644 --- a/drivers/cpufreq/loongson2_cpufreq.c +++ b/drivers/cpufreq/loongson2_cpufreq.c @@ -85,18 +85,12 @@ static int loongson2_cpufreq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int loongson2_cpufreq_exit(struct cpufreq_policy *policy) -{ - return 0; -} - static struct cpufreq_driver loongson2_cpufreq_driver = { .name = "loongson2", .init = loongson2_cpufreq_cpu_init, .verify = cpufreq_generic_frequency_table_verify, .target_index = loongson2_cpufreq_target, .get = cpufreq_generic_get, - .exit = loongson2_cpufreq_exit, .attr = cpufreq_generic_attr, }; -- 2.31.1.272.g89b43f80a514 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 2/4] cpufreq: loongson2: Remove empty exit() callback 2024-07-04 6:53 ` [PATCH 2/4] cpufreq: loongson2: " Viresh Kumar @ 2024-07-04 9:36 ` Huacai Chen 0 siblings, 0 replies; 20+ messages in thread From: Huacai Chen @ 2024-07-04 9:36 UTC (permalink / raw) To: Viresh Kumar Cc: Rafael J. Wysocki, Jiaxun Yang, linux-pm, Vincent Guittot, linux-mips, linux-kernel Reviewed-by: Huacai Chen <chenhuacai@loongson.cn> On Thu, Jul 4, 2024 at 2:56 PM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > The exit() callback is optional, remove the empty one. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/loongson2_cpufreq.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c > index afc59b292153..6a8e97896d38 100644 > --- a/drivers/cpufreq/loongson2_cpufreq.c > +++ b/drivers/cpufreq/loongson2_cpufreq.c > @@ -85,18 +85,12 @@ static int loongson2_cpufreq_cpu_init(struct cpufreq_policy *policy) > return 0; > } > > -static int loongson2_cpufreq_exit(struct cpufreq_policy *policy) > -{ > - return 0; > -} > - > static struct cpufreq_driver loongson2_cpufreq_driver = { > .name = "loongson2", > .init = loongson2_cpufreq_cpu_init, > .verify = cpufreq_generic_frequency_table_verify, > .target_index = loongson2_cpufreq_target, > .get = cpufreq_generic_get, > - .exit = loongson2_cpufreq_exit, > .attr = cpufreq_generic_attr, > }; > > -- > 2.31.1.272.g89b43f80a514 > > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 3/4] cpufreq: pcc: Remove empty exit() callback 2024-07-04 6:53 ` Viresh Kumar ` (2 preceding siblings ...) (?) @ 2024-07-04 6:53 ` Viresh Kumar -1 siblings, 0 replies; 20+ messages in thread From: Viresh Kumar @ 2024-07-04 6:53 UTC (permalink / raw) To: Rafael J. Wysocki, Viresh Kumar; +Cc: linux-pm, Vincent Guittot, linux-kernel The exit() callback is optional, remove the empty one. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/pcc-cpufreq.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c index 6f8b5ea7aeae..771efbf51a48 100644 --- a/drivers/cpufreq/pcc-cpufreq.c +++ b/drivers/cpufreq/pcc-cpufreq.c @@ -562,18 +562,12 @@ static int pcc_cpufreq_cpu_init(struct cpufreq_policy *policy) return result; } -static int pcc_cpufreq_cpu_exit(struct cpufreq_policy *policy) -{ - return 0; -} - static struct cpufreq_driver pcc_cpufreq_driver = { .flags = CPUFREQ_CONST_LOOPS, .get = pcc_get_freq, .verify = pcc_cpufreq_verify, .target = pcc_cpufreq_target, .init = pcc_cpufreq_cpu_init, - .exit = pcc_cpufreq_cpu_exit, .name = "pcc-cpufreq", }; -- 2.31.1.272.g89b43f80a514 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void 2024-07-04 6:53 ` Viresh Kumar @ 2024-07-04 6:53 ` Viresh Kumar -1 siblings, 0 replies; 20+ messages in thread From: Viresh Kumar @ 2024-07-04 6:53 UTC (permalink / raw) To: Rafael J. Wysocki, Viresh Kumar, Huang Rui, Gautham R. Shenoy, Mario Limonciello, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Kevin Hilman, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Sudeep Holla, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger, AngeloGioacchino Del Regno Cc: linux-pm, Vincent Guittot, Lizhe, linux-kernel, asahi, linux-arm-kernel, linux-omap, linuxppc-dev, linux-arm-msm, linux-tegra, linux-mediatek From: Lizhe <sensor1010@163.com> The cpufreq core doesn't check the return type of the exit() callback and there is not much the core can do on failures at that point. Just drop the returned value and make it return void. Signed-off-by: Lizhe <sensor1010@163.com> [ Viresh: Reworked the patches to fix all missing changes together. ] Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/acpi-cpufreq.c | 4 +--- drivers/cpufreq/amd-pstate.c | 7 ++----- drivers/cpufreq/apple-soc-cpufreq.c | 4 +--- drivers/cpufreq/bmips-cpufreq.c | 4 +--- drivers/cpufreq/cppc_cpufreq.c | 3 +-- drivers/cpufreq/cpufreq-dt.c | 3 +-- drivers/cpufreq/e_powersaver.c | 3 +-- drivers/cpufreq/intel_pstate.c | 8 +++----- drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +--- drivers/cpufreq/mediatek-cpufreq.c | 4 +--- drivers/cpufreq/omap-cpufreq.c | 3 +-- drivers/cpufreq/pasemi-cpufreq.c | 6 ++---- drivers/cpufreq/powernow-k6.c | 5 ++--- drivers/cpufreq/powernow-k7.c | 3 +-- drivers/cpufreq/powernow-k8.c | 6 ++---- drivers/cpufreq/powernv-cpufreq.c | 4 +--- drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +-- drivers/cpufreq/qcom-cpufreq-hw.c | 4 +--- drivers/cpufreq/qoriq-cpufreq.c | 4 +--- drivers/cpufreq/scmi-cpufreq.c | 4 +--- drivers/cpufreq/scpi-cpufreq.c | 4 +--- drivers/cpufreq/sh-cpufreq.c | 4 +--- drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +-- drivers/cpufreq/sparc-us3-cpufreq.c | 3 +-- drivers/cpufreq/speedstep-centrino.c | 10 +++------- drivers/cpufreq/tegra194-cpufreq.c | 4 +--- drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- include/linux/cpufreq.h | 2 +- 28 files changed, 37 insertions(+), 84 deletions(-) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index fa2664f9f259..a8ca625a98b8 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -906,7 +906,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) return result; } -static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct acpi_cpufreq_data *data = policy->driver_data; @@ -919,8 +919,6 @@ static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) free_cpumask_var(data->freqdomain_cpus); kfree(policy->freq_table); kfree(data); - - return 0; } static int acpi_cpufreq_resume(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 80eaa58f1405..c1f48a0d69b6 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1090,7 +1090,7 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) return ret; } -static int amd_pstate_cpu_exit(struct cpufreq_policy *policy) +static void amd_pstate_cpu_exit(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; @@ -1098,8 +1098,6 @@ static int amd_pstate_cpu_exit(struct cpufreq_policy *policy) freq_qos_remove_request(&cpudata->req[0]); policy->fast_switch_possible = false; kfree(cpudata); - - return 0; } static int amd_pstate_cpu_resume(struct cpufreq_policy *policy) @@ -1542,7 +1540,7 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) return ret; } -static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) +static void amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; @@ -1552,7 +1550,6 @@ static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) } pr_debug("CPU %d exiting\n", policy->cpu); - return 0; } static void amd_pstate_epp_update_limit(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c index 021f423705e1..af34c22fa273 100644 --- a/drivers/cpufreq/apple-soc-cpufreq.c +++ b/drivers/cpufreq/apple-soc-cpufreq.c @@ -305,7 +305,7 @@ static int apple_soc_cpufreq_init(struct cpufreq_policy *policy) return ret; } -static int apple_soc_cpufreq_exit(struct cpufreq_policy *policy) +static void apple_soc_cpufreq_exit(struct cpufreq_policy *policy) { struct apple_cpu_priv *priv = policy->driver_data; @@ -313,8 +313,6 @@ static int apple_soc_cpufreq_exit(struct cpufreq_policy *policy) dev_pm_opp_remove_all_dynamic(priv->cpu_dev); iounmap(priv->reg_base); kfree(priv); - - return 0; } static struct cpufreq_driver apple_soc_cpufreq_driver = { diff --git a/drivers/cpufreq/bmips-cpufreq.c b/drivers/cpufreq/bmips-cpufreq.c index 39221a9a187a..17a4c174553d 100644 --- a/drivers/cpufreq/bmips-cpufreq.c +++ b/drivers/cpufreq/bmips-cpufreq.c @@ -121,11 +121,9 @@ static int bmips_cpufreq_target_index(struct cpufreq_policy *policy, return 0; } -static int bmips_cpufreq_exit(struct cpufreq_policy *policy) +static void bmips_cpufreq_exit(struct cpufreq_policy *policy) { kfree(policy->freq_table); - - return 0; } static int bmips_cpufreq_init(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index 15f1d41920a3..17aeb3785446 100644 --- a/drivers/cpufreq/cppc_cpufreq.c +++ b/drivers/cpufreq/cppc_cpufreq.c @@ -688,7 +688,7 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) return ret; } -static int cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct cppc_cpudata *cpu_data = policy->driver_data; struct cppc_perf_caps *caps = &cpu_data->perf_caps; @@ -705,7 +705,6 @@ static int cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy) caps->lowest_perf, cpu, ret); cppc_cpufreq_put_cpu_data(policy); - return 0; } static inline u64 get_delta(u64 t1, u64 t0) diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index 907e22632fda..6532c4d71338 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -157,10 +157,9 @@ static int cpufreq_offline(struct cpufreq_policy *policy) return 0; } -static int cpufreq_exit(struct cpufreq_policy *policy) +static void cpufreq_exit(struct cpufreq_policy *policy) { clk_put(policy->clk); - return 0; } static struct cpufreq_driver dt_cpufreq_driver = { diff --git a/drivers/cpufreq/e_powersaver.c b/drivers/cpufreq/e_powersaver.c index ab93bce8ae77..6e958b09e1b5 100644 --- a/drivers/cpufreq/e_powersaver.c +++ b/drivers/cpufreq/e_powersaver.c @@ -360,14 +360,13 @@ static int eps_cpu_init(struct cpufreq_policy *policy) return 0; } -static int eps_cpu_exit(struct cpufreq_policy *policy) +static void eps_cpu_exit(struct cpufreq_policy *policy) { unsigned int cpu = policy->cpu; /* Bye */ kfree(eps_cpu[cpu]); eps_cpu[cpu] = NULL; - return 0; } static struct cpufreq_driver eps_driver = { diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 25389e43c392..392a8000b238 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -2715,13 +2715,11 @@ static int intel_pstate_cpu_offline(struct cpufreq_policy *policy) return intel_cpufreq_cpu_offline(policy); } -static int intel_pstate_cpu_exit(struct cpufreq_policy *policy) +static void intel_pstate_cpu_exit(struct cpufreq_policy *policy) { pr_debug("CPU %d exiting\n", policy->cpu); policy->fast_switch_possible = false; - - return 0; } static int __intel_pstate_cpu_init(struct cpufreq_policy *policy) @@ -3052,7 +3050,7 @@ static int intel_cpufreq_cpu_init(struct cpufreq_policy *policy) return ret; } -static int intel_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void intel_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct freq_qos_request *req; @@ -3062,7 +3060,7 @@ static int intel_cpufreq_cpu_exit(struct cpufreq_policy *policy) freq_qos_remove_request(req); kfree(req); - return intel_pstate_cpu_exit(policy); + intel_pstate_cpu_exit(policy); } static int intel_cpufreq_suspend(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/mediatek-cpufreq-hw.c b/drivers/cpufreq/mediatek-cpufreq-hw.c index 8d097dcddda4..8925e096d5b9 100644 --- a/drivers/cpufreq/mediatek-cpufreq-hw.c +++ b/drivers/cpufreq/mediatek-cpufreq-hw.c @@ -260,7 +260,7 @@ static int mtk_cpufreq_hw_cpu_init(struct cpufreq_policy *policy) return 0; } -static int mtk_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) +static void mtk_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) { struct mtk_cpufreq_data *data = policy->driver_data; struct resource *res = data->res; @@ -270,8 +270,6 @@ static int mtk_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) writel_relaxed(0x0, data->reg_bases[REG_FREQ_ENABLE]); iounmap(base); release_mem_region(res->start, resource_size(res)); - - return 0; } static void mtk_cpufreq_register_em(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c index 518606adf14e..102cfaa3b7e5 100644 --- a/drivers/cpufreq/mediatek-cpufreq.c +++ b/drivers/cpufreq/mediatek-cpufreq.c @@ -599,13 +599,11 @@ static int mtk_cpufreq_init(struct cpufreq_policy *policy) return 0; } -static int mtk_cpufreq_exit(struct cpufreq_policy *policy) +static void mtk_cpufreq_exit(struct cpufreq_policy *policy) { struct mtk_cpu_dvfs_info *info = policy->driver_data; dev_pm_opp_free_cpufreq_table(info->cpu_dev, &policy->freq_table); - - return 0; } static struct cpufreq_driver mtk_cpufreq_driver = { diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c index 895690856665..3458d5cc9b7f 100644 --- a/drivers/cpufreq/omap-cpufreq.c +++ b/drivers/cpufreq/omap-cpufreq.c @@ -135,11 +135,10 @@ static int omap_cpu_init(struct cpufreq_policy *policy) return 0; } -static int omap_cpu_exit(struct cpufreq_policy *policy) +static void omap_cpu_exit(struct cpufreq_policy *policy) { freq_table_free(); clk_put(policy->clk); - return 0; } static struct cpufreq_driver omap_driver = { diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c index 039a66bbe1be..ee925b53b6b9 100644 --- a/drivers/cpufreq/pasemi-cpufreq.c +++ b/drivers/cpufreq/pasemi-cpufreq.c @@ -204,21 +204,19 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy) return err; } -static int pas_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void pas_cpufreq_cpu_exit(struct cpufreq_policy *policy) { /* * We don't support CPU hotplug. Don't unmap after the system * has already made it to a running state. */ if (system_state >= SYSTEM_RUNNING) - return 0; + return; if (sdcasr_mapbase) iounmap(sdcasr_mapbase); if (sdcpwr_mapbase) iounmap(sdcpwr_mapbase); - - return 0; } static int pas_cpufreq_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/powernow-k6.c b/drivers/cpufreq/powernow-k6.c index 41eefef95d87..f0a4a6c31204 100644 --- a/drivers/cpufreq/powernow-k6.c +++ b/drivers/cpufreq/powernow-k6.c @@ -219,7 +219,7 @@ static int powernow_k6_cpu_init(struct cpufreq_policy *policy) } -static int powernow_k6_cpu_exit(struct cpufreq_policy *policy) +static void powernow_k6_cpu_exit(struct cpufreq_policy *policy) { unsigned int i; @@ -234,10 +234,9 @@ static int powernow_k6_cpu_exit(struct cpufreq_policy *policy) cpufreq_freq_transition_begin(policy, &freqs); powernow_k6_target(policy, i); cpufreq_freq_transition_end(policy, &freqs, 0); - break; + return; } } - return 0; } static unsigned int powernow_k6_get(unsigned int cpu) diff --git a/drivers/cpufreq/powernow-k7.c b/drivers/cpufreq/powernow-k7.c index 5d515fc34836..4271446c8725 100644 --- a/drivers/cpufreq/powernow-k7.c +++ b/drivers/cpufreq/powernow-k7.c @@ -644,7 +644,7 @@ static int powernow_cpu_init(struct cpufreq_policy *policy) return 0; } -static int powernow_cpu_exit(struct cpufreq_policy *policy) +static void powernow_cpu_exit(struct cpufreq_policy *policy) { #ifdef CONFIG_X86_POWERNOW_K7_ACPI if (acpi_processor_perf) { @@ -655,7 +655,6 @@ static int powernow_cpu_exit(struct cpufreq_policy *policy) #endif kfree(powernow_table); - return 0; } static struct cpufreq_driver powernow_driver = { diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index b10f7a1b77f1..a01170f7d01c 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -1089,13 +1089,13 @@ static int powernowk8_cpu_init(struct cpufreq_policy *pol) return -ENODEV; } -static int powernowk8_cpu_exit(struct cpufreq_policy *pol) +static void powernowk8_cpu_exit(struct cpufreq_policy *pol) { struct powernow_k8_data *data = per_cpu(powernow_data, pol->cpu); int cpu; if (!data) - return -EINVAL; + return; powernow_k8_cpu_exit_acpi(data); @@ -1104,8 +1104,6 @@ static int powernowk8_cpu_exit(struct cpufreq_policy *pol) /* pol->cpus will be empty here, use related_cpus instead. */ for_each_cpu(cpu, pol->related_cpus) per_cpu(powernow_data, cpu) = NULL; - - return 0; } static void query_values_on_cpu(void *_err) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index fddbd1ea1635..50c62929f7ca 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -874,7 +874,7 @@ static int powernv_cpufreq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int powernv_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void powernv_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct powernv_smp_call_data freq_data; struct global_pstate_info *gpstates = policy->driver_data; @@ -886,8 +886,6 @@ static int powernv_cpufreq_cpu_exit(struct cpufreq_policy *policy) del_timer_sync(&gpstates->timer); kfree(policy->driver_data); - - return 0; } static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb, diff --git a/drivers/cpufreq/ppc_cbe_cpufreq.c b/drivers/cpufreq/ppc_cbe_cpufreq.c index 88afc49941b7..5ee4c7bfdcc5 100644 --- a/drivers/cpufreq/ppc_cbe_cpufreq.c +++ b/drivers/cpufreq/ppc_cbe_cpufreq.c @@ -113,10 +113,9 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int cbe_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void cbe_cpufreq_cpu_exit(struct cpufreq_policy *policy) { cbe_cpufreq_pmi_policy_exit(policy); - return 0; } static int cbe_cpufreq_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c index ec8df5496a0c..370fe6a0104b 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -573,7 +573,7 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy) return qcom_cpufreq_hw_lmh_init(policy, index); } -static int qcom_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) +static void qcom_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) { struct device *cpu_dev = get_cpu_device(policy->cpu); struct qcom_cpufreq_data *data = policy->driver_data; @@ -583,8 +583,6 @@ static int qcom_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) qcom_cpufreq_hw_lmh_exit(data); kfree(policy->freq_table); kfree(data); - - return 0; } static void qcom_cpufreq_ready(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c index 0aecaecbb0e6..3519bf34d397 100644 --- a/drivers/cpufreq/qoriq-cpufreq.c +++ b/drivers/cpufreq/qoriq-cpufreq.c @@ -225,7 +225,7 @@ static int qoriq_cpufreq_cpu_init(struct cpufreq_policy *policy) return -ENODEV; } -static int qoriq_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void qoriq_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct cpu_data *data = policy->driver_data; @@ -233,8 +233,6 @@ static int qoriq_cpufreq_cpu_exit(struct cpufreq_policy *policy) kfree(data->table); kfree(data); policy->driver_data = NULL; - - return 0; } static int qoriq_cpufreq_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 3b4f6bfb2f4c..bf5f17f0dfb1 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -308,7 +308,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) return ret; } -static int scmi_cpufreq_exit(struct cpufreq_policy *policy) +static void scmi_cpufreq_exit(struct cpufreq_policy *policy) { struct scmi_data *priv = policy->driver_data; @@ -316,8 +316,6 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy) dev_pm_opp_remove_all_dynamic(priv->cpu_dev); free_cpumask_var(priv->opp_shared_cpus); kfree(priv); - - return 0; } static void scmi_cpufreq_register_em(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c index d33be56983ed..8d73e6e8be2a 100644 --- a/drivers/cpufreq/scpi-cpufreq.c +++ b/drivers/cpufreq/scpi-cpufreq.c @@ -167,7 +167,7 @@ static int scpi_cpufreq_init(struct cpufreq_policy *policy) return ret; } -static int scpi_cpufreq_exit(struct cpufreq_policy *policy) +static void scpi_cpufreq_exit(struct cpufreq_policy *policy) { struct scpi_data *priv = policy->driver_data; @@ -175,8 +175,6 @@ static int scpi_cpufreq_exit(struct cpufreq_policy *policy) dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table); dev_pm_opp_remove_all_dynamic(priv->cpu_dev); kfree(priv); - - return 0; } static struct cpufreq_driver scpi_cpufreq_driver = { diff --git a/drivers/cpufreq/sh-cpufreq.c b/drivers/cpufreq/sh-cpufreq.c index b8704232c27b..aa74036d0420 100644 --- a/drivers/cpufreq/sh-cpufreq.c +++ b/drivers/cpufreq/sh-cpufreq.c @@ -135,14 +135,12 @@ static int sh_cpufreq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int sh_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void sh_cpufreq_cpu_exit(struct cpufreq_policy *policy) { unsigned int cpu = policy->cpu; struct clk *cpuclk = &per_cpu(sh_cpuclk, cpu); clk_put(cpuclk); - - return 0; } static struct cpufreq_driver sh_cpufreq_driver = { diff --git a/drivers/cpufreq/sparc-us2e-cpufreq.c b/drivers/cpufreq/sparc-us2e-cpufreq.c index 2783d3d55fce..8a0cd5312a59 100644 --- a/drivers/cpufreq/sparc-us2e-cpufreq.c +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c @@ -296,10 +296,9 @@ static int us2e_freq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int us2e_freq_cpu_exit(struct cpufreq_policy *policy) +static void us2e_freq_cpu_exit(struct cpufreq_policy *policy) { us2e_freq_target(policy, 0); - return 0; } static struct cpufreq_driver cpufreq_us2e_driver = { diff --git a/drivers/cpufreq/sparc-us3-cpufreq.c b/drivers/cpufreq/sparc-us3-cpufreq.c index 6c3657679a88..b50f9d13e6d2 100644 --- a/drivers/cpufreq/sparc-us3-cpufreq.c +++ b/drivers/cpufreq/sparc-us3-cpufreq.c @@ -140,10 +140,9 @@ static int us3_freq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int us3_freq_cpu_exit(struct cpufreq_policy *policy) +static void us3_freq_cpu_exit(struct cpufreq_policy *policy) { us3_freq_target(policy, 0); - return 0; } static struct cpufreq_driver cpufreq_us3_driver = { diff --git a/drivers/cpufreq/speedstep-centrino.c b/drivers/cpufreq/speedstep-centrino.c index ddd6f53bfd2a..3fafedb983b5 100644 --- a/drivers/cpufreq/speedstep-centrino.c +++ b/drivers/cpufreq/speedstep-centrino.c @@ -400,16 +400,12 @@ static int centrino_cpu_init(struct cpufreq_policy *policy) return 0; } -static int centrino_cpu_exit(struct cpufreq_policy *policy) +static void centrino_cpu_exit(struct cpufreq_policy *policy) { unsigned int cpu = policy->cpu; - if (!per_cpu(centrino_model, cpu)) - return -ENODEV; - - per_cpu(centrino_model, cpu) = NULL; - - return 0; + if (per_cpu(centrino_model, cpu)) + per_cpu(centrino_model, cpu) = NULL; } /** diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c index 59865ea455a8..07ea7ed61b68 100644 --- a/drivers/cpufreq/tegra194-cpufreq.c +++ b/drivers/cpufreq/tegra194-cpufreq.c @@ -551,14 +551,12 @@ static int tegra194_cpufreq_offline(struct cpufreq_policy *policy) return 0; } -static int tegra194_cpufreq_exit(struct cpufreq_policy *policy) +static void tegra194_cpufreq_exit(struct cpufreq_policy *policy) { struct device *cpu_dev = get_cpu_device(policy->cpu); dev_pm_opp_remove_all_dynamic(cpu_dev); dev_pm_opp_of_cpumask_remove_table(policy->related_cpus); - - return 0; } static int tegra194_cpufreq_set_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/vexpress-spc-cpufreq.c b/drivers/cpufreq/vexpress-spc-cpufreq.c index 9ac4ea50b874..3fadf536c429 100644 --- a/drivers/cpufreq/vexpress-spc-cpufreq.c +++ b/drivers/cpufreq/vexpress-spc-cpufreq.c @@ -447,7 +447,7 @@ static int ve_spc_cpufreq_init(struct cpufreq_policy *policy) return 0; } -static int ve_spc_cpufreq_exit(struct cpufreq_policy *policy) +static void ve_spc_cpufreq_exit(struct cpufreq_policy *policy) { struct device *cpu_dev; @@ -455,11 +455,10 @@ static int ve_spc_cpufreq_exit(struct cpufreq_policy *policy) if (!cpu_dev) { pr_err("%s: failed to get cpu%d device\n", __func__, policy->cpu); - return -ENODEV; + return; } put_cluster_clk_and_freq_table(cpu_dev, policy->related_cpus); - return 0; } static struct cpufreq_driver ve_spc_cpufreq_driver = { diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 6f57de7de433..d4d2f4d1d7cb 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -396,7 +396,7 @@ struct cpufreq_driver { int (*online)(struct cpufreq_policy *policy); int (*offline)(struct cpufreq_policy *policy); - int (*exit)(struct cpufreq_policy *policy); + void (*exit)(struct cpufreq_policy *policy); int (*suspend)(struct cpufreq_policy *policy); int (*resume)(struct cpufreq_policy *policy); -- 2.31.1.272.g89b43f80a514 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void @ 2024-07-04 6:53 ` Viresh Kumar 0 siblings, 0 replies; 20+ messages in thread From: Viresh Kumar @ 2024-07-04 6:53 UTC (permalink / raw) To: Rafael J. Wysocki, Viresh Kumar, Huang Rui, Gautham R. Shenoy, Mario Limonciello, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Kevin Hilman, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Sudeep Holla, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger, AngeloGioacchino Del Regno Cc: Vincent Guittot, linux-pm, Lizhe, linux-kernel, linux-mediatek, asahi, linux-arm-msm, linux-tegra, linux-omap, linuxppc-dev, linux-arm-kernel From: Lizhe <sensor1010@163.com> The cpufreq core doesn't check the return type of the exit() callback and there is not much the core can do on failures at that point. Just drop the returned value and make it return void. Signed-off-by: Lizhe <sensor1010@163.com> [ Viresh: Reworked the patches to fix all missing changes together. ] Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/acpi-cpufreq.c | 4 +--- drivers/cpufreq/amd-pstate.c | 7 ++----- drivers/cpufreq/apple-soc-cpufreq.c | 4 +--- drivers/cpufreq/bmips-cpufreq.c | 4 +--- drivers/cpufreq/cppc_cpufreq.c | 3 +-- drivers/cpufreq/cpufreq-dt.c | 3 +-- drivers/cpufreq/e_powersaver.c | 3 +-- drivers/cpufreq/intel_pstate.c | 8 +++----- drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +--- drivers/cpufreq/mediatek-cpufreq.c | 4 +--- drivers/cpufreq/omap-cpufreq.c | 3 +-- drivers/cpufreq/pasemi-cpufreq.c | 6 ++---- drivers/cpufreq/powernow-k6.c | 5 ++--- drivers/cpufreq/powernow-k7.c | 3 +-- drivers/cpufreq/powernow-k8.c | 6 ++---- drivers/cpufreq/powernv-cpufreq.c | 4 +--- drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +-- drivers/cpufreq/qcom-cpufreq-hw.c | 4 +--- drivers/cpufreq/qoriq-cpufreq.c | 4 +--- drivers/cpufreq/scmi-cpufreq.c | 4 +--- drivers/cpufreq/scpi-cpufreq.c | 4 +--- drivers/cpufreq/sh-cpufreq.c | 4 +--- drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +-- drivers/cpufreq/sparc-us3-cpufreq.c | 3 +-- drivers/cpufreq/speedstep-centrino.c | 10 +++------- drivers/cpufreq/tegra194-cpufreq.c | 4 +--- drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- include/linux/cpufreq.h | 2 +- 28 files changed, 37 insertions(+), 84 deletions(-) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index fa2664f9f259..a8ca625a98b8 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -906,7 +906,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) return result; } -static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct acpi_cpufreq_data *data = policy->driver_data; @@ -919,8 +919,6 @@ static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) free_cpumask_var(data->freqdomain_cpus); kfree(policy->freq_table); kfree(data); - - return 0; } static int acpi_cpufreq_resume(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 80eaa58f1405..c1f48a0d69b6 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1090,7 +1090,7 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy) return ret; } -static int amd_pstate_cpu_exit(struct cpufreq_policy *policy) +static void amd_pstate_cpu_exit(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; @@ -1098,8 +1098,6 @@ static int amd_pstate_cpu_exit(struct cpufreq_policy *policy) freq_qos_remove_request(&cpudata->req[0]); policy->fast_switch_possible = false; kfree(cpudata); - - return 0; } static int amd_pstate_cpu_resume(struct cpufreq_policy *policy) @@ -1542,7 +1540,7 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy) return ret; } -static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) +static void amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) { struct amd_cpudata *cpudata = policy->driver_data; @@ -1552,7 +1550,6 @@ static int amd_pstate_epp_cpu_exit(struct cpufreq_policy *policy) } pr_debug("CPU %d exiting\n", policy->cpu); - return 0; } static void amd_pstate_epp_update_limit(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/apple-soc-cpufreq.c b/drivers/cpufreq/apple-soc-cpufreq.c index 021f423705e1..af34c22fa273 100644 --- a/drivers/cpufreq/apple-soc-cpufreq.c +++ b/drivers/cpufreq/apple-soc-cpufreq.c @@ -305,7 +305,7 @@ static int apple_soc_cpufreq_init(struct cpufreq_policy *policy) return ret; } -static int apple_soc_cpufreq_exit(struct cpufreq_policy *policy) +static void apple_soc_cpufreq_exit(struct cpufreq_policy *policy) { struct apple_cpu_priv *priv = policy->driver_data; @@ -313,8 +313,6 @@ static int apple_soc_cpufreq_exit(struct cpufreq_policy *policy) dev_pm_opp_remove_all_dynamic(priv->cpu_dev); iounmap(priv->reg_base); kfree(priv); - - return 0; } static struct cpufreq_driver apple_soc_cpufreq_driver = { diff --git a/drivers/cpufreq/bmips-cpufreq.c b/drivers/cpufreq/bmips-cpufreq.c index 39221a9a187a..17a4c174553d 100644 --- a/drivers/cpufreq/bmips-cpufreq.c +++ b/drivers/cpufreq/bmips-cpufreq.c @@ -121,11 +121,9 @@ static int bmips_cpufreq_target_index(struct cpufreq_policy *policy, return 0; } -static int bmips_cpufreq_exit(struct cpufreq_policy *policy) +static void bmips_cpufreq_exit(struct cpufreq_policy *policy) { kfree(policy->freq_table); - - return 0; } static int bmips_cpufreq_init(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index 15f1d41920a3..17aeb3785446 100644 --- a/drivers/cpufreq/cppc_cpufreq.c +++ b/drivers/cpufreq/cppc_cpufreq.c @@ -688,7 +688,7 @@ static int cppc_cpufreq_cpu_init(struct cpufreq_policy *policy) return ret; } -static int cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct cppc_cpudata *cpu_data = policy->driver_data; struct cppc_perf_caps *caps = &cpu_data->perf_caps; @@ -705,7 +705,6 @@ static int cppc_cpufreq_cpu_exit(struct cpufreq_policy *policy) caps->lowest_perf, cpu, ret); cppc_cpufreq_put_cpu_data(policy); - return 0; } static inline u64 get_delta(u64 t1, u64 t0) diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index 907e22632fda..6532c4d71338 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -157,10 +157,9 @@ static int cpufreq_offline(struct cpufreq_policy *policy) return 0; } -static int cpufreq_exit(struct cpufreq_policy *policy) +static void cpufreq_exit(struct cpufreq_policy *policy) { clk_put(policy->clk); - return 0; } static struct cpufreq_driver dt_cpufreq_driver = { diff --git a/drivers/cpufreq/e_powersaver.c b/drivers/cpufreq/e_powersaver.c index ab93bce8ae77..6e958b09e1b5 100644 --- a/drivers/cpufreq/e_powersaver.c +++ b/drivers/cpufreq/e_powersaver.c @@ -360,14 +360,13 @@ static int eps_cpu_init(struct cpufreq_policy *policy) return 0; } -static int eps_cpu_exit(struct cpufreq_policy *policy) +static void eps_cpu_exit(struct cpufreq_policy *policy) { unsigned int cpu = policy->cpu; /* Bye */ kfree(eps_cpu[cpu]); eps_cpu[cpu] = NULL; - return 0; } static struct cpufreq_driver eps_driver = { diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index 25389e43c392..392a8000b238 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -2715,13 +2715,11 @@ static int intel_pstate_cpu_offline(struct cpufreq_policy *policy) return intel_cpufreq_cpu_offline(policy); } -static int intel_pstate_cpu_exit(struct cpufreq_policy *policy) +static void intel_pstate_cpu_exit(struct cpufreq_policy *policy) { pr_debug("CPU %d exiting\n", policy->cpu); policy->fast_switch_possible = false; - - return 0; } static int __intel_pstate_cpu_init(struct cpufreq_policy *policy) @@ -3052,7 +3050,7 @@ static int intel_cpufreq_cpu_init(struct cpufreq_policy *policy) return ret; } -static int intel_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void intel_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct freq_qos_request *req; @@ -3062,7 +3060,7 @@ static int intel_cpufreq_cpu_exit(struct cpufreq_policy *policy) freq_qos_remove_request(req); kfree(req); - return intel_pstate_cpu_exit(policy); + intel_pstate_cpu_exit(policy); } static int intel_cpufreq_suspend(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/mediatek-cpufreq-hw.c b/drivers/cpufreq/mediatek-cpufreq-hw.c index 8d097dcddda4..8925e096d5b9 100644 --- a/drivers/cpufreq/mediatek-cpufreq-hw.c +++ b/drivers/cpufreq/mediatek-cpufreq-hw.c @@ -260,7 +260,7 @@ static int mtk_cpufreq_hw_cpu_init(struct cpufreq_policy *policy) return 0; } -static int mtk_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) +static void mtk_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) { struct mtk_cpufreq_data *data = policy->driver_data; struct resource *res = data->res; @@ -270,8 +270,6 @@ static int mtk_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) writel_relaxed(0x0, data->reg_bases[REG_FREQ_ENABLE]); iounmap(base); release_mem_region(res->start, resource_size(res)); - - return 0; } static void mtk_cpufreq_register_em(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c index 518606adf14e..102cfaa3b7e5 100644 --- a/drivers/cpufreq/mediatek-cpufreq.c +++ b/drivers/cpufreq/mediatek-cpufreq.c @@ -599,13 +599,11 @@ static int mtk_cpufreq_init(struct cpufreq_policy *policy) return 0; } -static int mtk_cpufreq_exit(struct cpufreq_policy *policy) +static void mtk_cpufreq_exit(struct cpufreq_policy *policy) { struct mtk_cpu_dvfs_info *info = policy->driver_data; dev_pm_opp_free_cpufreq_table(info->cpu_dev, &policy->freq_table); - - return 0; } static struct cpufreq_driver mtk_cpufreq_driver = { diff --git a/drivers/cpufreq/omap-cpufreq.c b/drivers/cpufreq/omap-cpufreq.c index 895690856665..3458d5cc9b7f 100644 --- a/drivers/cpufreq/omap-cpufreq.c +++ b/drivers/cpufreq/omap-cpufreq.c @@ -135,11 +135,10 @@ static int omap_cpu_init(struct cpufreq_policy *policy) return 0; } -static int omap_cpu_exit(struct cpufreq_policy *policy) +static void omap_cpu_exit(struct cpufreq_policy *policy) { freq_table_free(); clk_put(policy->clk); - return 0; } static struct cpufreq_driver omap_driver = { diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c index 039a66bbe1be..ee925b53b6b9 100644 --- a/drivers/cpufreq/pasemi-cpufreq.c +++ b/drivers/cpufreq/pasemi-cpufreq.c @@ -204,21 +204,19 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy) return err; } -static int pas_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void pas_cpufreq_cpu_exit(struct cpufreq_policy *policy) { /* * We don't support CPU hotplug. Don't unmap after the system * has already made it to a running state. */ if (system_state >= SYSTEM_RUNNING) - return 0; + return; if (sdcasr_mapbase) iounmap(sdcasr_mapbase); if (sdcpwr_mapbase) iounmap(sdcpwr_mapbase); - - return 0; } static int pas_cpufreq_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/powernow-k6.c b/drivers/cpufreq/powernow-k6.c index 41eefef95d87..f0a4a6c31204 100644 --- a/drivers/cpufreq/powernow-k6.c +++ b/drivers/cpufreq/powernow-k6.c @@ -219,7 +219,7 @@ static int powernow_k6_cpu_init(struct cpufreq_policy *policy) } -static int powernow_k6_cpu_exit(struct cpufreq_policy *policy) +static void powernow_k6_cpu_exit(struct cpufreq_policy *policy) { unsigned int i; @@ -234,10 +234,9 @@ static int powernow_k6_cpu_exit(struct cpufreq_policy *policy) cpufreq_freq_transition_begin(policy, &freqs); powernow_k6_target(policy, i); cpufreq_freq_transition_end(policy, &freqs, 0); - break; + return; } } - return 0; } static unsigned int powernow_k6_get(unsigned int cpu) diff --git a/drivers/cpufreq/powernow-k7.c b/drivers/cpufreq/powernow-k7.c index 5d515fc34836..4271446c8725 100644 --- a/drivers/cpufreq/powernow-k7.c +++ b/drivers/cpufreq/powernow-k7.c @@ -644,7 +644,7 @@ static int powernow_cpu_init(struct cpufreq_policy *policy) return 0; } -static int powernow_cpu_exit(struct cpufreq_policy *policy) +static void powernow_cpu_exit(struct cpufreq_policy *policy) { #ifdef CONFIG_X86_POWERNOW_K7_ACPI if (acpi_processor_perf) { @@ -655,7 +655,6 @@ static int powernow_cpu_exit(struct cpufreq_policy *policy) #endif kfree(powernow_table); - return 0; } static struct cpufreq_driver powernow_driver = { diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index b10f7a1b77f1..a01170f7d01c 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -1089,13 +1089,13 @@ static int powernowk8_cpu_init(struct cpufreq_policy *pol) return -ENODEV; } -static int powernowk8_cpu_exit(struct cpufreq_policy *pol) +static void powernowk8_cpu_exit(struct cpufreq_policy *pol) { struct powernow_k8_data *data = per_cpu(powernow_data, pol->cpu); int cpu; if (!data) - return -EINVAL; + return; powernow_k8_cpu_exit_acpi(data); @@ -1104,8 +1104,6 @@ static int powernowk8_cpu_exit(struct cpufreq_policy *pol) /* pol->cpus will be empty here, use related_cpus instead. */ for_each_cpu(cpu, pol->related_cpus) per_cpu(powernow_data, cpu) = NULL; - - return 0; } static void query_values_on_cpu(void *_err) diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index fddbd1ea1635..50c62929f7ca 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -874,7 +874,7 @@ static int powernv_cpufreq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int powernv_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void powernv_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct powernv_smp_call_data freq_data; struct global_pstate_info *gpstates = policy->driver_data; @@ -886,8 +886,6 @@ static int powernv_cpufreq_cpu_exit(struct cpufreq_policy *policy) del_timer_sync(&gpstates->timer); kfree(policy->driver_data); - - return 0; } static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb, diff --git a/drivers/cpufreq/ppc_cbe_cpufreq.c b/drivers/cpufreq/ppc_cbe_cpufreq.c index 88afc49941b7..5ee4c7bfdcc5 100644 --- a/drivers/cpufreq/ppc_cbe_cpufreq.c +++ b/drivers/cpufreq/ppc_cbe_cpufreq.c @@ -113,10 +113,9 @@ static int cbe_cpufreq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int cbe_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void cbe_cpufreq_cpu_exit(struct cpufreq_policy *policy) { cbe_cpufreq_pmi_policy_exit(policy); - return 0; } static int cbe_cpufreq_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c index ec8df5496a0c..370fe6a0104b 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -573,7 +573,7 @@ static int qcom_cpufreq_hw_cpu_init(struct cpufreq_policy *policy) return qcom_cpufreq_hw_lmh_init(policy, index); } -static int qcom_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) +static void qcom_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) { struct device *cpu_dev = get_cpu_device(policy->cpu); struct qcom_cpufreq_data *data = policy->driver_data; @@ -583,8 +583,6 @@ static int qcom_cpufreq_hw_cpu_exit(struct cpufreq_policy *policy) qcom_cpufreq_hw_lmh_exit(data); kfree(policy->freq_table); kfree(data); - - return 0; } static void qcom_cpufreq_ready(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/qoriq-cpufreq.c b/drivers/cpufreq/qoriq-cpufreq.c index 0aecaecbb0e6..3519bf34d397 100644 --- a/drivers/cpufreq/qoriq-cpufreq.c +++ b/drivers/cpufreq/qoriq-cpufreq.c @@ -225,7 +225,7 @@ static int qoriq_cpufreq_cpu_init(struct cpufreq_policy *policy) return -ENODEV; } -static int qoriq_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void qoriq_cpufreq_cpu_exit(struct cpufreq_policy *policy) { struct cpu_data *data = policy->driver_data; @@ -233,8 +233,6 @@ static int qoriq_cpufreq_cpu_exit(struct cpufreq_policy *policy) kfree(data->table); kfree(data); policy->driver_data = NULL; - - return 0; } static int qoriq_cpufreq_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 3b4f6bfb2f4c..bf5f17f0dfb1 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -308,7 +308,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy) return ret; } -static int scmi_cpufreq_exit(struct cpufreq_policy *policy) +static void scmi_cpufreq_exit(struct cpufreq_policy *policy) { struct scmi_data *priv = policy->driver_data; @@ -316,8 +316,6 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy) dev_pm_opp_remove_all_dynamic(priv->cpu_dev); free_cpumask_var(priv->opp_shared_cpus); kfree(priv); - - return 0; } static void scmi_cpufreq_register_em(struct cpufreq_policy *policy) diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c index d33be56983ed..8d73e6e8be2a 100644 --- a/drivers/cpufreq/scpi-cpufreq.c +++ b/drivers/cpufreq/scpi-cpufreq.c @@ -167,7 +167,7 @@ static int scpi_cpufreq_init(struct cpufreq_policy *policy) return ret; } -static int scpi_cpufreq_exit(struct cpufreq_policy *policy) +static void scpi_cpufreq_exit(struct cpufreq_policy *policy) { struct scpi_data *priv = policy->driver_data; @@ -175,8 +175,6 @@ static int scpi_cpufreq_exit(struct cpufreq_policy *policy) dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table); dev_pm_opp_remove_all_dynamic(priv->cpu_dev); kfree(priv); - - return 0; } static struct cpufreq_driver scpi_cpufreq_driver = { diff --git a/drivers/cpufreq/sh-cpufreq.c b/drivers/cpufreq/sh-cpufreq.c index b8704232c27b..aa74036d0420 100644 --- a/drivers/cpufreq/sh-cpufreq.c +++ b/drivers/cpufreq/sh-cpufreq.c @@ -135,14 +135,12 @@ static int sh_cpufreq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int sh_cpufreq_cpu_exit(struct cpufreq_policy *policy) +static void sh_cpufreq_cpu_exit(struct cpufreq_policy *policy) { unsigned int cpu = policy->cpu; struct clk *cpuclk = &per_cpu(sh_cpuclk, cpu); clk_put(cpuclk); - - return 0; } static struct cpufreq_driver sh_cpufreq_driver = { diff --git a/drivers/cpufreq/sparc-us2e-cpufreq.c b/drivers/cpufreq/sparc-us2e-cpufreq.c index 2783d3d55fce..8a0cd5312a59 100644 --- a/drivers/cpufreq/sparc-us2e-cpufreq.c +++ b/drivers/cpufreq/sparc-us2e-cpufreq.c @@ -296,10 +296,9 @@ static int us2e_freq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int us2e_freq_cpu_exit(struct cpufreq_policy *policy) +static void us2e_freq_cpu_exit(struct cpufreq_policy *policy) { us2e_freq_target(policy, 0); - return 0; } static struct cpufreq_driver cpufreq_us2e_driver = { diff --git a/drivers/cpufreq/sparc-us3-cpufreq.c b/drivers/cpufreq/sparc-us3-cpufreq.c index 6c3657679a88..b50f9d13e6d2 100644 --- a/drivers/cpufreq/sparc-us3-cpufreq.c +++ b/drivers/cpufreq/sparc-us3-cpufreq.c @@ -140,10 +140,9 @@ static int us3_freq_cpu_init(struct cpufreq_policy *policy) return 0; } -static int us3_freq_cpu_exit(struct cpufreq_policy *policy) +static void us3_freq_cpu_exit(struct cpufreq_policy *policy) { us3_freq_target(policy, 0); - return 0; } static struct cpufreq_driver cpufreq_us3_driver = { diff --git a/drivers/cpufreq/speedstep-centrino.c b/drivers/cpufreq/speedstep-centrino.c index ddd6f53bfd2a..3fafedb983b5 100644 --- a/drivers/cpufreq/speedstep-centrino.c +++ b/drivers/cpufreq/speedstep-centrino.c @@ -400,16 +400,12 @@ static int centrino_cpu_init(struct cpufreq_policy *policy) return 0; } -static int centrino_cpu_exit(struct cpufreq_policy *policy) +static void centrino_cpu_exit(struct cpufreq_policy *policy) { unsigned int cpu = policy->cpu; - if (!per_cpu(centrino_model, cpu)) - return -ENODEV; - - per_cpu(centrino_model, cpu) = NULL; - - return 0; + if (per_cpu(centrino_model, cpu)) + per_cpu(centrino_model, cpu) = NULL; } /** diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c index 59865ea455a8..07ea7ed61b68 100644 --- a/drivers/cpufreq/tegra194-cpufreq.c +++ b/drivers/cpufreq/tegra194-cpufreq.c @@ -551,14 +551,12 @@ static int tegra194_cpufreq_offline(struct cpufreq_policy *policy) return 0; } -static int tegra194_cpufreq_exit(struct cpufreq_policy *policy) +static void tegra194_cpufreq_exit(struct cpufreq_policy *policy) { struct device *cpu_dev = get_cpu_device(policy->cpu); dev_pm_opp_remove_all_dynamic(cpu_dev); dev_pm_opp_of_cpumask_remove_table(policy->related_cpus); - - return 0; } static int tegra194_cpufreq_set_target(struct cpufreq_policy *policy, diff --git a/drivers/cpufreq/vexpress-spc-cpufreq.c b/drivers/cpufreq/vexpress-spc-cpufreq.c index 9ac4ea50b874..3fadf536c429 100644 --- a/drivers/cpufreq/vexpress-spc-cpufreq.c +++ b/drivers/cpufreq/vexpress-spc-cpufreq.c @@ -447,7 +447,7 @@ static int ve_spc_cpufreq_init(struct cpufreq_policy *policy) return 0; } -static int ve_spc_cpufreq_exit(struct cpufreq_policy *policy) +static void ve_spc_cpufreq_exit(struct cpufreq_policy *policy) { struct device *cpu_dev; @@ -455,11 +455,10 @@ static int ve_spc_cpufreq_exit(struct cpufreq_policy *policy) if (!cpu_dev) { pr_err("%s: failed to get cpu%d device\n", __func__, policy->cpu); - return -ENODEV; + return; } put_cluster_clk_and_freq_table(cpu_dev, policy->related_cpus); - return 0; } static struct cpufreq_driver ve_spc_cpufreq_driver = { diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 6f57de7de433..d4d2f4d1d7cb 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -396,7 +396,7 @@ struct cpufreq_driver { int (*online)(struct cpufreq_policy *policy); int (*offline)(struct cpufreq_policy *policy); - int (*exit)(struct cpufreq_policy *policy); + void (*exit)(struct cpufreq_policy *policy); int (*suspend)(struct cpufreq_policy *policy); int (*resume)(struct cpufreq_policy *policy); -- 2.31.1.272.g89b43f80a514 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void 2024-07-04 6:53 ` Viresh Kumar @ 2024-07-04 8:27 ` AngeloGioacchino Del Regno -1 siblings, 0 replies; 20+ messages in thread From: AngeloGioacchino Del Regno @ 2024-07-04 8:27 UTC (permalink / raw) To: Viresh Kumar, Rafael J. Wysocki, Huang Rui, Gautham R. Shenoy, Mario Limonciello, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Kevin Hilman, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Sudeep Holla, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger Cc: linux-pm, Vincent Guittot, Lizhe, linux-kernel, asahi, linux-arm-kernel, linux-omap, linuxppc-dev, linux-arm-msm, linux-tegra, linux-mediatek Il 04/07/24 08:53, Viresh Kumar ha scritto: > From: Lizhe <sensor1010@163.com> > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe <sensor1010@163.com> > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> For MediaTek: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void @ 2024-07-04 8:27 ` AngeloGioacchino Del Regno 0 siblings, 0 replies; 20+ messages in thread From: AngeloGioacchino Del Regno @ 2024-07-04 8:27 UTC (permalink / raw) To: Viresh Kumar, Rafael J. Wysocki, Huang Rui, Gautham R. Shenoy, Mario Limonciello, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Kevin Hilman, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Sudeep Holla, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger Cc: Vincent Guittot, linux-pm, Lizhe, linux-kernel, linux-mediatek, asahi, linux-arm-msm, linux-tegra, linux-omap, linuxppc-dev, linux-arm-kernel Il 04/07/24 08:53, Viresh Kumar ha scritto: > From: Lizhe <sensor1010@163.com> > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe <sensor1010@163.com> > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> For MediaTek: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void 2024-07-04 6:53 ` Viresh Kumar @ 2024-07-04 9:26 ` Sudeep Holla -1 siblings, 0 replies; 20+ messages in thread From: Sudeep Holla @ 2024-07-04 9:26 UTC (permalink / raw) To: Viresh Kumar Cc: Rafael J. Wysocki, Huang Rui, Sudeep Holla, Gautham R. Shenoy, Mario Limonciello, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Kevin Hilman, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger, AngeloGioacchino Del Regno, linux-pm, Vincent Guittot, Lizhe, linux-kernel, asahi, linux-arm-kernel, linux-omap, linuxppc-dev, linux-arm-msm, linux-tegra, linux-mediatek On Thu, Jul 04, 2024 at 12:23:55PM +0530, Viresh Kumar wrote: > From: Lizhe <sensor1010@163.com> > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe <sensor1010@163.com> > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- [...] > drivers/cpufreq/scmi-cpufreq.c | 4 +--- > drivers/cpufreq/scpi-cpufreq.c | 4 +--- > drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- (For the above 3 files) Acked-by: Sudeep Holla <sudeep.holla@arm.com> -- Regards, Sudeep ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void @ 2024-07-04 9:26 ` Sudeep Holla 0 siblings, 0 replies; 20+ messages in thread From: Sudeep Holla @ 2024-07-04 9:26 UTC (permalink / raw) To: Viresh Kumar Cc: Rafael J. Wysocki, linux-tegra, Perry Yuan, Huang Rui, Mario Limonciello, Srinivas Pandruvada, Alyssa Rosenzweig, Vincent Guittot, Kevin Hilman, linux-pm, Christophe Leroy, Jonathan Hunter, Broadcom internal kernel review list, linux-arm-kernel, linux-arm-msm, Naveen N. Rao, Len Brown, Sven Peter, Lizhe, Nicholas Piggin, linux-mediatek, Markus Mayer, Matthias Brugger, linux-omap, Cristian Marussi, AngeloGioacchino Del Regno, Hector Martin, linux-kernel, Thierry Reding, asahi, Gautham R. Shenoy, Sudeep Holla, linuxppc-dev On Thu, Jul 04, 2024 at 12:23:55PM +0530, Viresh Kumar wrote: > From: Lizhe <sensor1010@163.com> > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe <sensor1010@163.com> > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- [...] > drivers/cpufreq/scmi-cpufreq.c | 4 +--- > drivers/cpufreq/scpi-cpufreq.c | 4 +--- > drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- (For the above 3 files) Acked-by: Sudeep Holla <sudeep.holla@arm.com> -- Regards, Sudeep ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void 2024-07-04 6:53 ` Viresh Kumar @ 2024-07-04 11:56 ` Mario Limonciello -1 siblings, 0 replies; 20+ messages in thread From: Mario Limonciello @ 2024-07-04 11:56 UTC (permalink / raw) To: Viresh Kumar, Rafael J. Wysocki, Huang Rui, Gautham R. Shenoy, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Kevin Hilman, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Sudeep Holla, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger, AngeloGioacchino Del Regno Cc: linux-pm, Vincent Guittot, Lizhe, linux-kernel, asahi, linux-arm-kernel, linux-omap, linuxppc-dev, linux-arm-msm, linux-tegra, linux-mediatek On 7/4/2024 1:53, Viresh Kumar wrote: > From: Lizhe <sensor1010@163.com> > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe <sensor1010@163.com> > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/acpi-cpufreq.c | 4 +--- > drivers/cpufreq/amd-pstate.c | 7 ++----- > drivers/cpufreq/apple-soc-cpufreq.c | 4 +--- > drivers/cpufreq/bmips-cpufreq.c | 4 +--- > drivers/cpufreq/cppc_cpufreq.c | 3 +-- > drivers/cpufreq/cpufreq-dt.c | 3 +-- > drivers/cpufreq/e_powersaver.c | 3 +-- > drivers/cpufreq/intel_pstate.c | 8 +++----- > drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +--- > drivers/cpufreq/mediatek-cpufreq.c | 4 +--- > drivers/cpufreq/omap-cpufreq.c | 3 +-- > drivers/cpufreq/pasemi-cpufreq.c | 6 ++---- > drivers/cpufreq/powernow-k6.c | 5 ++--- > drivers/cpufreq/powernow-k7.c | 3 +-- > drivers/cpufreq/powernow-k8.c | 6 ++---- > drivers/cpufreq/powernv-cpufreq.c | 4 +--- > drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +-- > drivers/cpufreq/qcom-cpufreq-hw.c | 4 +--- > drivers/cpufreq/qoriq-cpufreq.c | 4 +--- > drivers/cpufreq/scmi-cpufreq.c | 4 +--- > drivers/cpufreq/scpi-cpufreq.c | 4 +--- > drivers/cpufreq/sh-cpufreq.c | 4 +--- > drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +-- > drivers/cpufreq/sparc-us3-cpufreq.c | 3 +-- > drivers/cpufreq/speedstep-centrino.c | 10 +++------- > drivers/cpufreq/tegra194-cpufreq.c | 4 +--- > drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- > include/linux/cpufreq.h | 2 +- > 28 files changed, 37 insertions(+), 84 deletions(-) Acked-by: Mario Limonciello <mario.limonciello@amd.com> # drivers/cpufreq/amd-pstate.c ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void @ 2024-07-04 11:56 ` Mario Limonciello 0 siblings, 0 replies; 20+ messages in thread From: Mario Limonciello @ 2024-07-04 11:56 UTC (permalink / raw) To: Viresh Kumar, Rafael J. Wysocki, Huang Rui, Gautham R. Shenoy, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Kevin Hilman, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Sudeep Holla, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger, AngeloGioacchino Del Regno Cc: Vincent Guittot, linux-pm, Lizhe, linux-kernel, linux-mediatek, asahi, linux-arm-msm, linux-tegra, linux-omap, linuxppc-dev, linux-arm-kernel On 7/4/2024 1:53, Viresh Kumar wrote: > From: Lizhe <sensor1010@163.com> > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe <sensor1010@163.com> > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/acpi-cpufreq.c | 4 +--- > drivers/cpufreq/amd-pstate.c | 7 ++----- > drivers/cpufreq/apple-soc-cpufreq.c | 4 +--- > drivers/cpufreq/bmips-cpufreq.c | 4 +--- > drivers/cpufreq/cppc_cpufreq.c | 3 +-- > drivers/cpufreq/cpufreq-dt.c | 3 +-- > drivers/cpufreq/e_powersaver.c | 3 +-- > drivers/cpufreq/intel_pstate.c | 8 +++----- > drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +--- > drivers/cpufreq/mediatek-cpufreq.c | 4 +--- > drivers/cpufreq/omap-cpufreq.c | 3 +-- > drivers/cpufreq/pasemi-cpufreq.c | 6 ++---- > drivers/cpufreq/powernow-k6.c | 5 ++--- > drivers/cpufreq/powernow-k7.c | 3 +-- > drivers/cpufreq/powernow-k8.c | 6 ++---- > drivers/cpufreq/powernv-cpufreq.c | 4 +--- > drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +-- > drivers/cpufreq/qcom-cpufreq-hw.c | 4 +--- > drivers/cpufreq/qoriq-cpufreq.c | 4 +--- > drivers/cpufreq/scmi-cpufreq.c | 4 +--- > drivers/cpufreq/scpi-cpufreq.c | 4 +--- > drivers/cpufreq/sh-cpufreq.c | 4 +--- > drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +-- > drivers/cpufreq/sparc-us3-cpufreq.c | 3 +-- > drivers/cpufreq/speedstep-centrino.c | 10 +++------- > drivers/cpufreq/tegra194-cpufreq.c | 4 +--- > drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- > include/linux/cpufreq.h | 2 +- > 28 files changed, 37 insertions(+), 84 deletions(-) Acked-by: Mario Limonciello <mario.limonciello@amd.com> # drivers/cpufreq/amd-pstate.c ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void 2024-07-04 6:53 ` Viresh Kumar @ 2024-07-04 14:42 ` Florian Fainelli -1 siblings, 0 replies; 20+ messages in thread From: Florian Fainelli @ 2024-07-04 14:42 UTC (permalink / raw) To: Viresh Kumar, Rafael J. Wysocki, Huang Rui, Gautham R. Shenoy, Mario Limonciello, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Kevin Hilman, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Sudeep Holla, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger, AngeloGioacchino Del Regno Cc: linux-pm, Vincent Guittot, Lizhe, linux-kernel, asahi, linux-arm-kernel, linux-omap, linuxppc-dev, linux-arm-msm, linux-tegra, linux-mediatek [-- Attachment #1: Type: text/plain, Size: 601 bytes --] On 7/4/2024 7:53 AM, Viresh Kumar wrote: > From: Lizhe <sensor1010@163.com> > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe <sensor1010@163.com> > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/bmips-cpufreq.c | 4 +--- For the above: Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> -- Florian [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4221 bytes --] ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void @ 2024-07-04 14:42 ` Florian Fainelli 0 siblings, 0 replies; 20+ messages in thread From: Florian Fainelli @ 2024-07-04 14:42 UTC (permalink / raw) To: Viresh Kumar, Rafael J. Wysocki, Huang Rui, Gautham R. Shenoy, Mario Limonciello, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Kevin Hilman, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Sudeep Holla, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger, AngeloGioacchino Del Regno Cc: Vincent Guittot, linux-pm, Lizhe, linux-kernel, linux-mediatek, asahi, linux-arm-msm, linux-tegra, linux-omap, linuxppc-dev, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 601 bytes --] On 7/4/2024 7:53 AM, Viresh Kumar wrote: > From: Lizhe <sensor1010@163.com> > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe <sensor1010@163.com> > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/bmips-cpufreq.c | 4 +--- For the above: Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> -- Florian [-- Attachment #2: S/MIME Cryptographic Signature --] [-- Type: application/pkcs7-signature, Size: 4221 bytes --] ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void 2024-07-04 6:53 ` Viresh Kumar @ 2024-07-09 0:24 ` Kevin Hilman -1 siblings, 0 replies; 20+ messages in thread From: Kevin Hilman @ 2024-07-09 0:24 UTC (permalink / raw) To: Viresh Kumar, Rafael J. Wysocki, Viresh Kumar, Huang Rui, Gautham R. Shenoy, Mario Limonciello, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Sudeep Holla, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger, AngeloGioacchino Del Regno Cc: linux-pm, Vincent Guittot, Lizhe, linux-kernel, asahi, linux-arm-kernel, linux-omap, linuxppc-dev, linux-arm-msm, linux-tegra, linux-mediatek Viresh Kumar <viresh.kumar@linaro.org> writes: > From: Lizhe <sensor1010@163.com> > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe <sensor1010@163.com> > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- [...] > drivers/cpufreq/omap-cpufreq.c | 3 +-- For OMAP: Acked-by: Kevin Hilman <khilman@baylibre.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void @ 2024-07-09 0:24 ` Kevin Hilman 0 siblings, 0 replies; 20+ messages in thread From: Kevin Hilman @ 2024-07-09 0:24 UTC (permalink / raw) To: Viresh Kumar, Rafael J. Wysocki, Viresh Kumar, Huang Rui, Gautham R. Shenoy, Mario Limonciello, Perry Yuan, Hector Martin, Sven Peter, Alyssa Rosenzweig, Markus Mayer, Broadcom internal kernel review list, Srinivas Pandruvada, Len Brown, Michael Ellerman, Nicholas Piggin, Christophe Leroy, Naveen N. Rao, Sudeep Holla, Cristian Marussi, Thierry Reding, Jonathan Hunter, Matthias Brugger, AngeloGioacchino Del Regno Cc: Vincent Guittot, linux-pm, Lizhe, linux-kernel, linux-mediatek, asahi, linux-arm-msm, linux-tegra, linux-omap, linuxppc-dev, linux-arm-kernel Viresh Kumar <viresh.kumar@linaro.org> writes: > From: Lizhe <sensor1010@163.com> > > The cpufreq core doesn't check the return type of the exit() callback > and there is not much the core can do on failures at that point. Just > drop the returned value and make it return void. > > Signed-off-by: Lizhe <sensor1010@163.com> > [ Viresh: Reworked the patches to fix all missing changes together. ] > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- [...] > drivers/cpufreq/omap-cpufreq.c | 3 +-- For OMAP: Acked-by: Kevin Hilman <khilman@baylibre.com> ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/4] cpufreq: Make cpufreq_driver->exit() return void 2024-07-04 6:53 ` Viresh Kumar @ 2024-07-04 12:02 ` Rafael J. Wysocki -1 siblings, 0 replies; 20+ messages in thread From: Rafael J. Wysocki @ 2024-07-04 12:02 UTC (permalink / raw) To: Viresh Kumar Cc: Rafael J. Wysocki, Alyssa Rosenzweig, AngeloGioacchino Del Regno, Broadcom internal kernel review list, Christophe Leroy, Cristian Marussi, Gautham R. Shenoy, Hector Martin, Huang Rui, Jiaxun Yang, Jonathan Hunter, Kevin Hilman, Len Brown, Mario Limonciello, Markus Mayer, Matthias Brugger, Michael Ellerman, Naveen N. Rao, Nicholas Piggin, Perry Yuan, Srinivas Pandruvada, Sudeep Holla, Sven Peter, Thierry Reding, linux-pm, Vincent Guittot, asahi, linux-arm-kernel, linux-arm-msm, linux-kernel, linux-mediatek, linux-mips, linux-omap, linuxppc-dev, linux-tegra, Lizhe On Thu, Jul 4, 2024 at 8:54 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > Make exit() return void, since it isn't used by the core. > > Based on initial patches sent by Lizhe [1]. > > Rafael, I will take this through my tree for 6.11. Sure. Acked-by: Rafael J. Wysocki <rafael@kernel.org> for the series. Thanks! > -- > Viresh > > [1] https://lore.kernel.org/all/20240410132132.3526-1-sensor1010@163.com/ > > Lizhe (1): > cpufreq: Make cpufreq_driver->exit() return void > > Viresh Kumar (3): > cpufreq: nforce2: Remove empty exit() callback > cpufreq: loongson2: Remove empty exit() callback > cpufreq: pcc: Remove empty exit() callback > > drivers/cpufreq/acpi-cpufreq.c | 4 +--- > drivers/cpufreq/amd-pstate.c | 7 ++----- > drivers/cpufreq/apple-soc-cpufreq.c | 4 +--- > drivers/cpufreq/bmips-cpufreq.c | 4 +--- > drivers/cpufreq/cppc_cpufreq.c | 3 +-- > drivers/cpufreq/cpufreq-dt.c | 3 +-- > drivers/cpufreq/cpufreq-nforce2.c | 6 ------ > drivers/cpufreq/e_powersaver.c | 3 +-- > drivers/cpufreq/intel_pstate.c | 8 +++----- > drivers/cpufreq/loongson2_cpufreq.c | 6 ------ > drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +--- > drivers/cpufreq/mediatek-cpufreq.c | 4 +--- > drivers/cpufreq/omap-cpufreq.c | 3 +-- > drivers/cpufreq/pasemi-cpufreq.c | 6 ++---- > drivers/cpufreq/pcc-cpufreq.c | 6 ------ > drivers/cpufreq/powernow-k6.c | 5 ++--- > drivers/cpufreq/powernow-k7.c | 3 +-- > drivers/cpufreq/powernow-k8.c | 6 ++---- > drivers/cpufreq/powernv-cpufreq.c | 4 +--- > drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +-- > drivers/cpufreq/qcom-cpufreq-hw.c | 4 +--- > drivers/cpufreq/qoriq-cpufreq.c | 4 +--- > drivers/cpufreq/scmi-cpufreq.c | 4 +--- > drivers/cpufreq/scpi-cpufreq.c | 4 +--- > drivers/cpufreq/sh-cpufreq.c | 4 +--- > drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +-- > drivers/cpufreq/sparc-us3-cpufreq.c | 3 +-- > drivers/cpufreq/speedstep-centrino.c | 10 +++------- > drivers/cpufreq/tegra194-cpufreq.c | 4 +--- > drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- > include/linux/cpufreq.h | 2 +- > 31 files changed, 37 insertions(+), 102 deletions(-) > > -- > 2.31.1.272.g89b43f80a514 > > ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 0/4] cpufreq: Make cpufreq_driver->exit() return void @ 2024-07-04 12:02 ` Rafael J. Wysocki 0 siblings, 0 replies; 20+ messages in thread From: Rafael J. Wysocki @ 2024-07-04 12:02 UTC (permalink / raw) To: Viresh Kumar Cc: Rafael J. Wysocki, Jiaxun Yang, linux-mips, linux-tegra, Perry Yuan, Huang Rui, Mario Limonciello, Srinivas Pandruvada, Alyssa Rosenzweig, Vincent Guittot, Kevin Hilman, linux-pm, Christophe Leroy, Jonathan Hunter, Broadcom internal kernel review list, linux-arm-kernel, Lizhe, Naveen N. Rao, Len Brown, Sven Peter, linux-arm-msm, Nicholas Piggin, linux-mediatek, Markus Mayer, Matthias Brugger, linux-omap, Cristian Marussi, AngeloGioacchino Del Regno, Hector Martin, linux-kernel, Thierry Reding, asahi, Gautham R. Shenoy, Sudeep Holla, linuxppc-dev On Thu, Jul 4, 2024 at 8:54 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > Make exit() return void, since it isn't used by the core. > > Based on initial patches sent by Lizhe [1]. > > Rafael, I will take this through my tree for 6.11. Sure. Acked-by: Rafael J. Wysocki <rafael@kernel.org> for the series. Thanks! > -- > Viresh > > [1] https://lore.kernel.org/all/20240410132132.3526-1-sensor1010@163.com/ > > Lizhe (1): > cpufreq: Make cpufreq_driver->exit() return void > > Viresh Kumar (3): > cpufreq: nforce2: Remove empty exit() callback > cpufreq: loongson2: Remove empty exit() callback > cpufreq: pcc: Remove empty exit() callback > > drivers/cpufreq/acpi-cpufreq.c | 4 +--- > drivers/cpufreq/amd-pstate.c | 7 ++----- > drivers/cpufreq/apple-soc-cpufreq.c | 4 +--- > drivers/cpufreq/bmips-cpufreq.c | 4 +--- > drivers/cpufreq/cppc_cpufreq.c | 3 +-- > drivers/cpufreq/cpufreq-dt.c | 3 +-- > drivers/cpufreq/cpufreq-nforce2.c | 6 ------ > drivers/cpufreq/e_powersaver.c | 3 +-- > drivers/cpufreq/intel_pstate.c | 8 +++----- > drivers/cpufreq/loongson2_cpufreq.c | 6 ------ > drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +--- > drivers/cpufreq/mediatek-cpufreq.c | 4 +--- > drivers/cpufreq/omap-cpufreq.c | 3 +-- > drivers/cpufreq/pasemi-cpufreq.c | 6 ++---- > drivers/cpufreq/pcc-cpufreq.c | 6 ------ > drivers/cpufreq/powernow-k6.c | 5 ++--- > drivers/cpufreq/powernow-k7.c | 3 +-- > drivers/cpufreq/powernow-k8.c | 6 ++---- > drivers/cpufreq/powernv-cpufreq.c | 4 +--- > drivers/cpufreq/ppc_cbe_cpufreq.c | 3 +-- > drivers/cpufreq/qcom-cpufreq-hw.c | 4 +--- > drivers/cpufreq/qoriq-cpufreq.c | 4 +--- > drivers/cpufreq/scmi-cpufreq.c | 4 +--- > drivers/cpufreq/scpi-cpufreq.c | 4 +--- > drivers/cpufreq/sh-cpufreq.c | 4 +--- > drivers/cpufreq/sparc-us2e-cpufreq.c | 3 +-- > drivers/cpufreq/sparc-us3-cpufreq.c | 3 +-- > drivers/cpufreq/speedstep-centrino.c | 10 +++------- > drivers/cpufreq/tegra194-cpufreq.c | 4 +--- > drivers/cpufreq/vexpress-spc-cpufreq.c | 5 ++--- > include/linux/cpufreq.h | 2 +- > 31 files changed, 37 insertions(+), 102 deletions(-) > > -- > 2.31.1.272.g89b43f80a514 > > ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2024-07-09 0:24 UTC | newest] Thread overview: 20+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-07-04 6:53 [PATCH 0/4] cpufreq: Make cpufreq_driver->exit() return void Viresh Kumar 2024-07-04 6:53 ` Viresh Kumar 2024-07-04 6:53 ` [PATCH 1/4] cpufreq: nforce2: Remove empty exit() callback Viresh Kumar 2024-07-04 6:53 ` [PATCH 2/4] cpufreq: loongson2: " Viresh Kumar 2024-07-04 9:36 ` Huacai Chen 2024-07-04 6:53 ` [PATCH 3/4] cpufreq: pcc: " Viresh Kumar 2024-07-04 6:53 ` [PATCH 4/4] cpufreq: Make cpufreq_driver->exit() return void Viresh Kumar 2024-07-04 6:53 ` Viresh Kumar 2024-07-04 8:27 ` AngeloGioacchino Del Regno 2024-07-04 8:27 ` AngeloGioacchino Del Regno 2024-07-04 9:26 ` Sudeep Holla 2024-07-04 9:26 ` Sudeep Holla 2024-07-04 11:56 ` Mario Limonciello 2024-07-04 11:56 ` Mario Limonciello 2024-07-04 14:42 ` Florian Fainelli 2024-07-04 14:42 ` Florian Fainelli 2024-07-09 0:24 ` Kevin Hilman 2024-07-09 0:24 ` Kevin Hilman 2024-07-04 12:02 ` [PATCH 0/4] " Rafael J. Wysocki 2024-07-04 12:02 ` Rafael J. Wysocki
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.