From: Kevin Hilman <khilman@baylibre.com>
To: Xingyu Chen <xingyu.chen@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Qianggui Song <qianggui.song@amlogic.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jianxin Pan <jianxin.pan@amlogic.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Jian Hu <jian.hu@amlogic.com>,
Xingyu Chen <xingyu.chen@amlogic.com>,
linux-amlogic@lists.infradead.org,
Jonathan Cameron <jic23@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH] arm64: dts: a1: add saradc controller
Date: Mon, 09 Dec 2019 14:56:32 -0800 [thread overview]
Message-ID: <7hpngxqfa7.fsf@baylibre.com> (raw)
In-Reply-To: <1575358332-44866-1-git-send-email-xingyu.chen@amlogic.com>
Xingyu Chen <xingyu.chen@amlogic.com> writes:
> The saradc controller in Meson-A1 is the same as the Meson-G12 series SoCs,
> so we use the same compatible string.
>
> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
>
> ---
> This patch is based on A1 clock patchset at [0].
>
> [0] https://lore.kernel.org/linux-amlogic/20191129144605.182774-1-jian.hu@amlogic.com
> ---
> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index 7210ad0..cad1756 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -93,6 +93,21 @@
> clock-names = "xtal", "pclk", "baud";
> status = "disabled";
> };
> +
> + saradc: adc@2c00 {
> + compatible = "amlogic,meson-g12a-saradc",
> + "amlogic,meson-saradc";
> + reg = <0x0 0x2c00 0x0 0x48>;
Why 0x48 here? AXG uses 0x38 and you're not adding any more registers
to this driver.
Kevin
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Xingyu Chen <xingyu.chen@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Xingyu Chen <xingyu.chen@amlogic.com>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Qianggui Song <qianggui.song@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>,
Jian Hu <jian.hu@amlogic.com>,
linux-iio@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: a1: add saradc controller
Date: Mon, 09 Dec 2019 14:56:32 -0800 [thread overview]
Message-ID: <7hpngxqfa7.fsf@baylibre.com> (raw)
In-Reply-To: <1575358332-44866-1-git-send-email-xingyu.chen@amlogic.com>
Xingyu Chen <xingyu.chen@amlogic.com> writes:
> The saradc controller in Meson-A1 is the same as the Meson-G12 series SoCs,
> so we use the same compatible string.
>
> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
>
> ---
> This patch is based on A1 clock patchset at [0].
>
> [0] https://lore.kernel.org/linux-amlogic/20191129144605.182774-1-jian.hu@amlogic.com
> ---
> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index 7210ad0..cad1756 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -93,6 +93,21 @@
> clock-names = "xtal", "pclk", "baud";
> status = "disabled";
> };
> +
> + saradc: adc@2c00 {
> + compatible = "amlogic,meson-g12a-saradc",
> + "amlogic,meson-saradc";
> + reg = <0x0 0x2c00 0x0 0x48>;
Why 0x48 here? AXG uses 0x38 and you're not adding any more registers
to this driver.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Xingyu Chen <xingyu.chen@amlogic.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Qianggui Song <qianggui.song@amlogic.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Jianxin Pan <jianxin.pan@amlogic.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Jian Hu <jian.hu@amlogic.com>,
Xingyu Chen <xingyu.chen@amlogic.com>,
linux-amlogic@lists.infradead.org,
Jonathan Cameron <jic23@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH] arm64: dts: a1: add saradc controller
Date: Mon, 09 Dec 2019 14:56:32 -0800 [thread overview]
Message-ID: <7hpngxqfa7.fsf@baylibre.com> (raw)
In-Reply-To: <1575358332-44866-1-git-send-email-xingyu.chen@amlogic.com>
Xingyu Chen <xingyu.chen@amlogic.com> writes:
> The saradc controller in Meson-A1 is the same as the Meson-G12 series SoCs,
> so we use the same compatible string.
>
> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
>
> ---
> This patch is based on A1 clock patchset at [0].
>
> [0] https://lore.kernel.org/linux-amlogic/20191129144605.182774-1-jian.hu@amlogic.com
> ---
> arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> index 7210ad0..cad1756 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
> @@ -93,6 +93,21 @@
> clock-names = "xtal", "pclk", "baud";
> status = "disabled";
> };
> +
> + saradc: adc@2c00 {
> + compatible = "amlogic,meson-g12a-saradc",
> + "amlogic,meson-saradc";
> + reg = <0x0 0x2c00 0x0 0x48>;
Why 0x48 here? AXG uses 0x38 and you're not adding any more registers
to this driver.
Kevin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-09 22:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 7:32 [PATCH] arm64: dts: a1: add saradc controller Xingyu Chen
2019-12-03 7:32 ` Xingyu Chen
2019-12-03 7:32 ` Xingyu Chen
2019-12-09 22:56 ` Kevin Hilman [this message]
2019-12-09 22:56 ` Kevin Hilman
2019-12-09 22:56 ` Kevin Hilman
2019-12-10 3:57 ` Xingyu Chen
2019-12-10 3:57 ` Xingyu Chen
2019-12-10 3:57 ` Xingyu Chen
2019-12-10 18:41 ` Kevin Hilman
2019-12-10 18:41 ` Kevin Hilman
2019-12-10 18:41 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hpngxqfa7.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jian.hu@amlogic.com \
--cc=jianxin.pan@amlogic.com \
--cc=jic23@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=qianggui.song@amlogic.com \
--cc=robh+dt@kernel.org \
--cc=xingyu.chen@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.