From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 8/9] mmc: meson-gx: remove unneeded checks in remove
Date: Fri, 03 Feb 2017 10:20:38 -0800 [thread overview]
Message-ID: <7hr33fuoeh.fsf@baylibre.com> (raw)
In-Reply-To: <abf8a44d-7381-ea1f-44c6-27ccec3f647d@gmail.com> (Heiner Kallweit's message of "Wed, 1 Feb 2017 07:49:27 +0100")
Heiner Kallweit <hkallweit1@gmail.com> writes:
> The remove callback is called only if probe finished successfully.
> Therefore these checks are not needed.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
> ---
> v2:
> - no changes
> ---
> drivers/mmc/host/meson-gx-mmc.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 48ce4ba4..bc787444 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -811,15 +811,11 @@ static int meson_mmc_remove(struct platform_device *pdev)
> {
> struct meson_host *host = dev_get_drvdata(&pdev->dev);
>
> - if (WARN_ON(!host))
> - return 0;
> -
> /* disable interrupts */
> writel(0, host->regs + SD_EMMC_IRQ_EN);
>
> - if (host->bounce_buf)
> - dma_free_coherent(host->dev, host->bounce_buf_size,
> - host->bounce_buf, host->bounce_dma_addr);
> + dma_free_coherent(host->dev, host->bounce_buf_size,
> + host->bounce_buf, host->bounce_dma_addr);
>
> clk_disable_unprepare(host->cfg_div_clk);
> clk_disable_unprepare(host->core_clk);
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Carlo Caione <carlo@caione.org>,
linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 8/9] mmc: meson-gx: remove unneeded checks in remove
Date: Fri, 03 Feb 2017 10:20:38 -0800 [thread overview]
Message-ID: <7hr33fuoeh.fsf@baylibre.com> (raw)
In-Reply-To: <abf8a44d-7381-ea1f-44c6-27ccec3f647d@gmail.com> (Heiner Kallweit's message of "Wed, 1 Feb 2017 07:49:27 +0100")
Heiner Kallweit <hkallweit1@gmail.com> writes:
> The remove callback is called only if probe finished successfully.
> Therefore these checks are not needed.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
> ---
> v2:
> - no changes
> ---
> drivers/mmc/host/meson-gx-mmc.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 48ce4ba4..bc787444 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -811,15 +811,11 @@ static int meson_mmc_remove(struct platform_device *pdev)
> {
> struct meson_host *host = dev_get_drvdata(&pdev->dev);
>
> - if (WARN_ON(!host))
> - return 0;
> -
> /* disable interrupts */
> writel(0, host->regs + SD_EMMC_IRQ_EN);
>
> - if (host->bounce_buf)
> - dma_free_coherent(host->dev, host->bounce_buf_size,
> - host->bounce_buf, host->bounce_dma_addr);
> + dma_free_coherent(host->dev, host->bounce_buf_size,
> + host->bounce_buf, host->bounce_dma_addr);
>
> clk_disable_unprepare(host->cfg_div_clk);
> clk_disable_unprepare(host->core_clk);
next prev parent reply other threads:[~2017-02-03 18:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <584e5061-d359-1436-05ee-3767a5a4b10f@gmail.com>
2017-02-01 6:48 ` [PATCH v2 2/9] mmc: meson-gx: minor improvements in meson_mmc_set_ios Heiner Kallweit
2017-02-01 6:48 ` Heiner Kallweit
2017-02-01 6:48 ` [PATCH v2 3/9] mmc: meson-gx: improve meson_mmc_clk_set Heiner Kallweit
2017-02-01 6:48 ` Heiner Kallweit
2017-02-01 6:48 ` [PATCH v2 4/9] mmc: meson-gx: improve meson_mmc_irq_thread Heiner Kallweit
2017-02-01 6:48 ` Heiner Kallweit
2017-02-03 18:03 ` Kevin Hilman
2017-02-03 18:03 ` Kevin Hilman
2017-02-01 6:48 ` [PATCH v2 5/9] mmc: meson-gx: improve interrupt handling Heiner Kallweit
2017-02-01 6:48 ` Heiner Kallweit
2017-02-03 18:10 ` Kevin Hilman
2017-02-03 18:10 ` Kevin Hilman
2017-02-01 6:49 ` [PATCH v2 6/9] mmc: meson-gx: set max block count and request size Heiner Kallweit
2017-02-01 6:49 ` Heiner Kallweit
2017-02-01 6:49 ` [PATCH v2 7/9] mmc: meson-gx: reduce bounce buffer size Heiner Kallweit
2017-02-01 6:49 ` Heiner Kallweit
2017-02-03 18:18 ` Kevin Hilman
2017-02-03 18:18 ` Kevin Hilman
2017-02-01 6:49 ` [PATCH v2 8/9] mmc: meson-gx: remove unneeded checks in remove Heiner Kallweit
2017-02-01 6:49 ` Heiner Kallweit
2017-02-03 18:20 ` Kevin Hilman [this message]
2017-02-03 18:20 ` Kevin Hilman
2017-02-01 6:49 ` [PATCH v2 9/9] mmc: meson-gx: add support for HS400 mode Heiner Kallweit
2017-02-01 6:49 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hr33fuoeh.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.